Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1198734ybt; Thu, 18 Jun 2020 03:01:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2rka/P6+3iE+0HdeiqvU/37VWUvTkH/sBSMGZNaYcMXJc6f2JHEzfJHG06K8S2wYFQU6a X-Received: by 2002:a05:6402:1604:: with SMTP id f4mr3329495edv.379.1592474481172; Thu, 18 Jun 2020 03:01:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592474481; cv=none; d=google.com; s=arc-20160816; b=Xp/hxMe+k+YjZlZALYHh58Vsqx499L6XxauZDHuI3LtTf1icwRHHS/dhsPiaa1gdoP D3ndJ8bpP2CJDKPiP7GTcjxBiOqMuO9gTTdSnFJJMu3wNJKxgxP0imPNYL2vXWBZ/P8Y U42DBLEmmIEdzgbadFU9gbev76ehi6OMe3feFNtaK8BIL0ppULlXfvljAWaPuoUmry+S zWR2stFafZjX2xYNu99bKsfXEG/aDHZskcAE4+ncQleBRHMIM9PLjMM/WTf2H9L21Oex z87XxHJ6wLIjtfAWu6oFGnfjGxtWe+Ek6Fw4gh1Ghu2E6mAs6NCzBX+zGS6qMiFa3Zg+ MJng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bD+k/71u8ehtJTB/BfPHQSZXrBCbz3j42tBcsHer+pc=; b=EK+J7zjP5u7fW00Crp9+yDrSQ7dd9Q7u7jWQ4lj22ZyM8olXFRGuW39G6G6rz+DKhO OdqQ+Z3T/Bgukl+30nbr6leemfpJuYWscjiKKyXGN4Gp56haRRHF5Jg4mHgV8uRsrcuA MyZX89uXz4ICVI1OlwDXo2TGXVDSC8QNXk6gDWhr0+vNaPTTsYYalPIUhmsa+5J2PLSJ o3zpTCfocI884cgHBKKcu2Yr7XpvIbM+09j6uwtXls+qhdGSxapfLglnWPKJKSRJnIqC FElM7QQg1j9IzBKOV45/DLdeq65q2Mg6Gv57jIjJQqkh+Q/I+hW+hgPlYBK78LPTeU7D YdtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XIoxWHiq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e9si1486001eja.348.2020.06.18.03.00.57; Thu, 18 Jun 2020 03:01:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XIoxWHiq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728940AbgFRIzw (ORCPT + 99 others); Thu, 18 Jun 2020 04:55:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728877AbgFRIzn (ORCPT ); Thu, 18 Jun 2020 04:55:43 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E2B7C0613EE for ; Thu, 18 Jun 2020 01:55:42 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id s23so2482172pfh.7 for ; Thu, 18 Jun 2020 01:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bD+k/71u8ehtJTB/BfPHQSZXrBCbz3j42tBcsHer+pc=; b=XIoxWHiq6wFH2Q4rKPjZbpDTtMZUUxXaqOIOfCZc46/aabF3E+FLUQc2JP+DFmNg3Z Io04YnjNr3iIYoMsgpwcYbm3HWzTnyaQR8asCJTUmZq05R2nDZZ/cjYreN1csbYQeMwx IqDgU7EpjpDytHFWxPjZNW2LHSvLSx47Y8tILYBSyTev7/b71tl2kLgYgBeEHuQUUp+0 nEFbD1NFHIW66S0o9fqRDWL0DZCOt5WkXszK3fDptKYRf9DCos8fHA72AHJfVQA7AaKZ 4kNdnYOfwXwHIyaYn/xO2D4xBeuO1Y+neyApEzfEGNN1OrS7TJovSH8UQzH1rfRmyD46 Xllw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bD+k/71u8ehtJTB/BfPHQSZXrBCbz3j42tBcsHer+pc=; b=bmPZHagqfjcCh+Gb7YshpYqERNjCYgG0BAJvsi7tfw97y0Jwd/yyeWn5w+uzLcW8Kj EIVFm3P2ShJwGcDuzR07fsK8hDdE+ZgkjsWOHJHYhjwKr7jFXMFZCUT0dRzlrxlg9FAf 12KAvuYMk0tLRLHpyAC2hI/D4dEc/VCC1sCrRrFw+eO5Ea79Ui9SrUUtmLGihFfS8qzq FROuzo5o13kYjD/C+3qaOdF5MvLMbWBT+DOfWn912w6MMByiELiejslXi6JpezJ8px0O XHHGrfGcDHBBMVtTC3z15G8brHAHKv6u0Qzrg8BmXVG2YWZPoQeWhhbUS6XXIZRWz/tL 23TA== X-Gm-Message-State: AOAM532GjP8UundjMRLxEk8GXKXGORvxiZNoZB/xfhSaNbosOfrg/M0Q m+5RuJXeliTS6JaXAv1HaVts1Go4J1TM X-Received: by 2002:a62:37c1:: with SMTP id e184mr2628635pfa.238.1592470541355; Thu, 18 Jun 2020 01:55:41 -0700 (PDT) Received: from mani ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id j12sm2273422pfd.21.2020.06.18.01.55.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jun 2020 01:55:40 -0700 (PDT) Date: Thu, 18 Jun 2020 14:25:33 +0530 From: Manivannan Sadhasivam To: Marc Kleine-Budde Cc: wg@grandegger.com, kernel@martin.sperl.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver Message-ID: <20200618085533.GA26093@mani> References: <20200610074442.10808-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 0611, Marc Kleine-Budde wrote: > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > Controller with MCP2517FD as the target controller version. This series is > > mostly inspired (or taken) from the previous iterations posted by Martin Sperl. > > I've trimmed down the parts which are not necessary for the initial version > > to ease review. Still the series is relatively huge but I hope to get some > > reviews (post -rcX ofc!). > > > > Link to the origial series posted by Martin: > > https://www.spinics.net/lists/devicetree/msg284462.html > > > > I've not changed the functionality much but done some considerable amount of > > cleanups and also preserved the authorship of Martin for all the patches he has > > posted earlier. This series has been tested on 96Boards RB3 platform by myself > > and Martin has tested the previous version on Rpi3 with external MCP2517FD > > controller. > > I initially started looking at Martin's driver and it was not using several > modern CAN driver infrastructures. I then posted some cleanup patches but Martin > was not working on the driver any more. Then I decided to rewrite the driver, > that is the one I'm hoping to mainline soon. > So how should we proceed from here? It is okay for me to work on adding some features and also fixing the issues you've reported so far. But I want to reach a consensus before moving forward. If you think that it makes sense to go with your set of patches, then I need an estimate on when you'll post the first revision. > Can you give it a try? > > https://github.com/marckleinebudde/linux/commits/v5.6-rpi/mcp25xxfd-20200607-41 > Sure thing. Will do. Thanks, Mani > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |