Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1199980ybt; Thu, 18 Jun 2020 03:02:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwL1R9LmDJQ63tM9/wuJxKGW8/NaKFXUhQ1lZ4w94QVT/NcG4WS8ZnkrhUf1VH+TkWB1PF6 X-Received: by 2002:aa7:c496:: with SMTP id m22mr3364162edq.187.1592474576693; Thu, 18 Jun 2020 03:02:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592474576; cv=none; d=google.com; s=arc-20160816; b=U/4TQQqLPfi/JTRofF0Bzw35zPjg1aHO2i6m/HSVUg74LE11+8+bd01HnK0m5uqpeB MpCtdWJHCBmS4xUvhpDLOT1BWxDKuJcH6qALYit/Alpwzddh8nyGaF+nKNtZ28RpJwyt sVX47GiiDMzbOJ9Sj4Qv37IpT3ZbD+k+G5CRTPvstSdhH5rrprh1upp+T2lgEUnVjmXx Ayx6a5nUbWBcXhwxx5rZ/nTnWJDQNGO9OfYlW5hDIIB5eU6R6oTB7bNr6JH7HnBu59XI W4ZAEq3OCSN//POv1XIYfS4SH6eDLkZtcj0fyd/5ZWwcMBmdvuhIuxQefglF8GtGXplm llcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=CIwJ9pSmIguG0cZaDRHb229MNN6cwd279ufMyNMWwGg=; b=VpSquNXbVwtTp5UmsGGt7JfrSCKdxs//flVuP7I+caka2ncNX4VblBOtsVlpHpSaH+ 0Tg1CGiESMiF7CTDtQRXmWcXpLd3BTUWqs94kCU4hlwIs7UlMKvH0wCCrROItsomnuPc 978ZTHUuPie0KvWYCUlRWWissHnDlDlCAy0Z+Nv/+edHKbFfN4guBRzqLJfhUCVKgisy XWohQP/MuFDucXcj2d42humRxvSmxucXew9u9HXMGh64NDny5tX+13LxNaiKdfN3njDw hMlcrH5HxovLZXUzJP72hmFdusU+y79nJxsyZLrlAcLnwil+Gwtvf3Zy3oy/hlgfy6J4 Mgog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e9si1486001eja.348.2020.06.18.03.02.34; Thu, 18 Jun 2020 03:02:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729134AbgFRJ2f (ORCPT + 99 others); Thu, 18 Jun 2020 05:28:35 -0400 Received: from foss.arm.com ([217.140.110.172]:46806 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728943AbgFRJ2e (ORCPT ); Thu, 18 Jun 2020 05:28:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C7EC1045; Thu, 18 Jun 2020 02:28:33 -0700 (PDT) Received: from [192.168.1.84] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 483DF3F6CF; Thu, 18 Jun 2020 02:28:32 -0700 (PDT) Subject: Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe To: Rob Herring Cc: Krzysztof Kozlowski , Tomeu Vizoso , David Airlie , Daniel Vetter , dri-devel , "linux-kernel@vger.kernel.org" , Alyssa Rosenzweig References: <20200527200544.7849-1-krzk@kernel.org> <20200527204334.GA15485@kevin> <20200617141547.GA30516@kozik-lap> From: Steven Price Message-ID: Date: Thu, 18 Jun 2020 10:28:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/06/2020 20:57, Rob Herring wrote: > On Wed, Jun 17, 2020 at 8:36 AM Steven Price wrote: >> >> On 17/06/2020 15:15, Krzysztof Kozlowski wrote: >>> On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote: >>>> Reviewed-by: Alyssa Rosenzweig >>>> >>>> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote: >>>>> There is no point to print deferred probe (and its failures to get >>>>> resources) as an error. Also there is no need to print regulator errors >>>>> twice. >>>>> >>>>> In case of multiple probe tries this would pollute the dmesg. >>>>> >>>>> Signed-off-by: Krzysztof Kozlowski >>>>> Reviewed-by: Steven Price >>>>> >>>>> --- >>>>> >>>>> Changes since v2: >>>>> 1. Rebase >>>>> 2. Add Steven's review >>>>> >>>>> Changes since v1: >>>>> 1. Remove second error message from calling panfrost_regulator_init() >>>>> --- >>>>> drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++---- >>>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>>>> >>> >>> Hi Rob, Tomeu and Steven, >>> >>> You're listed as maintainers for panfrost. Is anyone going to pick this >>> up? >> >> I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can >> pick it up if Rob/Tomeu are happy for me to do that. >> >>> Maybe I sent it to wrong mailing list or forgot about anything? >> >> No, there's actually a few Panfrost commits waiting, it was on my todo >> list to ask if Rob/Tomeu needed some help with merging patches. > > Please do, I haven't had the cycles for panfrost lately. > > Rob > Ok, this patch is pushed to drm-misc-next. I'll dig through my emails for the other patches which are pending and take a look at them too. Steve