Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1205838ybt; Thu, 18 Jun 2020 03:11:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzn/3a0Lp50X4LtmUvpYeZJTFC/sxfs/ApIV7cti4y3phcYmGi3xOUMMNoQjcS4uBYfsUSy X-Received: by 2002:a17:906:fac8:: with SMTP id lu8mr3137830ejb.432.1592475064018; Thu, 18 Jun 2020 03:11:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592475064; cv=none; d=google.com; s=arc-20160816; b=a0echqQUH1LF3M+LSyb0iuI+hbwfCrk/J0ZNcZTd+lDjn8V0Eo0wR3+5mk8hDi4B0s oFF+ngLrisycC4ZG7OgYeaLY26qypPsDbGtEwvjv5gld8hlBUfhDatvq32GoMFG2XRg6 feSy9K4uLE11bwQuCGdHlLcjAGPLM2p3o6ejcbeHUdYuryeOS3Pbk2KjyPLyDiQ+gGWh GptVa7BYaDdJFw20WTFUIXRuW37mX5ZqFu2oQ2fXlltL6rrU1DURGT1uyR7UkgpvoPt6 +intVup7N4HOO0kUAJbF1DwvShpJEX62j4roUN0s5lClVZcljb9EX0YmriH+4sYQuYCR kaXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=VD+Vzk+AXt6yH/qIMpkejO2MSs1qzB+GMbqxTZwpFlo=; b=rhI0hbA+rArNRmSEv49mF0k+Td1EMBQSw1yUfF+nsOX+eDShCuJywDpYvw2wLNziZD QKdPrbJYyHPXCExOF+Ot7NAQ0B1b3Gs9xcAR/b/aDuvbhYcGMqkIlWzqysXKJbEIsH4K s7kEddegtXS3CyyeKYNHZ7w0wh7oefwBChDHJtL5CVDhwPOWbbgSsbZbyhUY6Kso0vZc FOK26W7NewPN1lwgL+YnEq1e03UVGCIThlbNWJh8H0Gbg9y1hL1qQ5wTt7IhCAUIQb6w maVRsWMjvNDKVc3VsOFhcq423ggmSwEHgrhzD6iEyGUkQmhK+2+C350eZlOX2cpqe55Q 3lkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lx13si1524106ejb.196.2020.06.18.03.10.41; Thu, 18 Jun 2020 03:11:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728422AbgFRKEF (ORCPT + 99 others); Thu, 18 Jun 2020 06:04:05 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:46771 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728361AbgFRKEF (ORCPT ); Thu, 18 Jun 2020 06:04:05 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jlrOr-0002xe-89; Thu, 18 Jun 2020 10:04:01 +0000 From: Colin King To: Liviu Dudau , Brian Starkey , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/arm: fix unintentional integer overflow on left shift Date: Thu, 18 Jun 2020 11:04:00 +0100 Message-Id: <20200618100400.11464-1-colin.king@canonical.com> X-Mailer: git-send-email 2.27.0.rc0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Shifting the integer value 1 is evaluated using 32-bit arithmetic and then used in an expression that expects a long value leads to a potential integer overflow. Fix this by using the BIT macro to perform the shift to avoid the overflow. Addresses-Coverity: ("Unintentional integer overflow") Fixes: ad49f8602fe8 ("drm/arm: Add support for Mali Display Processors") Signed-off-by: Colin Ian King --- drivers/gpu/drm/arm/malidp_planes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index 37715cc6064e..ab45ac445045 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c @@ -928,7 +928,7 @@ int malidp_de_planes_init(struct drm_device *drm) const struct malidp_hw_regmap *map = &malidp->dev->hw->map; struct malidp_plane *plane = NULL; enum drm_plane_type plane_type; - unsigned long crtcs = 1 << drm->mode_config.num_crtc; + unsigned long crtcs = BIT(drm->mode_config.num_crtc); unsigned long flags = DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_90 | DRM_MODE_ROTATE_180 | DRM_MODE_ROTATE_270 | DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y; unsigned int blend_caps = BIT(DRM_MODE_BLEND_PIXEL_NONE) | -- 2.27.0.rc0