Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1283580ybt; Thu, 18 Jun 2020 05:11:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy47XLZapsRLEp6MJFWW54/6JQAL5vx6Idq06is4uSyhk7ehlcfvUyAf5AdpHtOoS8vq8J0 X-Received: by 2002:a17:906:7ad7:: with SMTP id k23mr3763793ejo.439.1592482317535; Thu, 18 Jun 2020 05:11:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592482317; cv=none; d=google.com; s=arc-20160816; b=PEp3aKTcYNKohgBxF8QcoXDOQfjUMi4J/dNH5cF6R5P7PWX3I1oj+breQs4e5TPvCx duD8scMELgWZa+vul1DIB+MSONtKTDqIPd+21cbxc83wsKUcV3N+wHZe4hZcqw335zto ADOcUBNerTazXeC3g16kbwK6bNn7Wpe/fC0m2KkS2JvTrpk7Gm+5kSWPTdVtcRIhQ6Hl ldYe9WeKrc/41Ijqt88BmZMHos0jfq0CeF3CPPn2reFpuxPofM8T56Q5qR2keSAL5/K5 DcwJQH8x4+2XtxX0PLKLX1pXS/PgSMbzot7HaGaMuAofu6l/mnw9kETqruvHhUzX5zfO p6Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KnZMcd7hAByohLFNqoZ+jn6S/xUHmJ274kiUVqsCRiY=; b=IqGC26Mr8qNRsGr3oofFFW/hTa+do8JKtXkiP8pVc8RoyiPuv3sQj3wKTkodymMt/F PY9bh2L/ZKusztNDb/YnWbeSyGlIXEEKDrZdyUB5ldGeu0rlXk8f21HgJUxQu9yOO4jq 6DXxqEo5HrTMpEVkLa5gEOCIfQjKQStDRB4R4mkQXgcFH+z8ouK1zHJKxr+4uuZZvLQw 8wpREyrhPl9y7I30mef78AV9epGIUJGstgyUUdsL8W/Z1lEQ9v318oIExqq0RaF9IR5t ndfN7gpPj/X5HQTgupTxl/01ZCCEfpjX6KripkHIi+QVPYqkCXJauNE/uxKna/tCPWSi tZbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i3r8xzak; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 36si1933869edp.290.2020.06.18.05.11.34; Thu, 18 Jun 2020 05:11:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=i3r8xzak; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728712AbgFRMG3 (ORCPT + 99 others); Thu, 18 Jun 2020 08:06:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727784AbgFRMGY (ORCPT ); Thu, 18 Jun 2020 08:06:24 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9774C0613ED for ; Thu, 18 Jun 2020 05:06:23 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id v14so2833595pgl.1 for ; Thu, 18 Jun 2020 05:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KnZMcd7hAByohLFNqoZ+jn6S/xUHmJ274kiUVqsCRiY=; b=i3r8xzakfwZ3uk+CMdQ56vr7b6YalR5xVqKnNsXOUACwqn6g/kFD9NV2DtKAsfwJaV dTBC6UOcltvDhwyOleA9nXDGIpHOG2RlCrdWU15Ljr1IGgxp9QnrdR1DY0w5foaTbGfH 2quSvqHaIzhOkFQBInGA1Qq04L+fJpUrRRnKhuk34E2+hhPa3RFn1/kFZfxUTtvqUWOq YSZIcjsh2KErBcDAtrH01Ak3g7V8H3xn3tabJBhESZWrFZJFu1qqF5y7Ar4pHQL8gTJ8 roE5u9XlqcQxRP2KBd75xfWgYdqYVZdKr+71OZxiKcjPxRF1BcFDndGlXizFJEmaxt1n UW4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KnZMcd7hAByohLFNqoZ+jn6S/xUHmJ274kiUVqsCRiY=; b=PIsqJwxw+i4diFdusuZr7rcma2y98tH4h18YsI5naG8HL8OkAjdUTJBZ25IRn6P1T7 SPlYk8VlejlWMe6hDFLTaT4Xf0UzL3SdU/jUjDRWOJ05DJAcGUoYADqnA8PyfeGqF5Pf 6JgluVKWPMDWYDS1PsEr5OJLk6qzcaEPftudTU7SJC0L7oFGWE1aH81lB004aVV8Ajas GoPrCCHpDBMfifZ+BpAB+Tw70QVu4mcZB1I9a02JhfnOXQd5e6D2TyhFJmSjYCFWMHYF cu6PRhQlRXqpZ0LUKqqHeBgxQ9FhALoNvIo5OvXBXvev9lwz7FfGGiStSDB3qGxG/Z+o jjoQ== X-Gm-Message-State: AOAM532caJED162n6eYiuWsIfwk26vNrX+7dS1iW1xQDclX22ZzOwqO/ UXNEtfzo3sy7ftXPSNrFArUO X-Received: by 2002:a63:1007:: with SMTP id f7mr3016539pgl.147.1592481983117; Thu, 18 Jun 2020 05:06:23 -0700 (PDT) Received: from mani ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id i22sm2780776pfo.92.2020.06.18.05.06.20 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jun 2020 05:06:22 -0700 (PDT) Date: Thu, 18 Jun 2020 17:36:15 +0530 From: Manivannan Sadhasivam To: Marc Kleine-Budde Cc: wg@grandegger.com, kernel@martin.sperl.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver Message-ID: <20200618120615.GA3949@mani> References: <20200610074442.10808-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 0611, Marc Kleine-Budde wrote: > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > Controller with MCP2517FD as the target controller version. This series is > > mostly inspired (or taken) from the previous iterations posted by Martin Sperl. > > I've trimmed down the parts which are not necessary for the initial version > > to ease review. Still the series is relatively huge but I hope to get some > > reviews (post -rcX ofc!). > > > > Link to the origial series posted by Martin: > > https://www.spinics.net/lists/devicetree/msg284462.html > > > > I've not changed the functionality much but done some considerable amount of > > cleanups and also preserved the authorship of Martin for all the patches he has > > posted earlier. This series has been tested on 96Boards RB3 platform by myself > > and Martin has tested the previous version on Rpi3 with external MCP2517FD > > controller. > > I initially started looking at Martin's driver and it was not using several > modern CAN driver infrastructures. I then posted some cleanup patches but Martin > was not working on the driver any more. Then I decided to rewrite the driver, > that is the one I'm hoping to mainline soon. > > Can you give it a try? > > https://github.com/marckleinebudde/linux/commits/v5.6-rpi/mcp25xxfd-20200607-41 > Tested this version on my board with MCP2518FD and it works fine. I'm okay with moving forward with your version and would like to contribute. Please let me know how we can move forward. Thanks, Mani > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |