Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1286747ybt; Thu, 18 Jun 2020 05:16:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxs8g/PENHkMT2WI3OUhRmDB5eXOd7bkml2A3+IHnLUEZl8/KYvNe4qF+m7ifxk4zVNUgtV X-Received: by 2002:a17:906:a398:: with SMTP id k24mr3564360ejz.220.1592482583412; Thu, 18 Jun 2020 05:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592482583; cv=none; d=google.com; s=arc-20160816; b=a+B9AhqvOmxVhYr/2lxqosBNuZFnyAksliJF/uSzWxTKaomEJ6fXlckFOaq218petu 7U/7C86N8DSPwDp9c0m9j9DpBDLrrkz2DzxPfV+tJrVPnT+ZAS7AHypx6bGEG0DVwl3h ksdwwZw2sOTzQCSM3KkHcZQ2oIiy1qaqCoF/O7KULhhurvglT30qPO4aNuVdyYWbov/e eKUJtTAmc0HSlHkMiYKOLHAWmS7jooPvymVqwOCJtfOIHrkALyeYf5AY6rMJfn8OTMKF S+RB5Pa7e2TP1SmxyTJpQQP9+bG6tPdG62YHrHXv9Xnl0idalBwPZeH7eKdFw5uZ0ek5 yyCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zlMHpKPW0q09W6RDM2ggzLUYctacuDuqAbHYFurGPzg=; b=JFSN7fr6qNG2OixrG+WOKutLz+aVtm7OrO+KI6YMoiveiLPjeDiCz63nQO8VKFqWyy nkkGL9AEvobhegj95yJ0Mz2Y8IRKUTph4cx0BJu/JLDfo7c48EvMSSdqzaMBFK9Dc5cB KXaWJQjgdGeM+VuWGGKm4w1vrDPIYnx6zRHZ9LA8aRW4tXm9eIVAL0E/pOf9WF4pcuUh Eb/tZ7FFVnk0NmlCg5jaSv/QLkemVtRp+pJXf9f6eR1Rpr0O6EaOy0h3eZjB0kykWBij 6UDrpHI8+KD5Ddni5ZVBsRl4/kpLX+OmoqtTvrQL5+Y8r1xchEEL/2eih6eKPeGNz0Pl uCeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MgTrurpY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t11si2022359edi.601.2020.06.18.05.15.52; Thu, 18 Jun 2020 05:16:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MgTrurpY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727877AbgFRMNq (ORCPT + 99 others); Thu, 18 Jun 2020 08:13:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:40066 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726912AbgFRMNm (ORCPT ); Thu, 18 Jun 2020 08:13:42 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D0F31207DD; Thu, 18 Jun 2020 12:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592482422; bh=zlMHpKPW0q09W6RDM2ggzLUYctacuDuqAbHYFurGPzg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MgTrurpY2WwRFZMiFOLuc/+EX73he9w5/j8XNdxcMhxek2dHNTznYTzwpPoDCAUkM 3WUYySfhviMyex2qyhsZgUM/Vu50MXK3YJnnuwryA2FLP4X2eAlASLvfXXEP4TOYQq U9KVJQcYYf1syoJnX5w9cJn4RYObOuhyjQB5cvws= Date: Thu, 18 Jun 2020 13:13:39 +0100 From: Mark Brown To: Daniel Baluta Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Kai Vehmanen , Pierre-Louis Bossart , Ranjani Sridharan , sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org Subject: Re: [PATCH AUTOSEL 5.7 055/388] ASoC: SOF: Do nothing when DSP PM callbacks are not set Message-ID: <20200618121339.GH5789@sirena.org.uk> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-55-sashal@kernel.org> <20200618110126.GC5789@sirena.org.uk> <1d1041f9-521b-98f5-a6ef-12d43615bc13@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y0Ed1hDcWxc3B7cn" Content-Disposition: inline In-Reply-To: <1d1041f9-521b-98f5-a6ef-12d43615bc13@nxp.com> X-Cookie: Androphobia: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --y0Ed1hDcWxc3B7cn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 18, 2020 at 02:44:18PM +0300, Daniel Baluta wrote: > Indeed can be seen as an optimization, but it does unexpected things which > can cause trouble > and weird behavior for people not familiar with the matter. > For example, as explained in the commit message if you only provide > System PM handler but not runtime PM handler, then the DSP will be resetted > even if this is not the intention. The user shouldn't be thinking about if the DSP is reset during runtime PM, or if it's being reset... --y0Ed1hDcWxc3B7cn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7rWnMACgkQJNaLcl1U h9CkHwf/fzvqyfr+cua8XR1XxSJiEGTyXJ/VvKSilf0hGJm5j4pkchTP+QMu+u84 NJ05+mKUW1R9f5iHvCFhu+DvcSnUqPwP5cNDwqNNG2LgiMVV7ncOdmfVAx0iez/9 LWr9pv2xR7OoeZUWBGButW0vR+Db7otynZ0g4KJUK32rQDdV7fDhd83v3PxZLZAT ihIb7y2cGeyXAXNqxLqCqPnuPRnC1dzYdMxT9J5OKH2kfahG8O1pAuu4XZtAE68l vFCQ7SgIqkq2HxAhen6J4rd+bTb0W9hpEL+/ltebF4Q1gw7nkruhZaEheiKrj6Ex hUY08U4sFWY1/kA0scUxNk1+iGvIRA== =wOoM -----END PGP SIGNATURE----- --y0Ed1hDcWxc3B7cn--