Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1312281ybt; Thu, 18 Jun 2020 05:55:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzL25bVwb9AGdGl5trLcAN2IGkYXqMP+EmXiqoJ8seCLImLDmZU3aTAAt4qtrsRs4HErF76 X-Received: by 2002:aa7:da8c:: with SMTP id q12mr3953481eds.385.1592484952908; Thu, 18 Jun 2020 05:55:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592484952; cv=none; d=google.com; s=arc-20160816; b=rr02LeyuJmc/B77CA7ptUtcJgMv8rsIwI9LaZFYbS9T5OZ95VNJSGnB2qzu7RCPDsa Kno5wJHLJTEb2xPilXNWkceHM1abbpGjAqvDGjbkPnOb3kiTu7fDVtbid2+vFtMb3mAv vINC6+TV5rcR7tTPgSq3evUkgu2rQjh9zLMlC24WmfaxYm93Bxms/oaW47bq0+zIPsYk niWtFX1u61tusDDwwjR1gntHvaotUtkfT4+5V2fbYfM64OnkPah7LjBdWE0mXH54KDIv lLltX6J9/d4fo7fDMG93zP1VlFLa2BHcsWHmcYvcVJzYfLy26nQcmsIdkg01lteV5jSs 8X2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CUwPsjBZ0Y6RYhhJECu3dA7XcS6hBp4lJzkJd2Rawh4=; b=Vrk2F3UsJ1ZBlR3QLeFSvL+gTX8isAhQfAyjSDCR3poi7+TjchqmddauGEA2vPfDwD 4NbdivIiJwnXPor/13ulhw4NPeRp/w/IIE0H8brTUi9scjilx3G+gfSu6TpqZFyMFrDp 6oyHhH1Azusb5lUSqAw5BuuN/ICYMnvgiIP+p/1XE2PtLw+OqEvL1oGU1aYqUQGMEmZN Gfvvg8NBvr/uYLFqowZH6c5K+llOg+TqTnsFZ5rAoyinjLH/z/SO5JIE+9VYMhJjwjlW L/XA/FTJUk3yjgBsgNp30GRG1Zliurw4O0a1QvO+O2NDvbMS6JkQlAYN5N74x5r99AuN /mdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vLtp7mqb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r2si1846927edp.105.2020.06.18.05.55.30; Thu, 18 Jun 2020 05:55:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vLtp7mqb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730072AbgFRMwH (ORCPT + 99 others); Thu, 18 Jun 2020 08:52:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730020AbgFRMwD (ORCPT ); Thu, 18 Jun 2020 08:52:03 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E780C06174E for ; Thu, 18 Jun 2020 05:52:03 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id v11so2868188pgb.6 for ; Thu, 18 Jun 2020 05:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CUwPsjBZ0Y6RYhhJECu3dA7XcS6hBp4lJzkJd2Rawh4=; b=vLtp7mqbtO8BRs7ABDVJGV/NZ8iMxV9IswHlF/sFIAT2zNejnRm3FuIxAxltbzEmR6 2s/CrJMSvxbFlOcWCiOiiitE+lObTcwcUCJ9M8x6lUFOqrhYyphJB3lPjyVqAbbnlMyD 0s3Ro+IWw0MmrnNtIy7bKxGR0nWZHif7smTMWyb7nSUCLhuhleLInR00SiAmuuuJDCkH hyZ71ufi4WNVM7JWuHH4JAEDUIdds8nV1Q9+E3ZffRO1aOmH5O6Wruc5C3xl8/HeFrW5 T9/O4s8CLvb3gSHaB1+rhMTVrKc2tV9sm4CyKIByUQpF8I+fvM1Z2JWNiIsNM1HQHVmi 4xjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CUwPsjBZ0Y6RYhhJECu3dA7XcS6hBp4lJzkJd2Rawh4=; b=Bk1eL3hh41po4hKUd0yrQ/xb9mE+a4ctSWTmZrcdwQ8lL6ox3uyv89jdvjCQkfV+ax 2O7KM8+D+dZEEoPzyj5c7yd8alVEYUUbgCTQsEBWDPcjuCI+60dCAFPLZdxxc6OSG0hL 1YhQGhtewttBGbSgr8ngBPtQ60AYYznVSM/R2bpZnM/oYe6ouoy8aabILHp8moe9ZTrl BWbxH0KPzy2t73ZNUYjmyWeVOVsnP5MphRKdLSLYtip8PAYZOpuFodoVa/SDaCQRsCZN zaOA2x//7ZDpI0aenK04/TxjbYyeXoozRIjfWaw/6FCypdRvox4ZZFmbdu6GM7HAXCId djKA== X-Gm-Message-State: AOAM531vMLPOyAxvWUwF9yBkmkQiDifTzMfua5g3xycRCVOziy4vk32F Q3CQSjpqKHZGlKtVJvXgYWkMu7BKjA8= X-Received: by 2002:aa7:8a4c:: with SMTP id n12mr3472270pfa.326.1592484721658; Thu, 18 Jun 2020 05:52:01 -0700 (PDT) Received: from daehojeong1.seo.corp.google.com ([2401:fa00:d:1:b8f4:bbde:37ba:20bd]) by smtp.gmail.com with ESMTPSA id i20sm3029575pfd.81.2020.06.18.05.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 05:52:01 -0700 (PDT) From: Daeho Jeong To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Daeho Jeong , Chao Yu Subject: [PATCH v4] f2fs: add F2FS_IOC_SEC_TRIM_FILE ioctl Date: Thu, 18 Jun 2020 21:51:52 +0900 Message-Id: <20200618125152.84099-1-daeho43@gmail.com> X-Mailer: git-send-email 2.27.0.290.gba653c62da-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daeho Jeong Added a new ioctl to send discard commands or/and zero out to selected data area of a regular file for security reason. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu --- fs/f2fs/f2fs.h | 15 +++++ fs/f2fs/file.c | 179 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 194 insertions(+) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index c812fb8e2d9c..3763d9e03ca8 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -434,6 +434,8 @@ static inline bool __has_cursum_space(struct f2fs_journal *journal, _IOR(F2FS_IOCTL_MAGIC, 18, __u64) #define F2FS_IOC_RESERVE_COMPRESS_BLOCKS \ _IOR(F2FS_IOCTL_MAGIC, 19, __u64) +#define F2FS_IOC_SEC_TRIM_FILE _IOW(F2FS_IOCTL_MAGIC, 20, \ + struct f2fs_sectrim_range) #define F2FS_IOC_GET_VOLUME_NAME FS_IOC_GETFSLABEL #define F2FS_IOC_SET_VOLUME_NAME FS_IOC_SETFSLABEL @@ -453,6 +455,13 @@ static inline bool __has_cursum_space(struct f2fs_journal *journal, #define F2FS_GOING_DOWN_METAFLUSH 0x3 /* going down with meta flush */ #define F2FS_GOING_DOWN_NEED_FSCK 0x4 /* going down to trigger fsck */ +/* + * Flags used by F2FS_IOC_SEC_TRIM_FILE + */ +#define F2FS_TRIM_FILE_DISCARD 0x1 /* send discard command */ +#define F2FS_TRIM_FILE_ZEROOUT 0x2 /* zero out */ +#define F2FS_TRIM_FILE_MASK 0x3 + #if defined(__KERNEL__) && defined(CONFIG_COMPAT) /* * ioctl commands in 32 bit emulation @@ -488,6 +497,12 @@ struct f2fs_flush_device { u32 segments; /* # of segments to flush */ }; +struct f2fs_sectrim_range { + u64 start; + u64 len; + u64 flags; +}; + /* for inline stuff */ #define DEF_INLINE_RESERVED_SIZE 1 static inline int get_extra_isize(struct inode *inode); diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index dfa1ac2d751a..ef7ea4fcfa61 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -21,6 +21,7 @@ #include #include #include +#include #include "f2fs.h" #include "node.h" @@ -3749,6 +3750,181 @@ static int f2fs_reserve_compress_blocks(struct file *filp, unsigned long arg) return ret; } +static int f2fs_secure_erase(struct block_device *bdev, block_t block, + block_t len, u32 flags) +{ + struct request_queue *q = bdev_get_queue(bdev); + sector_t sector = SECTOR_FROM_BLOCK(block); + sector_t nr_sects = SECTOR_FROM_BLOCK(len); + int ret = 0; + + if (!q) + return -ENXIO; + + if (flags & F2FS_TRIM_FILE_DISCARD) + ret = blkdev_issue_discard(bdev, sector, nr_sects, GFP_NOFS, + blk_queue_secure_erase(q) ? + BLKDEV_DISCARD_SECURE : 0); + + if (!ret && (flags & F2FS_TRIM_FILE_ZEROOUT)) + ret = blkdev_issue_zeroout(bdev, sector, nr_sects, GFP_NOFS, 0); + + return ret; +} + +static int f2fs_sec_trim_file(struct file *filp, unsigned long arg) +{ + struct inode *inode = file_inode(filp); + struct f2fs_sb_info *sbi = F2FS_I_SB(inode); + struct address_space *mapping = inode->i_mapping; + struct block_device *prev_bdev = NULL; + struct f2fs_sectrim_range range; + pgoff_t index, pg_end; + block_t prev_block = 0, len = 0; + u64 end_addr; + bool to_end; + int ret = 0; + + if (!(filp->f_mode & FMODE_WRITE)) + return -EBADF; + + if (copy_from_user(&range, (struct f2fs_sectrim_range __user *)arg, + sizeof(range))) + return -EFAULT; + + if (range.flags == 0 || (range.flags & ~F2FS_TRIM_FILE_MASK) || + !S_ISREG(inode->i_mode)) + return -EINVAL; + + if ((range.flags & F2FS_TRIM_FILE_DISCARD) && + !f2fs_hw_support_discard(sbi)) + return -EOPNOTSUPP; + + file_start_write(filp); + inode_lock(inode); + + if (f2fs_is_atomic_file(inode) || f2fs_compressed_file(inode)) { + ret = -EINVAL; + goto err; + } + + if (inode->i_size == 0) + goto err; + + end_addr = range.start + range.len; + if (end_addr > inode->i_size) { + ret = -EINVAL; + goto err; + } + + to_end = (end_addr == inode->i_size); + if (!IS_ALIGNED(range.start, F2FS_BLKSIZE) || + (!to_end && !IS_ALIGNED(end_addr, F2FS_BLKSIZE))) { + ret = -EINVAL; + goto err; + } + + index = F2FS_BYTES_TO_BLK(range.start); + pg_end = DIV_ROUND_UP(end_addr, F2FS_BLKSIZE); + + ret = f2fs_convert_inline_inode(inode); + if (ret) + goto err; + + down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); + down_write(&F2FS_I(inode)->i_mmap_sem); + + ret = filemap_write_and_wait_range(mapping, range.start, end_addr - 1); + if (ret) + goto out; + + truncate_inode_pages_range(mapping, range.start, + to_end ? -1 : end_addr - 1); + + while (index < pg_end) { + struct dnode_of_data dn; + pgoff_t end_offset, count; + int i; + + set_new_dnode(&dn, inode, NULL, NULL, 0); + ret = f2fs_get_dnode_of_data(&dn, index, LOOKUP_NODE); + if (ret) { + if (ret == -ENOENT) { + index = f2fs_get_next_page_offset(&dn, index); + continue; + } + goto out; + } + + end_offset = ADDRS_PER_PAGE(dn.node_page, inode); + count = min(end_offset - dn.ofs_in_node, pg_end - index); + for (i = 0; i < count; i++, dn.ofs_in_node++) { + struct block_device *cur_bdev; + block_t blkaddr = f2fs_data_blkaddr(&dn); + + if (!__is_valid_data_blkaddr(blkaddr)) + continue; + + if (!f2fs_is_valid_blkaddr(sbi, blkaddr, + DATA_GENERIC_ENHANCE)) { + ret = -EFSCORRUPTED; + f2fs_put_dnode(&dn); + goto out; + } + + cur_bdev = f2fs_target_device(sbi, blkaddr, NULL); + if (f2fs_is_multi_device(sbi)) { + int di = f2fs_target_device_index(sbi, blkaddr); + + blkaddr -= FDEV(di).start_blk; + } + + if (len) { + if (prev_bdev == cur_bdev && + blkaddr == prev_block + len) { + len++; + } else { + ret = f2fs_secure_erase(prev_bdev, + prev_block, len, range.flags); + if (ret) { + f2fs_put_dnode(&dn); + goto out; + } + + len = 0; + } + } + + if (!len) { + prev_bdev = cur_bdev; + prev_block = blkaddr; + len = 1; + } + } + + f2fs_put_dnode(&dn); + index += count; + + if (fatal_signal_pending(current)) { + ret = -EINTR; + goto out; + } + cond_resched(); + } + + if (len) + ret = f2fs_secure_erase(prev_bdev, prev_block, len, + range.flags); +out: + up_write(&F2FS_I(inode)->i_mmap_sem); + up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); +err: + inode_unlock(inode); + file_end_write(filp); + + return ret; +} + long f2fs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { if (unlikely(f2fs_cp_error(F2FS_I_SB(file_inode(filp))))) @@ -3835,6 +4011,8 @@ long f2fs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) return f2fs_release_compress_blocks(filp, arg); case F2FS_IOC_RESERVE_COMPRESS_BLOCKS: return f2fs_reserve_compress_blocks(filp, arg); + case F2FS_IOC_SEC_TRIM_FILE: + return f2fs_sec_trim_file(filp, arg); default: return -ENOTTY; } @@ -4004,6 +4182,7 @@ long f2fs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) case F2FS_IOC_GET_COMPRESS_BLOCKS: case F2FS_IOC_RELEASE_COMPRESS_BLOCKS: case F2FS_IOC_RESERVE_COMPRESS_BLOCKS: + case F2FS_IOC_SEC_TRIM_FILE: break; default: return -ENOIOCTLCMD; -- 2.27.0.290.gba653c62da-goog