Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: c4aarDERm/AHYz4XmbDck8mtVoDgoCk88l9yoXlq1vfB8fFDue9+NvhsvKxdrtqTYWXxviZfWW
 p6WMW/v7adLw==
IronPort-SDR: jk6Z/xghMixVveuzV47x56u8F2cumT/HPXJZLEnYZ6tSN6mZMWxSmnDjo/hzQoCQxld7bbEMsj
 m7YAfMudqZ0Q==
Date:   Thu, 18 Jun 2020 07:13:49 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Gaurav Singh <gaurav1086@gmail.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
        "open list:PERFORMANCE EVENTS SUBSYSTEM" 
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [perf] sort : Fix null pointer dereference in
 _hist_entry__sym_snprintf
Message-ID: <20200618141349.GA793265@tassilo.jf.intel.com>
References: <20200618003040.26360-1-gaurav1086@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200618003040.26360-1-gaurav1086@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index d42339df20f8..25c7c96893f6 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -294,6 +294,9 @@ static int _hist_entry__sym_snprintf(struct map_symbol *ms,
>  				     u64 ip, char level, char *bf, size_t size,
>  				     unsigned int width)
>  {
> +	if (!ms) 
> +		return 0;
> +
>  	struct symbol *sym = ms->sym;
>  	struct map *map = ms->map;
>  	size_t ret = 0;

This should have given warnings because Linux and perf coding style
forbids fixed statement/declarations.

Also what's the backtrace where it is NULL? Perhaps better to fix it in
the caller.

-Andi