Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wkAlW/CYAGF3U2lB9x6rrrvNWgNYq0CDxUW0xdbaVIYbx+M46HQPaccLcjO9XeebIkTxNT66xI
 okxgpTCWrmKczFm/ejwqYfKtFOIWfIlGbP6PB6g9cdRO2ZBsurpGc8iiftg4swCCbCHq2Tovoh
 IqYDzN/gv2q7oRccx/luA2zz2K74A59BPgWXdm7quQoXwzKDK7Js3YdOE+UNv4nZw+wP4b3TEr
 O1g7GCsKll83c0njc8gGldTG6BtwguHvb9uX6Jg4jRxh7s5kqvCLIy5/ec0LFjQvA7+jVz7tJC
 /Es=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Niklas Cassel <Niklas.Cassel@wdc.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] nvmet: remove workarounds for gcc bug wrt unnamed
 fields in initializers
Thread-Topic: [PATCH 2/2] nvmet: remove workarounds for gcc bug wrt unnamed
 fields in initializers
Thread-Index: AQHWRX1ZyGByOih9fUSrbaAjQMq7Ig==
Date:   Thu, 18 Jun 2020 15:23:21 +0000
Message-ID: <BYAPR04MB49657026BADC613CA83CB896869B0@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20200618143241.1056800-1-niklas.cassel@wdc.com>
 <20200618143241.1056800-2-niklas.cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b6de368-fbe5-4e59-d55e-08d8139b8922
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 15:23:21.3285
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OtjSB1YIcqpHDAYyk2BPSWB0y8UJ+fR+iLKRxTUw5drAbNNN8Pdq5vBP5wWmDzxT/+SZa2Zr2o/E5hGgAYFffo994cZg3MojOtK/9gOhXrE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6552
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/18/20 7:32 AM, Niklas Cassel wrote:=0A=
>   drivers/nvme/target/rdma.c | 23 ++++++++++++-----------=0A=
>   1 file changed, 12 insertions(+), 11 deletions(-)=0A=
> =0A=
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c=0A=
> index 6731e0349480..85c6ff0b0e44 100644=0A=
> --- a/drivers/nvme/target/rdma.c=0A=
> +++ b/drivers/nvme/target/rdma.c=0A=
> @@ -1535,19 +1535,20 @@ static int nvmet_rdma_cm_accept(struct rdma_cm_id=
 *cm_id,=0A=
>   		struct nvmet_rdma_queue *queue,=0A=
>   		struct rdma_conn_param *p)=0A=
>   {=0A=
> -	struct rdma_conn_param  param =3D { };=0A=
> -	struct nvme_rdma_cm_rep priv =3D { };=0A=
> +	struct rdma_conn_param  param =3D {=0A=
> +		.rnr_retry_count =3D 7,=0A=
> +		.flow_control =3D 1,=0A=
> +		.initiator_depth =3D min_t(u8, p->initiator_depth,=0A=
> +			queue->dev->device->attrs.max_qp_init_rd_atom),=0A=
> +		.private_data =3D &priv,=0A=
> +		.private_data_len =3D sizeof(priv),=0A=
> +	};=0A=
> +	struct nvme_rdma_cm_rep priv =3D {=0A=
> +		.recfmt =3D cpu_to_le16(NVME_RDMA_CM_FMT_1_0),=0A=
> +		.crqsize =3D cpu_to_le16(queue->recv_queue_size),=0A=
> +	};=0A=
>   	int ret =3D -ENOMEM;=0A=
>   =0A=
> -	param.rnr_retry_count =3D 7;=0A=
> -	param.flow_control =3D 1;=0A=
> -	param.initiator_depth =3D min_t(u8, p->initiator_depth,=0A=
> -		queue->dev->device->attrs.max_qp_init_rd_atom);=0A=
> -	param.private_data =3D &priv;=0A=
> -	param.private_data_len =3D sizeof(priv);=0A=
> -	priv.recfmt =3D cpu_to_le16(NVME_RDMA_CM_FMT_1_0);=0A=
> -	priv.crqsize =3D cpu_to_le16(queue->recv_queue_size);=0A=
> -=0A=
>   	ret =3D rdma_accept(cm_id, &param);=0A=
>   	if (ret)=0A=
>   		pr_err("rdma_accept failed (error code =3D %d)\n", ret);=0A=
> -- 2.26.2=0A=
=0A=
What is the issue with existing code that we need this patch for ?=0A=