Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1443384ybt; Thu, 18 Jun 2020 08:47:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4E9tJ4Q1/pi792+uwUxwGTbMqFH6xDxOJqIYJUTvL2XJjvMO3oxsDTAWdT9leAcoRReJx X-Received: by 2002:a50:a1e7:: with SMTP id 94mr4545084edk.165.1592495269522; Thu, 18 Jun 2020 08:47:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592495269; cv=none; d=google.com; s=arc-20160816; b=MgCqeNOOI2Et/AvdEOPXsymARFjZ5vm7EfNEwa8V0o3bIt9M2/KpsceHR2ZgblHjDr Ddb8WECwmw5cwKsCett2m3nwH303BR6Pv+2QGOURLRQUu+npXtMu+bkXYa8i5J2FkCbm 7uqPksAdTN7xbVFRT88074qHBKIOidAy57P5zBaqk5g4b0P475G6QC8+UMVTx+LC8HG8 5/D+U8KS+OcOfiNCqPbKV6n4gt6qbxYK+tQC2jhPVrHv77ernbUUZVmPDACUAM9rlcZC k8ZQlPtY74Fx7wKqV8+rdG/dtXjMu4yVej9XADc2CL8/50GpqIKSGdCp9ukS0b1BwLeu BVHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=F6Rg+f35w0pLQB9V9aLOSsaBariUhNumLWf2TXytslQ=; b=XTxjriRHIupLQb/KV00+ZCMYpQhejBStBylGCe3Nr4dKJpAHtlyZUU/0f92O8JtXy6 EdG1zmiQzqWrh55BT13shehDVdU5EqpuwRdqQqXXb3bz7KsLQhJXIMMLS44sVYOSBaAC n2mHhgsYHretM+n+J8tsumqn3yZ/5FThZy7tfpY231gvvg10K5bKFVZ0V2KG0nD5aLdN zISmx27noCf5Rzzc+eWA0I2K1yLCK5RCARhiHwasABAIpsXqjh7Lp7esVZ7kYQUD7z/H gzVQMTH0AU72MD345TdtvuJO71GG1yboxgghwxDj9RtLEd0Mun905Y+sK3DinLri+hY/ Nh/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XKsYIr30; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si2086498ejv.109.2020.06.18.08.47.27; Thu, 18 Jun 2020 08:47:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XKsYIr30; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731513AbgFRPo5 (ORCPT + 99 others); Thu, 18 Jun 2020 11:44:57 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:24595 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728414AbgFRPo4 (ORCPT ); Thu, 18 Jun 2020 11:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592495095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F6Rg+f35w0pLQB9V9aLOSsaBariUhNumLWf2TXytslQ=; b=XKsYIr30IBQ9rTEMGIbxjzEGFBAmCixZvCDgJTmwabAhkcH5lroeewCPGFH5na5DtqFe2v uVnZhfXR1W9lYGDRzpIXgwODLx0UirJAyakBJMmFcWhSrlTvlVPokXI7sG5xA3XyysRIxp w7oBp53ysxucBPqU1gmMp+S6RkU/qDw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-453-PzndCp1QO56aV3iCXybqhw-1; Thu, 18 Jun 2020 11:44:51 -0400 X-MC-Unique: PzndCp1QO56aV3iCXybqhw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0C1E18585A1; Thu, 18 Jun 2020 15:44:49 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD81B71660; Thu, 18 Jun 2020 15:44:45 +0000 (UTC) Date: Thu, 18 Jun 2020 11:44:45 -0400 From: Mike Snitzer To: JeongHyeon Lee Cc: agk@redhat.com, dm-devel@redhat.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: New mode DM-Verity error handling Message-ID: <20200618154444.GB18007@redhat.com> References: <98eac3fc-c399-625d-5730-29853b3a0771@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98eac3fc-c399-625d-5730-29853b3a0771@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18 2020 at 2:56am -0400, JeongHyeon Lee wrote: > Hello, Dear devcice-mapper maintainers. > > I'm JeongHyeon Lee, work in Samsung. I'm chage of DM-Verity feature with > Mr. sunwook eom. > I have a patch or suggestion about DM-Verity error handling. > > Our device (smart phone) need DM-Verity feature. So I hope there is new > mode DM-Verity error handling. > This new mode concept is When detect corrupted block, will be go to panic. > > Because our team policy is found device DM-Verity error, device will go > panic. > And then analyze what kind of device fault (crash UFS, IO error, DRAM > bit flip etc) > > In addition to the smart phone, I would like to have an option that > users or administrators can use accordingly. > There are patch contents in the attachment. I would really appreciate it > if you could check it. > > I will look forward to hearing from yours. > Thank you :) > I do not accept that panicing the system because of verity failure is reasonable. In fact, even rebooting (via DM_VERITY_MODE_RESTART) looks very wrong. The device should be put in a failed state and left for admin recovery. Mike