Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1488733ybt; Thu, 18 Jun 2020 09:50:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLQzJtCtr5AWvzI8r1fak0A2uY86LiGDCgZHj/xA2NT/Sbd/ttp5ZzJbEazHZhpTz+9CHA X-Received: by 2002:a50:a694:: with SMTP id e20mr4793402edc.144.1592499009000; Thu, 18 Jun 2020 09:50:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592499008; cv=none; d=google.com; s=arc-20160816; b=jWpiRZo2hCY53MkLvchd4HYv87Q9FCK/mLwAziR+zTCF6RXkuNoUu/aDmMxmfxhUgH Kys/WorrAhKhX2rSZ0w/N6VTk1OLpQ9UIsQoXFcj4PZVGgyhKIeW8e+uGrmur09moudM 6uo9Y24PFNSHzDL8104k8vyC0HYY5CMTsFmIw4NZrLhUpQBmhgaQu3U2zJ0rDEmrjqjA ZNE3w84HBB2OGGqemSGIjm3hSjGL/BciQ13DKoUjMy25NEOWdxoO+le+Mk1JI5XmV+jC 93ozctmIUJviBnzKn+ocfXVM9c3IvpmVxWYm8i2EeyZtrCja+Ii/6kQNdP3953ZwXNcm rXUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=3WW/dqLaXphe0ku4ze5+NQui8jf6wJl7JKjs66XPqjc=; b=tR+Y8IZWcvGe0BF0gk+2ryZeuUZhSGJuwept/9MJSWeT9RpocKIHRDzIF/wWSlDty5 0ey9vhKaPfGlDdOiqQNn4DYO29VYCuyzsuuCv6UksVhqHEYbL0nvepbvFxjIOnOd63w6 jGB1uVXXesxeVfiCmHX4ahM1UVhD9NNjXYHCMnkslXHvHmBotv4q2/6tgU4JQjkH63Rq ZKjO24aM4FO4EB+TmgxL3ZZAXrgp9T9KpYYHWDHxtGISTLdsSL5fGpcXzRpJ5trIOmsW MoyDhFU2Uj//zeVUDfI0QvM898yhLH04gjGnFtVa2GW7c5iyw9c7x9j42+gmRvseENel jToA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q25si2195378ejn.347.2020.06.18.09.49.44; Thu, 18 Jun 2020 09:50:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732045AbgFRQr4 (ORCPT + 99 others); Thu, 18 Jun 2020 12:47:56 -0400 Received: from mga07.intel.com ([134.134.136.100]:20430 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731946AbgFRQrz (ORCPT ); Thu, 18 Jun 2020 12:47:55 -0400 IronPort-SDR: qmfa/nKnlduU9itOP68fs0qquvNVkvARZxZ2jD1My+K9sZvBib93O80F2KIgOJBGAOqXc6nT/s r8mxmhKpcKjA== X-IronPort-AV: E=McAfee;i="6000,8403,9656"; a="207886167" X-IronPort-AV: E=Sophos;i="5.75,251,1589266800"; d="scan'208";a="207886167" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2020 09:47:54 -0700 IronPort-SDR: 8oswUOEDkOkLh7BDI3SHoBHc35hsaN7g3ykAsrKXx58oKyZcHcw5gppjXAXwPoJhE8PipcwaXK qDqDHUxOgpjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,251,1589266800"; d="scan'208";a="477309441" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 18 Jun 2020 09:47:52 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id AFC03130; Thu, 18 Jun 2020 19:47:51 +0300 (EEST) From: Andy Shevchenko To: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Cc: Andy Shevchenko , Thomas Bogendoerfer Subject: [PATCH v1 1/6] mips: Return proper error code from console ->setup() hook Date: Thu, 18 Jun 2020 19:47:46 +0300 Message-Id: <20200618164751.56828-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200618164751.56828-1-andriy.shevchenko@linux.intel.com> References: <20200618164751.56828-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For unifying console ->setup() handling, which is pure documented, return error code, rather than non-zero arbitrary number. Signed-off-by: Andy Shevchenko Cc: Thomas Bogendoerfer --- arch/mips/fw/arc/arc_con.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/mips/fw/arc/arc_con.c b/arch/mips/fw/arc/arc_con.c index 365e3913231e..7fdce236b298 100644 --- a/arch/mips/fw/arc/arc_con.c +++ b/arch/mips/fw/arc/arc_con.c @@ -28,7 +28,9 @@ static void prom_console_write(struct console *co, const char *s, static int prom_console_setup(struct console *co, char *options) { - return !(prom_flags & PROM_FLAG_USE_AS_CONSOLE); + if (prom_flags & PROM_FLAG_USE_AS_CONSOLE) + return 0; + return -ENODEV; } static struct console arc_cons = { -- 2.27.0