Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1505219ybt; Thu, 18 Jun 2020 10:12:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFz11j6Bzdg4ySa4uLddQhn/isieVxl6gHzdMUSxyI0t21TmtB4O0KtZgm7CeauvTgpRVm X-Received: by 2002:a17:906:b7cd:: with SMTP id fy13mr4683961ejb.443.1592500353126; Thu, 18 Jun 2020 10:12:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592500353; cv=none; d=google.com; s=arc-20160816; b=vBrTgn7b2mgBxokXiXCN67ilgYWYOKUn/luOvEj9vXr8Qn+th+BntQzL/ruFp+lfWC PGNR+d8t5jILmdbkIuSUplPcVM57bYkb+nTBNO3z5Lq7Z0EDG9MXJZ6Um2DCo7STELkA cIheTiNy242a6iWr9WtLXPJL0sZ2Wfx4ZcN0FGvUX7Ryl+yiHOsHFER6O9ARruZzKjUC ZEPGxtjgTeSa3V9cjsFJa4SnMGOGEkm6HWNxW3iIj0piAqkFmsNCGrv03Q7RdUffm5DY DitlCxCMIrhDUC8ENtB0JBePYt0trSKxMDm0DT4ojOPW70w/q7LPqg14t1yLzcqRkphg mkGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=EyHPYI/UjAp3H72S5spcJb48+H24FYKREDj4k4PySN8=; b=VfHZiSIYaOOKxig6aScol1ZxiUilVMbXCUPCDgcV1CcAwJQzFG0YhQPzqzH8IRfrK7 /iJtqI953DqD/YbTArVRjtYkEB38g6hssuYa5mmaiW9+urVI5nInnhZScPB6zceLlyzr Gg2G+QKR/0Ce/TK9s4E1rWVp8SJGWkNFPIBZ32PF/+wFtYyRC0enZj6d5R4xHu/AsH7O eiH4/JuU/yXDtiJJpg1n9hQ+IUTqfvyP0obJGLNl4T3JfSkMM6A7bevmkB3M85oJBdhv JZ0rzoGNGnE965q9n6FzCBe9ZYN0uYBB9hpfIYWinH4SjYshKbO7v0J8XpEyyI6Phu93 b8Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AOazMu6K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i8si2096249ejz.15.2020.06.18.10.12.08; Thu, 18 Jun 2020 10:12:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AOazMu6K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728865AbgFRRKE (ORCPT + 99 others); Thu, 18 Jun 2020 13:10:04 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:56660 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727822AbgFRRKD (ORCPT ); Thu, 18 Jun 2020 13:10:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592500202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EyHPYI/UjAp3H72S5spcJb48+H24FYKREDj4k4PySN8=; b=AOazMu6Kmu3WOrgQ/haewEV730YZT23PJf3F53pwj0DB86svNQr6WVw1Mex4B2PaTuwdec uVBap9S7a5RuGGEDGinFRUbiAwtD6aLW3cy2GINV7Tz3yLSH2aKwdh+CxD2VLFuNGq+yo4 J9dJ6+YG0ux8xeqc9j7W86SPK1Mq8iI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-205-xiDt_yXBOaCnju_C80WpYw-1; Thu, 18 Jun 2020 13:10:00 -0400 X-MC-Unique: xiDt_yXBOaCnju_C80WpYw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C7CE107ACCD; Thu, 18 Jun 2020 17:09:59 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 65EEB5D9E5; Thu, 18 Jun 2020 17:09:53 +0000 (UTC) Date: Thu, 18 Jun 2020 13:09:52 -0400 From: Mike Snitzer To: Sami Tolvanen Cc: JeongHyeon Lee , dm-devel@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, agk@redhat.com, corbet@lwn.net Subject: Re: New mode DM-Verity error handling Message-ID: <20200618170952.GA18057@redhat.com> References: <98eac3fc-c399-625d-5730-29853b3a0771@samsung.com> <20200618154444.GB18007@redhat.com> <20200618165006.GA103290@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618165006.GA103290@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18 2020 at 12:50pm -0400, Sami Tolvanen wrote: > On Thu, Jun 18, 2020 at 11:44:45AM -0400, Mike Snitzer wrote: > > I do not accept that panicing the system because of verity failure is > > reasonable. > > > > In fact, even rebooting (via DM_VERITY_MODE_RESTART) looks very wrong. > > > > The device should be put in a failed state and left for admin recovery. > > That's exactly how the restart mode works on some Android devices. The > bootloader sees the verification error and puts the device in recovery > mode. Using the restart mode on systems without firmware support won't > make sense, obviously. OK, so I need further justification from Samsung why they are asking for this panic mode. Thanks, Mike