Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1643921ybt; Thu, 18 Jun 2020 13:42:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxYFsDyBWjaCUXcXlmsWKpvdZk89LFQAz/iVuud6vZLwmkUE0cQqvs8vcLf/lG1a0kzJuC X-Received: by 2002:aa7:d054:: with SMTP id n20mr55474edo.344.1592512968855; Thu, 18 Jun 2020 13:42:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592512968; cv=none; d=google.com; s=arc-20160816; b=yfQiTqceJAEWkLn5laEqfyggZK4IjuiI6qtdLlOLQY5qeZcy9nCMrLSeonAbSNtqj2 I2HG6rM3TkHrgo1HJhh/cL4vz01YzHvkCB9VSf0klSwZUcpsJZsspt2XbuenlZOZXaTn 6MuF/uUR3/oBAFSHZQCwzyeriZtclikOSsrOUt/lWtUS38N0hKVlUxE6WPMGCpyLZbrS iebceaaGzLRuIUWyHdXE3WXMEsmSWmITMTBwEvrAEnYuVzAeCAphfTWdhdM1yl928Ox7 vQbWkaQciDlZQNPu94ETyiJ7DxqwDiAkiQb5NLFZivj8tIJqj4gjlD0naXFZcdUR+ET2 9XeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=gxk0mpNa0zDp1a6ZbGOjifp1sPgDInqSNRsdHtC1Hro=; b=d/7ERkdttPb8FMAhvizyT83PUazy2fZjKIj3utyVtS8axuykcaYz881FiA9ZBzHOLo vWfFHfIl9m4l73eomI+22ilnVpDI6RjmeRhtsNrk6KxcEHwdxGabXgDzfxVk3/JDBxCi 7N6RGVOXxBYxx5Zv3saRyp/vtlbYX3R3H2DnkF18UuOyDv6UQK2cNLXivQFvcV3Z1INy w0KjPHTq48fsFox2Yw8faIckzvu1B/ZkKcx/2EEl8kSjHxwRyZLH0IeLiMUOmodcrnox xGEOtAfC+tw5/8hL59QUGb1zh5HD3r3AWA8lvK48DZk3fTVbEBqDenQczxBGZYnw3/+f RHAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=eutxv2Pi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x25si2691488ejs.242.2020.06.18.13.42.20; Thu, 18 Jun 2020 13:42:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=eutxv2Pi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729164AbgFRRtQ (ORCPT + 99 others); Thu, 18 Jun 2020 13:49:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728537AbgFRRtQ (ORCPT ); Thu, 18 Jun 2020 13:49:16 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F9B4C06174E for ; Thu, 18 Jun 2020 10:49:16 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id d8so2720342plo.12 for ; Thu, 18 Jun 2020 10:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=gxk0mpNa0zDp1a6ZbGOjifp1sPgDInqSNRsdHtC1Hro=; b=eutxv2PiYY3Hf7kIcg35ZVWehj2QRs6NISrkXqJnBcO94eFIIVNhzMmYT/KvasEv/7 Dg6yWieF5fjiNuTwsTlEcQTv67pMIt2tUtBgW2ivWgeFKOiU86ydlDXiQ7myVBSdjmVs oZMjfJI21sdpnTEgfOMzh5iU1XLpr+ltfBd+WQE2hlaakXSoS/M/AwwQAIac0glLq+VB EbsFJ0PB7xPqGSLemiArDV6EcbSQZfZTPsu4Hqc1f5tkVGA3VNvFrddyWMijSyYCNPoU aPnbeTJWsDX3rmbvw85AggJa1YQLV0rNwwGgjQE92KVT7h6oNxHRKbT4pMQf/kHUwMVO U+QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=gxk0mpNa0zDp1a6ZbGOjifp1sPgDInqSNRsdHtC1Hro=; b=JG7ffxzWBPyWLTePnzNJQ3YCLsy5fE79un/uJmg9SIgkQW8h8fzXVPp7EC+aZa0F+C 9oPA8flIkXHnLkp+6wTvvo/VTr1p1LKnXiT8izl3G/x9m8Cw8CVzPrPR9XttphfhhY7o h5gcFsUrkRQDjRY7cwC3v/gEPmAFgczde+NYwb1hEmONW3lnVoaMemOTq4qGN/9M6Dol xa/gEqtelgghbEbO5SWwJCHQ1ujF96/GXJ47xA/m4cirTYxxvyH1gAYnGezK+ztkjmKa MGxqVgK9vYT/VsHBHM3XaPcIPeik5npVNlTtqu19RPY2StCxJjnKF6SNerIfaGTekTBG noGg== X-Gm-Message-State: AOAM530FHz1YnmMLFrUFhDaQMpCqh3FZJrvP0gBfr+BNGAFafVRpf/Xd tu+PXQdbxMk3L/OaPfo3BYr/dA== X-Received: by 2002:a17:90a:e7cd:: with SMTP id kb13mr5312238pjb.138.1592502555536; Thu, 18 Jun 2020 10:49:15 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id j184sm3447763pfg.131.2020.06.18.10.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 10:49:14 -0700 (PDT) Date: Thu, 18 Jun 2020 10:49:14 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Christoph Hellwig cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, kernel test robot Subject: Re: [PATCH] dma-mapping: DMA_COHERENT_POOL should select GENERIC_ALLOCATOR In-Reply-To: <20200618152506.116057-1-hch@lst.de> Message-ID: References: <20200618152506.116057-1-hch@lst.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Jun 2020, Christoph Hellwig wrote: > The dma coherent pool code needs genalloc. Move the select over > from DMA_REMAP, which doesn't actually need it. > > Fixes: dbed452a078d ("dma-pool: decouple DMA_REMAP from DMA_COHERENT_POOL") > Reported-by: kernel test robot Acked-by: David Rientjes Thanks Christoph. In the initial bug report from Alex Xu, his .config set CONFIG_GENERIC_ALLOCATOR already so I think there is very little risk with this patch.