Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5d00735a16728de5547c87e2cf4c29c23a1f0720.camel@massaru.org>
Subject: Re: [PATCH] kunit: fix KconfigParseError by ignoring CC_VERSION_TEXT
From:   Vitor Massaru Iha <vitor@massaru.org>
To:     Brendan Higgins <brendanhiggins@google.com>
Cc:     KUnit Development <kunit-dev@googlegroups.com>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-kernel-mentees@lists.linuxfoundation.org
Date:   Thu, 18 Jun 2020 17:36:50 -0300
In-Reply-To: <CAFd5g45AB8K-p78GRmauRPbkXLU572D2tuMTc0pumL+EgDA52Q@mail.gmail.com>
References: <20200618035736.245566-1-vitor@massaru.org>
         <CAFd5g45AB8K-p78GRmauRPbkXLU572D2tuMTc0pumL+EgDA52Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-06-18 at 13:29 -0700, Brendan Higgins wrote:
> On Wed, Jun 17, 2020 at 8:57 PM Vitor Massaru Iha <vitor@massaru.org>
> wrote:
> > Commit 8b59cd81dc5 ("kbuild: ensure full rebuild when the compiler
> > is updated") added the environment variable CC_VERSION_TEXT,
> > parse_from_string() doesn't expect a string and this causes the
> > failure below:
> > 
> > [iha@bbking linux]$ tools/testing/kunit/kunit.py run --timeout=60
> > [00:20:12] Configuring KUnit Kernel ...
> > Generating .config ...
> > Traceback (most recent call last):
> >   File "tools/testing/kunit/kunit.py", line 347, in <module>
> >     main(sys.argv[1:])
> >   File "tools/testing/kunit/kunit.py", line 257, in main
> >     result = run_tests(linux, request)
> >   File "tools/testing/kunit/kunit.py", line 134, in run_tests
> >     config_result = config_tests(linux, config_request)
> >   File "tools/testing/kunit/kunit.py", line 64, in config_tests
> >     success = linux.build_reconfig(request.build_dir,
> > request.make_options)
> >   File "/home/iha/lkmp/linux/tools/testing/kunit/kunit_kernel.py",
> > line 161, in build_reconfig
> >     return self.build_config(build_dir, make_options)
> >   File "/home/iha/lkmp/linux/tools/testing/kunit/kunit_kernel.py",
> > line 145, in build_config
> >     return self.validate_config(build_dir)
> >   File "/home/iha/lkmp/linux/tools/testing/kunit/kunit_kernel.py",
> > line 124, in validate_config
> >     validated_kconfig.read_from_file(kconfig_path)
> >   File "/home/iha/lkmp/linux/tools/testing/kunit/kunit_config.py",
> > line 89, in read_from_file
> >     self.parse_from_string(f.read())
> >   File "/home/iha/lkmp/linux/tools/testing/kunit/kunit_config.py",
> > line 85, in parse_from_string
> >     raise KconfigParseError('Failed to parse: ' + line)
> > kunit_config.KconfigParseError: Failed to parse:
> > CONFIG_CC_VERSION_TEXT="gcc (GCC) 10.1.1 20200507 (Red Hat 10.1.1-
> > 1)"
> 
> I am pretty there is already a fix out for this issue:
> 
> https://patchwork.kernel.org/patch/11592313/
> 
> Can you confirm?

Sure, thanks!