Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1645646ybt; Thu, 18 Jun 2020 13:45:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGeYRv9a87Pnnkt/Q8HCUMtPVUIvYfgjYTJVBcLXq6efW0SaGTC4PkyLCaQKnvNmmJqacO X-Received: by 2002:aa7:c607:: with SMTP id h7mr76216edq.214.1592513133954; Thu, 18 Jun 2020 13:45:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592513133; cv=none; d=google.com; s=arc-20160816; b=U8m4xyBXBDuzRtCht/FsWifAlR9b8k5bxES+mPVDkQTB06jZNpP53VY57Gd2GJz/UB g6rm9iSpTkQ6mL38/ja1Kz8o23pWkjgzuFb37hKMYRyG7itOvuMWtuG6QaJzLskNUTSI L2SHOBFY8TDCgl9kKVTlIqabLi+CI03jaDylvm9H41NznTPIsG5GfTEEpdZ0GOskIq4u F6oSkieUpuFemxEd4YtpIFnZxs1wePyKvBqCtTeHCNJ8WHvwMFQmKwlnW83MjnN+oMiD x76CP7Rk8hkb9ZfhIhyx0B27fTza8gwEelpvMxAGFeATdhahXqqQOLPsBvKhTl4l2qKf H4zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VTcBLAYXV1mQv30WKNwQeGVM54AorwT8x0vvBfoVBt4=; b=oZOLKl2LB54DFw79C/nKlnGVekQ4Lml+ZrVRgRMsyivkcRzmCMeFz2pvyyS1t6LIcz UDOojPUHAA9eUkOs+uQ6/VyLLqJmJUb4nSIa2snJmrH9htvcFtHN6rcMYA1aOvlB/FEN aYzCV/+bp5zTaJo09GKbQcBWk7zoCooIkoW+STowNe0lwuhVtnr8rlCbqHpW1HXbp3MQ /U/qMDMgcbzFtCZdWT4AwE371BNbnV0HaExaTNy2lrRj3V8FIUIl7Pw6X1QZUq9OTvMw 1g6kJ3F4sxCmUbnxzwrXzLoWgkLH4E3lL3xOhqLu4eT0k5wY2WovyO09dh0pT1uLuq/P SlpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=W3VDq+m3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i14si2598473ejy.164.2020.06.18.13.45.01; Thu, 18 Jun 2020 13:45:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=W3VDq+m3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731165AbgFRUaR (ORCPT + 99 others); Thu, 18 Jun 2020 16:30:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731048AbgFRUaK (ORCPT ); Thu, 18 Jun 2020 16:30:10 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83EDEC061797 for ; Thu, 18 Jun 2020 13:30:10 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id w1so6922038qkw.5 for ; Thu, 18 Jun 2020 13:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VTcBLAYXV1mQv30WKNwQeGVM54AorwT8x0vvBfoVBt4=; b=W3VDq+m3U9sl+nkLQVzDBj1FJvGteF3MCwrC/vpIWVJt1dJ9TTzu/y9/0IWlCWFaIy mlKjCH/WVmzAXtr/2nU0IWANYpKXL2HwKQuZBQ9DQZnl1NN3d0+CWesspUMKWagUfdmU PwPqjddPip40GKmxjrE39LcUuqqL7J4Tw8l08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VTcBLAYXV1mQv30WKNwQeGVM54AorwT8x0vvBfoVBt4=; b=Io+phEs+SK2I+P4SA2olseO56Xhy3xgj5DZkIfUkcDMrAs3velQ/4wg2erEsYbsTMe t7+d+8VojJiGizAVBoJZZ9ZIeDXgntEDAheTKzscHFswBo2AcfSrcGmJB5IAsoCZR1NU ngDPnmulEobk7QlbWXxNOQha2UHDtoIGrg+VJSHrmL7dEeQN+bD8jbaPg3WVJPpFqLe6 pAgKCIsc+4bBwONnoR/l7lIlPdA4ZBzaLQfO7pUe6dgxoJ/nkSgLbAoHMUYPDNC7HeNu 157fz7dZv9vdmFi8YjPVRsQEfhyj/hbCg2JwER8/UwA918SwW+bj5CiMAiVv6HvtLrx1 IYCQ== X-Gm-Message-State: AOAM530SKyc1SsqcX7O0dulFT9lINgkzAYWW3n6Z+mJ+a9tS5h/OPg8/ TOG39VLe9bsBASmO/bSMU8/CtDMmVNA= X-Received: by 2002:a37:7803:: with SMTP id t3mr233909qkc.358.1592512209457; Thu, 18 Jun 2020 13:30:09 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id v3sm4027503qkh.130.2020.06.18.13.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 13:30:09 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Davidlohr Bueso , Ingo Molnar , Josh Triplett , Lai Jiangshan , Marco Elver , Mathieu Desnoyers , "Paul E. McKenney" , rcu@vger.kernel.org, Steven Rostedt , "Uladzislau Rezki (Sony)" Subject: [PATCH 6/7] rcutorture: Add support to get the number of wakeups of main GP kthread Date: Thu, 18 Jun 2020 16:29:54 -0400 Message-Id: <20200618202955.4024-6-joel@joelfernandes.org> X-Mailer: git-send-email 2.27.0.111.gc72c7da667-goog In-Reply-To: <20200618202955.4024-1-joel@joelfernandes.org> References: <20200618202955.4024-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is useful to check for any improvements or degradation related to number of GP kthread wakeups during testing. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/Kconfig.debug | 1 + kernel/rcu/rcu.h | 2 ++ kernel/rcu/rcutorture.c | 23 ++++++++++++++++++++++- kernel/rcu/tree.c | 7 +++++++ 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/Kconfig.debug b/kernel/rcu/Kconfig.debug index 3cf6132a4bb9f..3323e3378af5a 100644 --- a/kernel/rcu/Kconfig.debug +++ b/kernel/rcu/Kconfig.debug @@ -50,6 +50,7 @@ config RCU_TORTURE_TEST select TASKS_RCU select TASKS_RUDE_RCU select TASKS_TRACE_RCU + select SCHEDSTATS default n help This option provides a kernel module that runs torture tests diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h index cf66a3ccd7573..7e867e81d9738 100644 --- a/kernel/rcu/rcu.h +++ b/kernel/rcu/rcu.h @@ -511,6 +511,7 @@ srcu_batches_completed(struct srcu_struct *sp) { return 0; } static inline void rcu_force_quiescent_state(void) { } static inline void show_rcu_gp_kthreads(void) { } static inline int rcu_get_gp_kthreads_prio(void) { return 0; } +static inline struct task_struct *rcu_get_main_gp_kthread(void) { return 0; } static inline void rcu_fwd_progress_check(unsigned long j) { } #else /* #ifdef CONFIG_TINY_RCU */ bool rcu_dynticks_zero_in_eqs(int cpu, int *vp); @@ -519,6 +520,7 @@ unsigned long rcu_exp_batches_completed(void); unsigned long srcu_batches_completed(struct srcu_struct *sp); void show_rcu_gp_kthreads(void); int rcu_get_gp_kthreads_prio(void); +struct task_struct *rcu_get_main_gp_kthread(void); void rcu_fwd_progress_check(unsigned long j); void rcu_force_quiescent_state(void); extern struct workqueue_struct *rcu_gp_wq; diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index d0d265304d147..959a1f84d6904 100644 --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -460,9 +461,29 @@ static void rcu_sync_torture_init(void) INIT_LIST_HEAD(&rcu_torture_removed); } +unsigned long rcu_gp_nr_wakeups; + +static void rcu_flavor_init(void) +{ + rcu_sync_torture_init(); + + /* Make sure schedstat is enabled for GP thread wakeup count. */ + force_schedstat_enabled(); + rcu_gp_nr_wakeups = rcu_get_main_gp_kthread()->se.statistics.nr_wakeups; +} + +static void rcu_flavor_cleanup(void) +{ + unsigned long now_nr = rcu_get_main_gp_kthread()->se.statistics.nr_wakeups; + + pr_alert("End-test: Cleanup: Total GP-kthread wakeups: %lu\n", + now_nr - rcu_gp_nr_wakeups); +} + static struct rcu_torture_ops rcu_ops = { .ttype = RCU_FLAVOR, - .init = rcu_sync_torture_init, + .init = rcu_flavor_init, + .cleanup = rcu_flavor_cleanup, .readlock = rcu_torture_read_lock, .read_delay = rcu_read_delay, .readunlock = rcu_torture_read_unlock, diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index c3bae7a83d792..a3a175feb310a 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -175,6 +175,13 @@ int rcu_get_gp_kthreads_prio(void) } EXPORT_SYMBOL_GPL(rcu_get_gp_kthreads_prio); +/* Retrieve RCU's main GP kthread task_struct */ +struct task_struct *rcu_get_main_gp_kthread(void) +{ + return rcu_state.gp_kthread; +} +EXPORT_SYMBOL_GPL(rcu_get_main_gp_kthread); + /* * Number of grace periods between delays, normalized by the duration of * the delay. The longer the delay, the more the grace periods between -- 2.27.0.111.gc72c7da667-goog