Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 18 Jun 2020 13:43:30 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Mike Rapoport <rppt@kernel.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Christoph Lameter <cl@linux.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Shakeel Butt <shakeelb@google.com>, <linux-mm@kvack.org>,
        Vlastimil Babka <vbabka@suse.cz>, <kernel-team@fb.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 00/19] The new cgroup slab memory controller
Message-ID: <20200618204330.GF110603@carbon.dhcp.thefacebook.com>
References: <20200608230654.828134-1-guro@fb.com>
 <20200618092707.GD6571@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200618092707.GD6571@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:632d) by DM6PR13CA0053.namprd13.prod.outlook.com (2603:10b6:5:134::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.10 via Frontend Transport; Thu, 18 Jun 2020 20:43:33 +0000
X-Originating-IP: [2620:10d:c090:400::5:632d]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a97c0f75-813f-45b5-9320-08d813c84554
X-MS-TrafficTypeDiagnostic: BYAPR15MB2487:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB2487E6D78AF505AAD5B10D17BE9B0@BYAPR15MB2487.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-Forefront-PRVS: 0438F90F17
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: whvOkUG5W15hJddHHiCCa7TCDGPcwXMKpljuWzLQcdq5N3d/h8H/o59gdTrZAcQVcKZP/yvlLGgCJd8ltFeBYqdH/gFNbk87zgGJlfKhLCQo5EFaSFOPzjnvFkr4UOV3+W+2Hde/6JpenLNKKUfwB9l+ViAhvGBI9imcGcqZ/eSZLnAdyusw2yLBaJMVESmdSwnjIKeNXBwZcdUUBDYEZswi1Gh3o3ndd+QA8TFhNRYVNc5pHV5V3xco3e9eDgKPg+PVOCG3Tl8r+FDq3M+54CGlf46AqykvEQHP1gtcc5hZvyu4bF4xUKCQnbEXC7IgxPL0Mvs6mkpuV/VkXq11Ww==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(396003)(346002)(376002)(366004)(39860400002)(1076003)(6506007)(478600001)(86362001)(83380400001)(8676002)(6916009)(8936002)(2906002)(9686003)(4326008)(66556008)(33656002)(316002)(54906003)(5660300002)(52116002)(186003)(7696005)(55016002)(16526019)(66946007)(66476007);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: tv7LIZ+J4UJj0ZRJyFHDka8fRtJiLOLBIloyn48t5ryMPXj9xTHCrGAC29Ksp3Vsh5Vd9A4az3r153pq4ypudBZy/gMpiP2Nfx8YkowIbxog3PbpWa62RfuN2TsvaTKzc/uIhI4UhSqWBz5SRxzkxQL3/CtrSqytMQy2uuP3EeoZVxE1iBMK0vCV6FU7b/S2Abpqk/REIU8LcP1yiS/T41/vs1ekJ0qBSJsGbgQ7aK12DjggFazg3J8ERfnfeKXYlu7RM3m00sIFZ3UNoQmluOLSN7/4yIDC/GlqCfBgsmOOmxriKqW6YxAnyuAw9w4/AGnJdgA5V7esIY5Ofgybv4yCHxqhX5FzHN4RVwpPdVEJuB+zsK1cwUJEPUzqOmj6qliE3bFBeQe6Qqp9Y4PDvZRe7qRqamB1I1KR3x0U/6xpTaNagc29turDtRf5saFz7E/z8iiXKnulrzyp+MuMsXuapKI7BR6Y2Ga67CjnJ9pZADhyBqyNJ4owzWJJnoJeL0pKdYhLOMgxDdWbW5cZdQ==
X-MS-Exchange-CrossTenant-Network-Message-Id: a97c0f75-813f-45b5-9320-08d813c84554
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2020 20:43:35.3147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JnspN0YfATBQtK3kEWR+mfMJfbbxX5t0eMoz0lzLvwk1HBTdrYvXHgGop7amV+el
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2487
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687
 definitions=2020-06-18_21:2020-06-18,2020-06-18 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 adultscore=0
 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1011 phishscore=0
 cotscore=-2147483648 malwarescore=0 bulkscore=0 lowpriorityscore=0
 mlxlogscore=999 mlxscore=0 suspectscore=2 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2004280000
 definitions=main-2006180158
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 18, 2020 at 12:27:07PM +0300, Mike Rapoport wrote:
> Hi Roman,
> 
> On Mon, Jun 08, 2020 at 04:06:35PM -0700, Roman Gushchin wrote:
> > This is v6 of the slab cgroup controller rework.
> > 
> > The patchset moves the accounting from the page level to the object
> > level. It allows to share slab pages between memory cgroups.
> > This leads to a significant win in the slab utilization (up to 45%)
> > and the corresponding drop in the total kernel memory footprint.
> > The reduced number of unmovable slab pages should also have a positive
> > effect on the memory fragmentation.
>  
> ... 
>  
> > Johannes Weiner (1):
> >   mm: memcontrol: decouple reference counting from page accounting
> > 
> > Roman Gushchin (18):
> >   mm: memcg: factor out memcg- and lruvec-level changes out of __mod_lruvec_state()
> >   mm: memcg: prepare for byte-sized vmstat items
> >   mm: memcg: convert vmstat slab counters to bytes
> >   mm: slub: implement SLUB version of obj_to_index()
> >   mm: memcg/slab: obj_cgroup API
> >   mm: memcg/slab: allocate obj_cgroups for non-root slab pages
> >   mm: memcg/slab: save obj_cgroup for non-root slab objects
> >   mm: memcg/slab: charge individual slab objects instead of pages
> >   mm: memcg/slab: deprecate memory.kmem.slabinfo
> >   mm: memcg/slab: move memcg_kmem_bypass() to memcontrol.h
> >   mm: memcg/slab: use a single set of kmem_caches for all accounted allocations
> >   mm: memcg/slab: simplify memcg cache creation
> >   mm: memcg/slab: remove memcg_kmem_get_cache()
> >   mm: memcg/slab: deprecate slab_root_caches
> >   mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo()
> >   mm: memcg/slab: use a single set of kmem_caches for all allocations
> >   kselftests: cgroup: add kernel memory accounting tests
> >   tools/cgroup: add memcg_slabinfo.py tool
>  
> Sorry for jumping late, but I'm really missing 
> 
>    Documentation/vm/cgroup-slab.rst	      | < lots of + >
> 
> in this series ;-)

Hi Mike!

That's a good point. I'll write something and send a separate patch.
Changes are barely visible to a user, so no rush here,
but it's definitely a good idea to document the new design.

Thank you!