Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Andi Kleen <ak@linux.intel.com>
CC:     linux-kernel <linux-kernel@vger.kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Tejun Heo <tj@kernel.org>, "Andrii Nakryiko" <andriin@fb.com>,
        Francis Ricci <fjricci@fb.com>
Subject: Re: WARNING with LBR + precise_ip=2 + bpf_get_stackid()
Thread-Topic: WARNING with LBR + precise_ip=2 + bpf_get_stackid()
Thread-Index: AQHWRZVzS1zA6qEPN0CAIz19Cc1kQqje9n2AgAAMpQA=
Date:   Thu, 18 Jun 2020 23:21:11 +0000
Message-ID: <4889871D-5E00-4E50-9089-2A18C29B8D93@fb.com>
References: <ED7B9430-6489-4260-B3C5-9CFA2E3AA87A@fb.com>
 <20200618223555.GB793265@tassilo.jf.intel.com>
In-Reply-To: <20200618223555.GB793265@tassilo.jf.intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D845E33F01D3044A8CBD2E01A7C6B6E1@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2162aec0-e7eb-416d-c179-08d813de4999
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 23:21:11.0296
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0owxUwlFHX4EV3naLiJDr18B/DUTFtalKzyazbnpLFubb1+cTPv5TFgWGSfdjo12wxGAC+ilo5TSJRor8neS1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2725
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687
 definitions=2020-06-18_21:2020-06-18,2020-06-18 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 clxscore=1015
 priorityscore=1501 impostorscore=0 cotscore=-2147483648 suspectscore=0
 spamscore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 bulkscore=0
 adultscore=0 mlxlogscore=852 malwarescore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2004280000
 definitions=main-2006180179
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jun 18, 2020, at 3:35 PM, Andi Kleen <ak@linux.intel.com> wrote:
>=20
>> We noticed that this only happens with precise_ip >=3D 2. This is caused=
 by=20
>> setup_pebs_fixed_sample_data() using pens->real_ip:
>>=20
>> 	set_linear_ip(regs, pebs->real_ip);
>=20
> With precise_ip =3D=3D 1 the IP will be one instruction behind.
> That's the only difference to 2 or 3.
>=20
> So something about the actual instruction confuses the unwinder.
>=20
> I would check if there is anything special about these IPs:
>=20
>> 0xfffffe00004d1f78 entry_SYSCALL_64
>> 0xfffffe00004d1fa0 entry_SYSCALL_64
>> 0xfffffe00004d1fd8 entry_SYSCALL_64

I don't have this system at the moment. For the system I have, I got:

[36000.163945] WARNING: can't access registers at error_entry+0x74/0xe0
[36000.243879] WARNING: can't access registers at error_entry+0x65/0xe0
[36000.334288] WARNING: can't access registers at syscall_return_via_sysret=
+0x12/0x7f
[36000.540940] WARNING: can't access registers at syscall_return_via_sysret=
+0x6/0x7f
[58419.640387] WARNING: can't access registers at syscall_return_via_sysret=
+0xb/0x7f
[58423.082418] WARNING: can't access registers at syscall_return_via_sysret=
+0xf/0x7f
[58423.155705] WARNING: can't access registers at syscall_return_via_sysret=
+0x6/0x7f

And

(gdb) x/5i error_entry+0x65
   0xffffffff81c01075 <error_entry+101>:        pop    %r12
   0xffffffff81c01077 <error_entry+103>:        mov    %rsp,%rdi
   0xffffffff81c0107a <error_entry+106>:        callq  0xffffffff81aa7a30 <=
sync_regs>
   0xffffffff81c0107f <error_entry+111>:        mov    %rax,%rsp
   0xffffffff81c01082 <error_entry+114>:        push   %r12
(gdb) x/5i error_entry+0x74
   0xffffffff81c01084 <error_entry+116>:        retq
   0xffffffff81c01085 <error_entry+117>:        nop
   0xffffffff81c01086 <error_entry+118>:        nop
   0xffffffff81c01087 <error_entry+119>:        nop
   0xffffffff81c01088 <error_entry+120>:        retq
(gdb) x/5i syscall_return_via_sysret+0xb
   0xffffffff81c000ec <entry_SYSCALL_64+236>:   pop    %r10
   0xffffffff81c000ee <entry_SYSCALL_64+238>:   pop    %r9
   0xffffffff81c000f0 <entry_SYSCALL_64+240>:   pop    %r8
   0xffffffff81c000f2 <entry_SYSCALL_64+242>:   pop    %rax
   0xffffffff81c000f3 <entry_SYSCALL_64+243>:   pop    %rsi
(gdb) x/5i syscall_return_via_sysret+0xa
   0xffffffff81c000eb <entry_SYSCALL_64+235>:   pop    %rsi
   0xffffffff81c000ec <entry_SYSCALL_64+236>:   pop    %r10
   0xffffffff81c000ee <entry_SYSCALL_64+238>:   pop    %r9
   0xffffffff81c000f0 <entry_SYSCALL_64+240>:   pop    %r8
   0xffffffff81c000f2 <entry_SYSCALL_64+242>:   pop    %rax
(gdb) x/5i syscall_return_via_sysret+0x12
   0xffffffff81c000f3 <entry_SYSCALL_64+243>:   pop    %rsi
   0xffffffff81c000f4 <entry_SYSCALL_64+244>:   pop    %rdx
   0xffffffff81c000f5 <entry_SYSCALL_64+245>:   pop    %rsi
   0xffffffff81c000f6 <entry_SYSCALL_64+246>:   mov    %rsp,%rdi
   0xffffffff81c000f9 <entry_SYSCALL_64+249>:   mov    %gs:0x6004,%rsp
(gdb) x/5i syscall_return_via_sysret+0x6
   0xffffffff81c000e7 <entry_SYSCALL_64+231>:   pop    %r12
   0xffffffff81c000e9 <entry_SYSCALL_64+233>:   pop    %rbp
   0xffffffff81c000ea <entry_SYSCALL_64+234>:   pop    %rbx
   0xffffffff81c000eb <entry_SYSCALL_64+235>:   pop    %rsi
   0xffffffff81c000ec <entry_SYSCALL_64+236>:   pop    %r10

I am not sure whether there is anything special. Maybe "pop"?

Thanks,
Song