Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read
Reply-To: daejun7.park@samsung.com
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Daejun Park <daejun7.park@samsung.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sang-yoon Oh <sangyoon.oh@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Adel Choi <adel.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <SN6PR04MB4640B1D4FBDF68A59D993F21FC9B0@SN6PR04MB4640.namprd04.prod.outlook.com>
Message-ID: <231786897.01592525881606.JavaMail.epsvc@epcpadp2>
Date:   Fri, 19 Jun 2020 09:12:20 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
References: <SN6PR04MB4640B1D4FBDF68A59D993F21FC9B0@SN6PR04MB4640.namprd04.prod.outlook.com>
        <231786897.01592213402355.JavaMail.epsvc@epcpadp1>
        <231786897.01592212081335.JavaMail.epsvc@epcpadp2>
        <336371513.41592205783606.JavaMail.epsvc@epcpadp2>
        <231786897.01592205482200.JavaMail.epsvc@epcpadp2>
        <231786897.01592214002170.JavaMail.epsvc@epcpadp1>
        <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p8>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> +static void ufshpb_run_active_subregion_list(struct ufshpb_lu *hpb)
> > +{
> > +       struct ufshpb_region *rgn;
> > +       struct ufshpb_subregion *srgn;
> > +       struct ufshpb_map_ctx *mctx;
> mctx  doesn't really do anything here

OK, I will delete it.

> > +       unsigned long flags;
> > +       int ret = 0;
> > +
> > +       spin_lock_irqsave(&hpb->rsp_list_lock, flags);
> > +       while ((srgn = list_first_entry_or_null(&hpb->lh_act_srgn,
> > +                                               struct ufshpb_subregion,
> > +                                               list_act_srgn))) {
> > +               list_del_init(&srgn->list_act_srgn);
> > +               spin_unlock_irqrestore(&hpb->rsp_list_lock, flags);
> > +
> > +               rgn = hpb->rgn_tbl + srgn->rgn_idx;
> > +               mctx = NULL;
> > +               ret = ufshpb_add_region(hpb, rgn);
> > +               if (ret)
> > +                       break;
> > +
> > +               ret = ufshpb_issue_map_req(hpb, rgn, srgn);
> > +               if (ret) {
> > +                       dev_notice(&hpb->hpb_lu_dev,
> > +                           "issue map_req failed. ret %d, region %d - %d\n",
> > +                           ret, rgn->rgn_idx, srgn->srgn_idx);
> > +                       break;
> > +               }
> > +               spin_lock_irqsave(&hpb->rsp_list_lock, flags);
> > +       }
> > +
> > +       if (ret) {
> > +               dev_notice(&hpb->hpb_lu_dev, "region %d - %d, will retry\n",
> > +                          rgn->rgn_idx, srgn->srgn_idx);
> > +               spin_lock_irqsave(&hpb->rsp_list_lock, flags);
> > +               ufshpb_add_active_list(hpb, rgn, srgn);
> > +       }
> > +       spin_unlock_irqrestore(&hpb->rsp_list_lock, flags);
> > +}
> 
>