Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp159273ybt;
        Thu, 18 Jun 2020 21:38:07 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwmS7N54zILyq5x95Z7HoXPD+gN0rS0Ix25vsVU7XPVWjzk5+mgeSjdJNvjYKN7TaglZZdw
X-Received: by 2002:a17:906:a250:: with SMTP id bi16mr1859601ejb.418.1592541487492;
        Thu, 18 Jun 2020 21:38:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1592541487; cv=none;
        d=google.com; s=arc-20160816;
        b=mcIacFu3GPfkwfSncPR/cA+BGcDOszzz1imHpKli9tjx3RAJF5nfTf43lPEtqA6ilm
         Cnz4H9O4gWbzVFGuiTBk3bFplEFdN5tjGAMNnjZVjReJCLp3ZGlTC11Z7cksIDYFQ2kR
         LEpxgWWbGizfYqrpq6IlpNEmN/KdI+4Ioyt0GTwzWUMwSgdDaL0FqkCteMp1bNid1DFm
         pJ8Ahjstl9ekR3y6GTPZUCIfU6hAoX5TMRAf3bs60a6M/HDpWoyo5Ukx1H0WEYfulwQt
         3lVsSwvNxtG4e2RiezudNFxOR7EGrstJsVhr4baAgswilAJF0NJzZE3bWw6UZDAhz6jI
         17Vw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=HUwrtLPG9ftpjfEmOCE0jeobSuJN+5fr/1lcybKUIF0=;
        b=iI9enpwRddWmEOOXRDFTwqlc9dSZ38DjF5vxwLuALFSifiIpR1zT0x8KtjRZnWF5d2
         4W0jYj6sZimE/OvXRi44FuqohnVMuviK7SPzG/LCVSJJZLuFGLobwj43cwCzVKqUKnD0
         q540plaC2EjDlyVTvjbapuXr0QAC8yqJQrviMy+rSPhDcLcLK59dRmRWBhmjZUn2cX1X
         cJXQfJN7FVg/d9C34Cs2AGibFNNiouxX4uwUm4RbMTcPd8dCHZGv2U3gEpZM8gf/bJ38
         mOzCHRMnmfpulU9TxoedpHosU+Zrz7xQU28TuNS1YMrbbFLaYvyce9FnhcR+YI4JhIEb
         UPdg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a8si3324360edq.164.2020.06.18.21.37.45;
        Thu, 18 Jun 2020 21:38:07 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729080AbgFSDft (ORCPT <rfc822;jaegeuk-test@gmail.com>
        + 99 others); Thu, 18 Jun 2020 23:35:49 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35110 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726573AbgFSDft (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 Jun 2020 23:35:49 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AB46C06174E;
        Thu, 18 Jun 2020 20:35:49 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 8CD7F120ED49C;
        Thu, 18 Jun 2020 20:35:48 -0700 (PDT)
Date:   Thu, 18 Jun 2020 20:35:47 -0700 (PDT)
Message-Id: <20200618.203547.1927187219633676867.davem@davemloft.net>
To:     drc@linux.vnet.ibm.com
Cc:     netdev@vger.kernel.org, siva.kallam@broadcom.com,
        prashant@broadcom.com, mchan@broadcom.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors
 exceed eeh_max_freezes
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200617185117.732849-1-drc@linux.vnet.ibm.com>
References: <20200615190119.382589-1-drc@linux.vnet.ibm.com>
        <20200617185117.732849-1-drc@linux.vnet.ibm.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Jun 2020 20:35:48 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: David Christensen <drc@linux.vnet.ibm.com>
Date: Wed, 17 Jun 2020 11:51:17 -0700

> The driver function tg3_io_error_detected() calls napi_disable twice,
> without an intervening napi_enable, when the number of EEH errors exceeds
> eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock.
> 
> Add check for pcierr_recovery which skips code already executed for the
> "Frozen" state.
> 
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>

Applied and queued up for -stable, thanks.