Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp165193ybt; Thu, 18 Jun 2020 21:51:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9Pqw4PHweAoqrt8aSKFT48C0/uEqUBf9akArEAeKRzGGK8G/wPOQLofqCG8coGGjS7DI6 X-Received: by 2002:a05:6402:54d:: with SMTP id i13mr1485511edx.330.1592542266408; Thu, 18 Jun 2020 21:51:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592542266; cv=none; d=google.com; s=arc-20160816; b=Bg+gRXpQBqRJY1AMzpPkeA6Jb2qe/2wrMQhNMmiHhTNjyN9geE4p7n0IU6iTDPM7d+ 6TcsA/kNZGAzA1FwteFVNxyQl8tPwkKCVerJmYnktx8R2l8QimnQToSyUu1gA0E65kLn 2wW9ciyDxFPIyCYfQKK7pJYa0CP9zTuMEWHSrRgM+ypYWGzl4oMBp1/GXicTQQGEMApz ta4rfFgDafjhXly7tXy7/9ZoyXf/14PKN5Ku4BPWabFygGhaOw5yrgrl+2weokNaou7u jFzoh9Xl66JyUZoU1K1FKiBZQ1IBR6Rx+VMPOL2ohhx+6WZqZkbboum0dVHBotWXGNUD 414g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=yhxb+8UbGvqenTIgOue4feVVgBvOeMtH0Mub+VsKj2A=; b=ML85zDThJRaDn+UQLsD0u9rlq8UAjKkLFzSfF0RqBs4lRjbGTAjyZUEZOE6j4/WLpN x+Hc0cBKrw3FzmIuYbiMm6CNl27O0IDvEs+kOBFDqOBxKRAObDdaktC9jxzLq8dMEd2D XjEqwRolmIJjiwejpC4mxrOsl208qCoAPkPNP78kz4O5XCQ3PwS1+HemgGQlLMNS0s18 b3hxJRlFz5kfhburkklHFBDq7YjXDzwRqyB3Yk0tmAYs9o3gtXGNt8nHxXw/F0vtfila vVtnJzkbCuimWFLY1sy2r1wOdLoZVgu+mQsXz54EYDP48bhTP4e9cWZp46Dtq1WbAsJb /Zjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c23si3479910edv.204.2020.06.18.21.50.44; Thu, 18 Jun 2020 21:51:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728320AbgFSDAM (ORCPT + 99 others); Thu, 18 Jun 2020 23:00:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726906AbgFSDAM (ORCPT ); Thu, 18 Jun 2020 23:00:12 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0142CC06174E; Thu, 18 Jun 2020 20:00:11 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6A86F120ED49A; Thu, 18 Jun 2020 20:00:10 -0700 (PDT) Date: Thu, 18 Jun 2020 20:00:09 -0700 (PDT) Message-Id: <20200618.200009.1375774785038059331.davem@davemloft.net> To: s.hauer@pengutronix.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@bootlin.com, kernel@pengutronix.de, linux@armlinux.org.uk, rmk+kernel@armlinux.org.uk Subject: Re: [PATCH 1/2] net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy From: David Miller In-Reply-To: <20200616083140.8498-1-s.hauer@pengutronix.de> References: <20200616083140.8498-1-s.hauer@pengutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Jun 2020 20:00:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sascha Hauer Date: Tue, 16 Jun 2020 10:31:39 +0200 > The MVNETA_SERDES_CFG register is only available on older SoCs like the > Armada XP. On newer SoCs like the Armada 38x the fields are moved to > comphy. This patch moves the writes to this register next to the comphy > initialization, so that depending on the SoC either comphy or > MVNETA_SERDES_CFG is configured. > With this we no longer write to the MVNETA_SERDES_CFG on SoCs where it > doesn't exist. > > Suggested-by: Russell King > Signed-off-by: Sascha Hauer Applied.