Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp231269ybt; Fri, 19 Jun 2020 00:06:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIgWlD9cpm8kaj2LJHADqz3RDK7uWtiY9NsTp82Ui8q88+5bcMpDpLlD32ZzeN46Hb2WIV X-Received: by 2002:a17:906:d9dc:: with SMTP id qk28mr2264665ejb.6.1592550368087; Fri, 19 Jun 2020 00:06:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592550368; cv=none; d=google.com; s=arc-20160816; b=N36zChobxsjNiQnnQLHymxRLrgw82ElfDtlh9qq0oPlZSCTb34ZyyMiz2hA3ThJMy4 xQSn1WOGVn8Sm4+rjqWgnJ5RK+I5nlV2meuQY652UdvJ1ksxFdr+r9O6T1my4cuOJuDj Wojze+Ut4Y867eQ2xxBAqZtSCO7252Alku7mfkNrNa2tfLte+eyKZEBGoMbC+bYepB7K Ql4qDPLEC9jxF9FXQgF+DqpvJRRimlajllDzYelYEY2eRqn34BwaElmIc8C2QE2oZHum DavMdzzRYTvpog0Dojqza5aRN6oSHTrYe2H+6LC0lFPo/jYs1JiOw9KNi7svGRMzn8WE 3lTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=29xULxJCIJJBM7FmlrqMmhHTK6tWJ7AFfkAGJqVdsnU=; b=qg3IUO5FU7OC7RfzKtNu6VxbOWPGQ9LbB5uvcmHkVZyb2DKNsifT2uLaLLd2+VekTk fivZbTFRAv+kYJmBwM1Jeq+6QGOABCnTMWuc70xtQYBZ4jWJ9TbpcQUMbGNUupes5uT/ nte0zHz7gUVBTGOIaydrbXbBfZzLy4iJpjdRTyXXr6hv6LxPJBNoQPcHzUGKGIJTIuTx WkD6f29Buq/4evpKuFQJ4Sl2WnG7nKf+E2WmvGIJobxvzjSLTPDiOx7ldr9ly0bcOZwK fmsx9yaxaRCNdyG8FBN9t1K/McGoQ+l/bzUtUQPSKC7DsxeTI0R9j94M4fRJbfiglspp qZZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=L7U0ymED; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z7si3376440ejp.639.2020.06.19.00.05.45; Fri, 19 Jun 2020 00:06:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=L7U0ymED; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729685AbgFSHDo (ORCPT + 99 others); Fri, 19 Jun 2020 03:03:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727916AbgFSHDn (ORCPT ); Fri, 19 Jun 2020 03:03:43 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61CABC06174E for ; Fri, 19 Jun 2020 00:03:43 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id e12so6778291eds.2 for ; Fri, 19 Jun 2020 00:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=29xULxJCIJJBM7FmlrqMmhHTK6tWJ7AFfkAGJqVdsnU=; b=L7U0ymEDMd6Bujw42JqfDFfjnSqwmTmi671C+VTC+1tsnM3fzEmNpzObB5E528wdw3 gxHGYIVUTz0zs7LciEdJ4SaXvYbsfPtcvbz2+NqivtMnKi6STRcX1u3Ua62r7d2US6eH AD5Y69xW7hNFdou6RI+icSjFxUUtbNQVVsbKRfbXIGAp4G+x7nE6Dnq9dslmh60UIJyQ QV6PqoVBQ7ahn0I1jMcBcEmXUwg3tU6z9dy146hDNIBiwRAcmGz2ifNEJ8EeWOVgFVGA hzvpB1Ovknt3qJeSbPkckaQ0MKzntUX3NTNn86jrH/Hi4twNnFbjqfvEP+lHvthUI95d 8KdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=29xULxJCIJJBM7FmlrqMmhHTK6tWJ7AFfkAGJqVdsnU=; b=uYTiXx7trrf7nwqI7HtVG1o1XD17NcIiQ3FPWUtxHlFn5QsBUTAObVkcseiUG18lDe XLI/3R38BqYdCCl7kdyImVPqRtsHDXtMsi916uipZuU5zCGj811yN7d/zV3gPE5GeC/q lrIMitnRk5DJVMxVe1aySZTyMrnndoLAjVlRZAo17660FKgKkyIOyS3F1frSqEj9fueR 7WFD7GtYoojyH4HIEDfMpv6PkhmaxMJZvRAPH8RIQLQ8BFxsepKEPRLKG+LV2UzBzAH+ gbRqYvnv2hsJRuLAM2IT66VAJsoWmuySdlA5AquaJUQJKFCCdxB5PitkuIXF1W6jnhgn 0XBQ== X-Gm-Message-State: AOAM5317zYQl5VpC/Fk2M2bEUC6P7Q929gyykVGR0YmPOsEObO1kZIHp xcHhW5GMBd84vnFMUfsBgjkX+J5HsgnM4Q== X-Received: by 2002:a50:cd56:: with SMTP id d22mr1800363edj.374.1592550222007; Fri, 19 Jun 2020 00:03:42 -0700 (PDT) Received: from netronome.com ([2001:982:7ed1:403:9eeb:e8ff:fe0d:5b6a]) by smtp.gmail.com with ESMTPSA id u3sm4208545edx.25.2020.06.19.00.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 00:03:41 -0700 (PDT) Date: Fri, 19 Jun 2020 09:03:40 +0200 From: Simon Horman To: Po Liu Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jiri@resnulli.us, vinicius.gomes@intel.com, vlad@buslov.dev, claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, alexandru.marginean@nxp.com, michael.chan@broadcom.com, vishal@chelsio.com, saeedm@mellanox.com, leon@kernel.org, jiri@mellanox.com, idosch@mellanox.com, alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, kuba@kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, pablo@netfilter.org, moshe@mellanox.com, m-karicheri2@ti.com, andre.guedes@linux.intel.com, stephen@networkplumber.org Subject: Re: [v2,net-next] net: qos offload add flow status with dropped count Message-ID: <20200619070340.GE9312@netronome.com> References: <20200324034745.30979-1-Po.Liu@nxp.com> <20200619060107.6325-1-po.liu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200619060107.6325-1-po.liu@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 19, 2020 at 02:01:07PM +0800, Po Liu wrote: > From: Po Liu > > This patch adds a drop frames counter to tc flower offloading. > Reporting h/w dropped frames is necessary for some actions. > Some actions like police action and the coming introduced stream gate > action would produce dropped frames which is necessary for user. Status > update shows how many filtered packets increasing and how many dropped > in those packets. > > v2: Changes > - Update commit comments suggest by Jiri Pirko. > > Signed-off-by: Po Liu > --- > This patch is continue the thread 20200324034745.30979-1-Po.Liu@nxp.com > > drivers/net/dsa/sja1105/sja1105_vl.c | 2 +- > drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 2 +- > drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 2 +- > .../net/ethernet/chelsio/cxgb4/cxgb4_tc_matchall.c | 2 +- > drivers/net/ethernet/freescale/enetc/enetc_qos.c | 7 +++++-- > drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++-- > drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 2 +- > drivers/net/ethernet/mscc/ocelot_flower.c | 2 +- > drivers/net/ethernet/netronome/nfp/flower/offload.c | 2 +- > drivers/net/ethernet/netronome/nfp/flower/qos_conf.c | 2 +- > include/net/act_api.h | 11 ++++++----- > include/net/flow_offload.h | 5 ++++- > include/net/pkt_cls.h | 5 +++-- > net/sched/act_api.c | 10 ++++------ > net/sched/act_ct.c | 6 +++--- > net/sched/act_gact.c | 7 ++++--- > net/sched/act_gate.c | 6 +++--- > net/sched/act_mirred.c | 6 +++--- > net/sched/act_pedit.c | 6 +++--- > net/sched/act_police.c | 4 ++-- > net/sched/act_skbedit.c | 5 +++-- > net/sched/act_vlan.c | 6 +++--- > net/sched/cls_flower.c | 1 + > net/sched/cls_matchall.c | 3 ++- > 25 files changed, 60 insertions(+), 50 deletions(-) Netronome portion: Reviewed-by: Simon Horman