Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp253978ybt; Fri, 19 Jun 2020 00:49:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1dMGkTW6ftoubNCYb4i+mQ+AQqJzgY+m0CwcYFYHxLATIh7bPmtgDhOg9H1TJLvZexGy9 X-Received: by 2002:a17:906:28da:: with SMTP id p26mr2071282ejd.551.1592552981915; Fri, 19 Jun 2020 00:49:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592552981; cv=none; d=google.com; s=arc-20160816; b=owhQF9R+bk/5rqzxO/zzwPIvh1d8MKtqcys/JssVOlOxm9jsRz6g/cF2/DnjXifs26 Z9owgdpbn79WJfM9PK7ojrLFLTltLXe8/wKSpKq9aemwLqBngZvDZNpTWn1CGC7yABhV I4wx1qE9UIZQXzatAuzrkTqgojB+G+jAIYbOcqjxyuK2bSSsYredgVCF+FjrcIjN+MLN 81HXWpJDom+q3i5zCVTit0OaTNzXR77t7CE9/roYZ052Im+MuUuFHcHx1ZL+Ew8kBlBJ hPCRgT5+AWjtKPPj+Wfk6rZI1ROPrRhILHmJVKs127dOHtWYmIXNGFKqC4EcpHDDNfc7 u85Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LExsgrzaNyl8ZFPNIxBm2qDBZpOXhx0RBNl8C2nzaSw=; b=R7jhoa3sU5LDyfO8KduiBVx0uGHPVm2cQrAEz4cboY6lKd6snzaFW7mDHQ/1ek42Nm DEW+zLPpryYU/tKqsVwmx40zN+l3dOHGKIGQfyPfU83FeIIgHI26Hm/kCLLysZJ8etju xuPxaomCGUEfsfpgJrYfX7omPBMEOw97hBdpcCPPy1eErjRK7kaLja7y8PrAohhCM+j3 kmlcG0gKWVFajJvqtmPy5PDINtGT0/2Hvw42GlMZTulNTCTs+LAjOJQRVJV/nABBC1Cv 5r8gTjePcaLUi6kv55XrsJ18//qe9/o/A1qtuVkjdhI/BxHVZ1EGCX1OkyUPhoR5hkqm DgzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=s9GduRbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn11si3380412edb.170.2020.06.19.00.49.18; Fri, 19 Jun 2020 00:49:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=s9GduRbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731143AbgFSHqf (ORCPT + 99 others); Fri, 19 Jun 2020 03:46:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729548AbgFSHqf (ORCPT ); Fri, 19 Jun 2020 03:46:35 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DDB4C06174E; Fri, 19 Jun 2020 00:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LExsgrzaNyl8ZFPNIxBm2qDBZpOXhx0RBNl8C2nzaSw=; b=s9GduRbeIzfQ6rou+EY1Ez+mFQ WKczu0uQfkh+8bNlk6SoQvnajAr3wdDyxlhWPRfiXZSqcjkhBdS6f2mY9UUTBFqyJ2U/liICIvOMC k1ROtJP+IxZe8pWr95o2iWfZmCMEZYyzoJp76ILMc/f7jzh5gYxlWmq5CAiP8MQaPnlbhvxt3+lRF ++RgOqoAE6HbplJO88O/VMURinrCndzkhPuR2J5KeOQyuDesAPiYYDaN3nGtqNCVDp5NB5Qf0yjvi z7jlLtGYc5Is0XaPCy8R8suAgPHUO2pNuDfkZO/Mc8rLDn+dYvlY+x5y2y/gyMv2/VnGMMe76cUXl BaMxIpZw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jmBjL-0001pk-JL; Fri, 19 Jun 2020 07:46:31 +0000 Date: Fri, 19 Jun 2020 00:46:31 -0700 From: Christoph Hellwig To: Alexey Dobriyan Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arch@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH] linux++, this: rename "struct notifier_block *this" Message-ID: <20200619074631.GA1427@infradead.org> References: <20200618210645.GB2212102@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618210645.GB2212102@localhost.localdomain> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 19, 2020 at 12:06:45AM +0300, Alexey Dobriyan wrote: > Rename > struct notifier_block *this > to > struct notifier_block *nb > > "nb" is arguably a better name for notifier block. But not enough better to cause tons of pointless churn. Feel free to use better naming in new code you write or do significant changes to, but stop these pointless renames.