Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Jun 2020 10:13:36 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Andi Kleen <ak@linux.intel.com>
Cc:     Song Liu <songliubraving@fb.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Tejun Heo <tj@kernel.org>, Andrii Nakryiko <andriin@fb.com>,
        Francis Ricci <fjricci@fb.com>
Subject: Re: WARNING with LBR + precise_ip=2 + bpf_get_stackid()
Message-ID: <20200619081336.GQ576905@hirez.programming.kicks-ass.net>
References: <ED7B9430-6489-4260-B3C5-9CFA2E3AA87A@fb.com>
 <20200618223555.GB793265@tassilo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200618223555.GB793265@tassilo.jf.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 18, 2020 at 03:35:55PM -0700, Andi Kleen wrote:
> > We noticed that this only happens with precise_ip >= 2. This is caused by 
> > setup_pebs_fixed_sample_data() using pens->real_ip:
> > 
> > 	set_linear_ip(regs, pebs->real_ip);
> 
> With precise_ip == 1 the IP will be one instruction behind.
> That's the only difference to 2 or 3.
> 
> So something about the actual instruction confuses the unwinder.

It's trying to do an unwind with the PEBS IP (or worse the whole PEBS
regset), which doesn't match the interrupt IP or the stack layout at
that time. Of course it doesn't work.