Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp280196ybt; Fri, 19 Jun 2020 01:37:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgWBfAveD7kDd2sJnI3Hj2jbiz/4LmakjFS33fgHbQZ7q7+GRbufKUOxlKPkq+IOnEXrCm X-Received: by 2002:a17:907:2058:: with SMTP id pg24mr2487058ejb.63.1592555853838; Fri, 19 Jun 2020 01:37:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592555853; cv=none; d=google.com; s=arc-20160816; b=R361mOCEQ/uRGVPT2T1uTmtNkcNtRLmoAvJbT+Nah4AF9WOY1WB9fFvUZP4/IA+cTB mC5jlgPOfjzuDESwivUNF55xSVfXbZarT0XrVds3TSlFxe+FEIkLDhehFsr4UCT2F122 7rK0HUL3knSnzPpUhyFSicfu7YsBK/MBmvQzJeTdsCQDTyNJ3k9UpZlRkWC/22IM8wsf s0N60zTxA7RVrkwN/WfLAfGEzhjUiRDrALQSVWgZqjnuL8P3pwwW9GmpH7GgLU3doK5+ IOeXwTpp1VZeXVqThwoNJtgt8OSlsehlvXJbMKkwqSJjtg81VSSwf3WrJOlJfb308TZZ jlkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=rsT+WblLhm3xpX/g3ZEUbD3ScRD2cJwJv7LJRoTXOMI=; b=iocQ1/aGGlWGJyXF2zL/o6lBqvw/OrGeDOQBMDFIsit3WkgwSXbyjA9uvdUKGpdugV 90B5iTMy/y1jMVrMFc0YWs5egPPTrzOGuyVm1TlZhwf5xyPjY4gzOegaagxNA50EDHeb YpZagjuXVTDATfR1ebeO7h/5msWp1XAuDiNnvnZ1rPcZJvvcGVV2eAdonAstTCNWrfhW JZK4WECfIZiAzXIP1yvkpZ6Dk4BNMwAJd+pf6gk631dNYsdq1orQNkryCbqOJripn3uf wGaHUbLLxrxmKZoObgZim+SWU4EWvPOGQBiMu5TP/PtAajLXzEvWesbZHejYco/mE7u7 vjTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lf3si3284347ejb.350.2020.06.19.01.37.11; Fri, 19 Jun 2020 01:37:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731609AbgFSIfB (ORCPT + 99 others); Fri, 19 Jun 2020 04:35:01 -0400 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:34773 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731657AbgFSIeg (ORCPT ); Fri, 19 Jun 2020 04:34:36 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R541e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01358;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0U01UGJV_1592555662; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U01UGJV_1592555662) by smtp.aliyun-inc.com(127.0.0.1); Fri, 19 Jun 2020 16:34:22 +0800 From: Alex Shi To: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com Cc: Michal Hocko , Vladimir Davydov Subject: [PATCH v13 08/18] mm/memcg: add debug checking in lock_page_memcg Date: Fri, 19 Jun 2020 16:33:46 +0800 Message-Id: <1592555636-115095-9-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1592555636-115095-1-git-send-email-alex.shi@linux.alibaba.com> References: <1592555636-115095-1-git-send-email-alex.shi@linux.alibaba.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a debug checking in lock_page_memcg, then we could get alarm if anything wrong here. Suggested-by: Johannes Weiner Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgroups@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/memcontrol.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 0b38b6ad547d..78c16ac1473d 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1983,6 +1983,12 @@ struct mem_cgroup *lock_page_memcg(struct page *page) if (unlikely(!memcg)) return NULL; +#ifdef CONFIG_PROVE_LOCKING + local_irq_save(flags); + might_lock(&memcg->move_lock); + local_irq_restore(flags); +#endif + if (atomic_read(&memcg->moving_account) <= 0) return memcg; -- 1.8.3.1