Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp317572ybt; Fri, 19 Jun 2020 02:44:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxi4Nmgq+LY58m6QYDllNTsrrwlhZ0jTyPtBg27+9tdrFtvt1WflHTWtEBxPaZ+l7Uw/Dl0 X-Received: by 2002:a17:907:a84:: with SMTP id by4mr2909814ejc.440.1592559853049; Fri, 19 Jun 2020 02:44:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592559853; cv=none; d=google.com; s=arc-20160816; b=w+ccdxGYFRT77DnbQu68J3/oTJEO/zq7S5kejr+E51EQjcMVifV3z6VJfCZwanwpV7 QZ6VCNd7MYvOmeAps9xB+A2kseWuz6Ajc9lMKRHq4BtCj1eVQKbZ/j8pwdeXp2g/4MZj WPN9KblEKGNB6P4D9A4KD+1jkYOtihgazDMwRHKObl68wSn7Bs4w6CBTdeirQ6uMhbGJ wFKIKVSt6TwGtprsJX9804awPCoubKuzbFFaroip+9sPZpMosxTV51eheLIXR7iyiYBI 27ZqrN5iy1Ch4/nKOZA0hxDJbKb65WRaz73xey0xoDw7W7zh6JGFqz3jp18oiXL4u1P1 YaMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=n69Vkdqh1goC+2GONP4oQ4h3UDWq38eakBgozUiwtJY=; b=0X11WEPxD/+F42aCxPGpczJhbm1E6mIQb8C+t0S/pOITph8z+s1ujw1tPRWm50FEti H8Wd29ZGfXKS5wUpxfhoQjX4PQQ90QbwiOXpMnSn3sKTaXYM1ZuAGizJoFes71ePPn+c M7FXLZH5q8NuIGqG8SJU5R2SFUUuuaBGPETKNkAiirDngCJlJ8vA6v3eofFlfKdQbr0h 6f9SIvWa+r+MYiVDhwdGn6VkOosEwhm3+2bLc7UZEf0bniNn454R65KjFghaL68qTJup mnfr1diR86WjZprKOfvqJ53Hr8HxTlwn8sqsfynjvjMWDFuOuysRcubu5mgfNnUE+Umc 0QpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w23si3276589ejn.709.2020.06.19.02.43.50; Fri, 19 Jun 2020 02:44:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731048AbgFSJlt (ORCPT + 99 others); Fri, 19 Jun 2020 05:41:49 -0400 Received: from elvis.franken.de ([193.175.24.41]:37444 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729195AbgFSJlt (ORCPT ); Fri, 19 Jun 2020 05:41:49 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jmDWr-0006aC-00; Fri, 19 Jun 2020 11:41:45 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 2709FC06DA; Fri, 19 Jun 2020 10:37:43 +0200 (CEST) Date: Fri, 19 Jun 2020 10:37:43 +0200 From: Thomas Bogendoerfer To: Andy Shevchenko Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH v1 1/6] mips: Return proper error code from console ->setup() hook Message-ID: <20200619083743.GA6894@alpha.franken.de> References: <20200618164751.56828-1-andriy.shevchenko@linux.intel.com> <20200618164751.56828-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618164751.56828-2-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18, 2020 at 07:47:46PM +0300, Andy Shevchenko wrote: > For unifying console ->setup() handling, which is pure documented, > return error code, rather than non-zero arbitrary number. > > Signed-off-by: Andy Shevchenko > Cc: Thomas Bogendoerfer > --- > arch/mips/fw/arc/arc_con.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]