Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Jun 2020 14:24:29 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Bastien Nocera <hadess@hadess.net>
Cc:     Hans de Goede <hdegoede@redhat.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Richard Dodd <richard.o.dodd@gmail.com>,
        Jonathan Cox <jonathan@jdcox.net>,
        =?iso-8859-1?Q?Thi=E9baud?= Weksteen <tweek@google.com>,
        Nishad Kamdar <nishadkamdar@gmail.com>
Subject: Re: [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT_IGNORE
Message-ID: <20200619122429.GA1037991@kroah.com>
References: <20200618094300.1887727-1-gregkh@linuxfoundation.org>
 <20200618094300.1887727-2-gregkh@linuxfoundation.org>
 <484c84b62140f6536f841e7027ddd9ddcf179a72.camel@hadess.net>
 <62b8ddc4-8d26-1160-6934-fe6a68231938@redhat.com>
 <f57cd2a9a27fb148f0bdfd0ad5e92b4d01ca77c6.camel@hadess.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f57cd2a9a27fb148f0bdfd0ad5e92b4d01ca77c6.camel@hadess.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 19, 2020 at 01:08:53PM +0200, Bastien Nocera wrote:
> On Fri, 2020-06-19 at 12:53 +0200, Hans de Goede wrote:
> > A note for future reference, not sure what you mean with driver
> > 
> > API here. If you mean the in kernel API, the kernel rules are
> > 
> > that we are always free to change that (Linux does not have a
> > 
> > stable driver API).
> > 
> > 
> > 
> > So if a header does not sit under include/uapi (indicating that
> > 
> > it is an userspace API) then a change like this is fine.
> 
> I meant the internal driver API, which might break out-of-tree drivers.

There is no such thing.  Well, there might be, but we don't care and
have to act as if there are no such thing otherwise we would never be
able to change anything :)

> I know that this API is fluid, and that there are no stability
> guarantees, but I'd still expect at least a note in the commit message
> to that effect.

Why?  Who cares?  Anyone who lives outside of the kernel already knows
they have to dig in the kernel if their code breaks, that's the cost of
living outside of the kernel.

thanks,

greg k-h