Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp475388ybt;
        Fri, 19 Jun 2020 06:25:06 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwBNkhNAR3XA3+TQo91Nj6m9wz1svovKMlJF+bVR3JB+1ZAuLaFog3VCse8ANcIT/Wxvrfs
X-Received: by 2002:a17:906:8253:: with SMTP id f19mr3769070ejx.470.1592573106354;
        Fri, 19 Jun 2020 06:25:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1592573106; cv=none;
        d=google.com; s=arc-20160816;
        b=m736oQspduauIZYUe8onxDOmZSASQnw+Z0zr2Khk9COsGsKI93JwDfkP7wrQvdVhVK
         fuvrkig0uFpqbDUtasdSszqyTIDV0ZTAuKU5/5YYDPq/ZExii2LjFmFBxPssNLC5MyR5
         h8vlR9cZ/H97jmtgVL/fChbTtI5ucoYpr31FEjBhFTHYhgLyP7Vc+pyjXA/bYPsp4DeJ
         93vcsKZ18n7VhGoZGl/i8HE6VjvvF2QZ+clU2S/xsxcuGW484GSsw9TiDuCm2QJr0I/j
         GUNjIIvxOn6MjXYDygZHpy63QaA+s0cdBTScPFbrsVkQQQWV1EKEGaev719nRO6gUWS8
         x/KA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=Zm98zvF5j8AfZqZkius+G07hdqS+tdgYDCOmBq/2Xao=;
        b=BEyILJ9T55935yyENFiZFYec4PWW2lwrtK15VyXd5xvbOxxIFvSXTbe4WbsageyVGY
         wL/5lXfQlCGu5LaYi5B6vXHE++eIVqSaBZEdICohO1wEGSB6IznYJWNilkZojRMG/MKx
         beZ0yN6A7GWLOqH/UfbsyBZ3O5ipp6zdG3I9FfEbHRpqdZjnMRJIPpazjMyKinBSSXxo
         qvdB0KFCWBecF33mjfO9AJib4p4KsQUgRAxU5px3W9f9foJD4nu0ly2pHEA97/5tRf4v
         QIoV9Dy1SDzW2+uLJxc8SW8du2jQd+YmVOJx7pP8LJug0K/l/NJfOL57oI2iNZ1+GjFu
         JgiA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mT3EQLiA;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id q17si4147514edg.369.2020.06.19.06.24.43;
        Fri, 19 Jun 2020 06:25:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mT3EQLiA;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730163AbgFSNWD (ORCPT <rfc822;jaegeuk-test@gmail.com>
        + 99 others); Fri, 19 Jun 2020 09:22:03 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40444 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728606AbgFSNWD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 19 Jun 2020 09:22:03 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AE47C06174E;
        Fri, 19 Jun 2020 06:22:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=Zm98zvF5j8AfZqZkius+G07hdqS+tdgYDCOmBq/2Xao=; b=mT3EQLiA63auy9vEBqzzaf7fpB
        F5AqegH9Sbtx1Th0BsEa/weK0kjUDVexFMQ+eUGtmppiyGg0FFB3d0bgxMr1KJju4ANyYjZTkC5L9
        d/Fp3Cz+M4voBpJpu5/T+6+4vRuVX9qOvjZmy5rOOId1LTdA1GdmpuPsNVg3ROhibDKMUtaCIAPRc
        iSwEAAgD17rl03TsO8aME4fVpCFbXN8F69xsZxHmVDfomaoXoKEAQrXc6F8IlnwqXJi2q9bvg0p+f
        mbICSv+7DK9sdk9IP2ukie/PVgj85McV6RrCyL54+mvx8UouolLhJrfBLmFUdJ5m+2riduXZnDmYX
        v8hdE6Kw==;
Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1jmGxv-0001bd-Dp; Fri, 19 Jun 2020 13:21:55 +0000
Date:   Fri, 19 Jun 2020 06:21:55 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Waiman Long <longman@redhat.com>
Cc:     "Darrick J. Wong" <darrick.wong@oracle.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dave Chinner <david@fromorbit.com>, Qian Cai <cai@lca.pw>,
        Eric Sandeen <sandeen@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 2/2] xfs: Fix false positive lockdep warning with
 sb_internal & fs_reclaim
Message-ID: <20200619132155.GA27677@infradead.org>
References: <20200617175310.20912-1-longman@redhat.com>
 <20200617175310.20912-3-longman@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200617175310.20912-3-longman@redhat.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I find it really confusing that we record this in current->flags.
per-thread state makes total sense for not dipping into fs reclaim.
But for annotating something related to memory allocation passing flags
seems a lot more descriptive to me, as it is about particular locks.