Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp571776ybt; Fri, 19 Jun 2020 08:26:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUAB94nmDRwR4CZaKZsi4zB3NCr4fT1l08JMljY9pF7GKfrwu0dWf0CrwZ7Fgy0fCcsP1L X-Received: by 2002:a17:906:fc06:: with SMTP id ov6mr4340522ejb.184.1592580383397; Fri, 19 Jun 2020 08:26:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592580383; cv=none; d=google.com; s=arc-20160816; b=0IEnY/5Bbwo1cvjibfpTyqun/z3xov2cffkexvzW5NJbBJXO8DCFO0FWabx6DVD9Ob 7WKuwN9LePvFEFwIxNLzdSN2OtrfHTPa79mSBJk61hRqO61BL+pMPfo4tGpyxKqe4w4a y4Jk1cIfJHjOkJwEItOpJqGaTihNPFaLeQCyTlXiQVAESinJC9zpE5tZpjI+O86Kj9JB 2taBJ/nRMCBu7x96FTRyUySKF+/a0SVI4uUUqK64aoOeGxmn2oL9ILtB4Yt3jlEMgxM+ YLOwqEeo3hlmDEY4gNEjLzSNM0pRZBEHvsIqLW/YoTsWy5nbiu6mDKWvMSGvQCBkmu6S ykmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P7M3dInGTgetSL9WiBOGvoEM4gmh0xLEQ9Gzi2N+cyg=; b=MyYneR78HotjqjXE9DjC5+owBFOyEC+bmzY5+mBkzOLYaQXtHvk+sI+plkm2slkEUm IlP6VFd8i7x8c5edxSIeu11JFqbMBcPHg65ACuP3einKtlYhIyPbsI+3M7gbi3VBdCJN ZUnij5zoUnJxP1TeDvYtBYfbmO7Gd7LQWjVJVpno80uyu/CPpBCxR1hK4hGSAoMYGxJG djUNAMubSNJ+a95TYnbDbraZDQcV+tca/oyBiCBU+9P2b0lttXl4pvnjNybVonTreVN0 GAv7R8U/UeOdIEBOJXeF/JmNA5funtamoYj9dmE87KmUKIabPdieGTNxsAwlf0yvxA5x V3Qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UNBV8Wwh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si4457926ejj.111.2020.06.19.08.26.01; Fri, 19 Jun 2020 08:26:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UNBV8Wwh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392558AbgFSPVS (ORCPT + 99 others); Fri, 19 Jun 2020 11:21:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:47268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392485AbgFSPQk (ORCPT ); Fri, 19 Jun 2020 11:16:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BBD072080C; Fri, 19 Jun 2020 15:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592579799; bh=DLm3HKqtq7WOPN88gpHMGYl78gKgJxuxjEldkXM1B6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UNBV8Wwh8UXhiQLfhz9YUHfFDrW4xmhJZPBumzuh7usLzy1ySl6UEHpGBFLk+255J lnzavpORwhZmKq+AJB6mX1FQkqm8KzJWmS1AqWTlt5jN3pjbZFarCkiUlLBsaJs9/T L5eg7kruANGh9cbwJx+YQi0WZS1uHqT3GpkOsQc8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ard Biesheuvel , "Rafael J. Wysocki" Subject: [PATCH 5.7 001/376] ACPI: GED: use correct trigger type field in _Exx / _Lxx handling Date: Fri, 19 Jun 2020 16:28:39 +0200 Message-Id: <20200619141710.427881447@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ard Biesheuvel commit e5c399b0bd6490c12c0af2a9eaa9d7cd805d52c9 upstream. Commit ea6f3af4c5e63f69 ("ACPI: GED: add support for _Exx / _Lxx handler methods") added a reference to the 'triggering' field of either the normal or the extended ACPI IRQ resource struct, but inadvertently used the wrong pointer in the latter case. Note that both pointers refer to the same union, and the 'triggering' field appears at the same offset in both struct types, so it currently happens to work by accident. But let's fix it nonetheless Fixes: ea6f3af4c5e63f69 ("ACPI: GED: add support for _Exx / _Lxx handler methods") Signed-off-by: Ard Biesheuvel Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/acpi/evged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/acpi/evged.c +++ b/drivers/acpi/evged.c @@ -94,7 +94,7 @@ static acpi_status acpi_ged_request_inte trigger = p->triggering; } else { gsi = pext->interrupts[0]; - trigger = p->triggering; + trigger = pext->triggering; } irq = r.start;