Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp576965ybt; Fri, 19 Jun 2020 08:32:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwr2Y9uXwLtc1jZrru2rh7MWvjZssDz09U8u3F2LRffwlC4HHUL/HTLqIC7jkd81U+D6xUp X-Received: by 2002:aa7:dc58:: with SMTP id g24mr4131180edu.136.1592580766284; Fri, 19 Jun 2020 08:32:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592580766; cv=none; d=google.com; s=arc-20160816; b=d0TQzpPjEAWtidd/6BYaeqkhfp0Zyq0gWcnkE41atBNF2VML5ps2g8UKDR4zHegnXs 0u9mcJgJVw0jSCBmhBeu16iaAAxmevxPrnTwgLpIMsoSKKljIVyt0KvCUFSTZ26WmtoV 6PAUNAW8f9fRHSrpMw9UhrLuO42dfCR7GLpVKG+4VSOALBIvtEcGzaWq1UyKI00Mab8O 6pzlFWJBH1KaV1Zw59LekqRNh+cXeZ9ZyOn6Ng2eo3Dy0zEV1+3GXDqwCwRFmu/mqQNr jB9S/I97DLfNbvJIbxz0BB5M2MFuHur1wCjjo38HZoslI1BrLsNCxaURq+20tPoCnKAS pShQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fz/sK7qWInm89ru+9e+ytb4IGc9WZMn1NKCnV3KGIZs=; b=l7G3+ZxKn9JfzUVgn2ndQS7mDBO09lSMLeg/njiLl7eNg6cQmYfLsSxtGDWTQbXW6x j5lDLKF5LFV8jluzNGjGrUkblWmo8jUMe5oPgEMUJ9sn23YuEEfQe/XBgVHzXVG1zSkm uGYHgPlq2cwe1maVr5UgzbABB+/6XIqS9miYrDYCdXJAxR3kmaJ8s4ogyrc89JSiAv4P TvqI2ry3MMTn8DwTerCaBC/ob+2PSmAz/WjmdQoV2z/OpMzi99coTk00L4kW3kuYAbja m/Gstcz3XEigaOsunyAl9Skq1Yze8Nqcn8mi18X7puMRoveifcxKOI0bKs3VHcs3WDdh ScSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Q9uNF6tT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dj11si4291427edb.333.2020.06.19.08.32.23; Fri, 19 Jun 2020 08:32:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Q9uNF6tT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404735AbgFSP34 (ORCPT + 99 others); Fri, 19 Jun 2020 11:29:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:33394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404715AbgFSP3p (ORCPT ); Fri, 19 Jun 2020 11:29:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C73F20734; Fri, 19 Jun 2020 15:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580584; bh=Ioc4TzxfqbTd4S5EBzQSWT0oJidXxLmnm7TD9CDAcAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q9uNF6tTZpFJsNtZMdH1lZCQb8FM8wGKNfQRyn49IJWc0twElDSG923V1NxfT3Xcw 5Oi+zj0W+XyQSay6m9rwaE3l56mHd+HVifZ0duzSUL+9ufTmSzM0p9oCpBQDTabn/n bVeqI+LKIYfd6GV4O7TqkNMUf+u/WUADQnUpZB1s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Larry Finger , Kalle Valo , Rui Salvaterra Subject: [PATCH 5.7 305/376] b43: Fix connection problem with WPA3 Date: Fri, 19 Jun 2020 16:33:43 +0200 Message-Id: <20200619141724.775863676@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Larry Finger commit 75d057bda1fbca6ade21378aa45db712e5f7d962 upstream. Since the driver was first introduced into the kernel, it has only handled the ciphers associated with WEP, WPA, and WPA2. It fails with WPA3 even though mac80211 can handle those additional ciphers in software, b43 did not report that it could handle them. By setting MFP_CAPABLE using ieee80211_set_hw(), the problem is fixed. With this change, b43 will handle the ciphers it knows in hardware, and let mac80211 handle the others in software. It is not necessary to use the module parameter NOHWCRYPT to turn hardware encryption off. Although this change essentially eliminates that module parameter, I am choosing to keep it for cases where the hardware is broken, and software encryption is required for all ciphers. Reported-and-tested-by: Rui Salvaterra Signed-off-by: Larry Finger Cc: Stable Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200526155909.5807-2-Larry.Finger@lwfinger.net Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/broadcom/b43/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/broadcom/b43/main.c +++ b/drivers/net/wireless/broadcom/b43/main.c @@ -5569,7 +5569,7 @@ static struct b43_wl *b43_wireless_init( /* fill hw info */ ieee80211_hw_set(hw, RX_INCLUDES_FCS); ieee80211_hw_set(hw, SIGNAL_DBM); - + ieee80211_hw_set(hw, MFP_CAPABLE); hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_AP) | BIT(NL80211_IFTYPE_MESH_POINT) |