Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp578951ybt; Fri, 19 Jun 2020 08:35:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzraWkD0p+U69yyIUGupaWLOzIUpB/2XZKbw1dHNf1slXi7Rzm6EpyZdv9WLMQnQ9q4XCCc X-Received: by 2002:a17:906:2b92:: with SMTP id m18mr4475012ejg.218.1592580908792; Fri, 19 Jun 2020 08:35:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592580908; cv=none; d=google.com; s=arc-20160816; b=l9Lsn2bgYtr6vYgfZuIqNP4fN5HYGvyVG3baRiIcdyrQYiLsdEZwKX1k7k9sWyzLEc tsGERlONOeohKYKPKba4uhv9K79DFWzC0w9BjjSjTNoD82kVc9p40wfKu+22kuoxhGdl VTUzanl17cgplQpCSpu75M4atM090W7IF3BRe4vBJwnpq1WyKI3T2Z0r9IRIBMn9sN6p xNhS6b8Xc5IXh83VKQiazg1dyeOP04Bl2qcZGZPakrEedNA84D4C1fnZeIhTqFHuulEM mDHyGmpXWT2LY3fD+On0JPHDD07amNViw9x9u5gS8NuYRa0GaTwXK19cLlv9pHo2zMDr bPtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Oh/LEjr4Mk4o2X1BgeebJuxK67SVf29jeEeCr08JR0M=; b=OERnh7unoffOe8MlB5AH0zWNhEAOkLNxZlFrTMKvyvw9I7rBfyyhRwxa00Ry8B4+hm EzIswDWmwmWWDNlSBZD6qbqDJD5ZkyfsQhfP1IRqKYk4EfNuCPQYf+YbEl+CZhjb822g hdTa5WAZWFhso5tWwatDPSvh5Fivj7zpkv6QHi/LMRtT/9VOi/QdWFrqsQ0U//JUlBkM 0+C+wtXXksjIM2LesWEdqE09nMMjpopFSxHTVaYfnGAWL5IEDa7PmhRT0Ow45X8I42kz 1mBtbhod8yrKWdNgSgXiAZiWmniPnsaK0tzUr5LYQ5GLeKrqcyych37vOFTSgefniXqh wPHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bs60xdRr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n12si4156735edv.240.2020.06.19.08.34.46; Fri, 19 Jun 2020 08:35:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bs60xdRr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393871AbgFSPcG (ORCPT + 99 others); Fri, 19 Jun 2020 11:32:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:35948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393837AbgFSPb4 (ORCPT ); Fri, 19 Jun 2020 11:31:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EAB3020734; Fri, 19 Jun 2020 15:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580716; bh=nXTV6n7LKEwJ4P48YU2wRCjA/VUb6tyTjEfTta8LoJs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bs60xdRrYpBW3F5umiUFuPOWI0V/6ydN4rDpVaRf3FEVw3UYrir37XfCUTVrmLCsv JKIZMTYbpWRO7M5dPKzKAAAV7U0qi1+MnCqQqq18ASeb695R+fUkocfHkBpaTtj6nV 0RNR6AUwA7jSNKAb2e1xj+jDy/HyiUjk8voo0LkU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal Subject: [PATCH 5.7 356/376] mtd: rawnand: sharpsl: Fix the probe error path Date: Fri, 19 Jun 2020 16:34:34 +0200 Message-Id: <20200619141727.170895339@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miquel Raynal commit 0f44b3275b3798ccb97a2f51ac85871c30d6fbbc upstream. nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no Fixes tag applying here as the use of nand_release() in this driver predates by far the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible. However, pointing this commit as the culprit for backporting purposes makes sense. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-49-miquel.raynal@bootlin.com Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/raw/sharpsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/nand/raw/sharpsl.c +++ b/drivers/mtd/nand/raw/sharpsl.c @@ -183,7 +183,7 @@ static int sharpsl_nand_probe(struct pla return 0; err_add: - nand_release(this); + nand_cleanup(this); err_scan: iounmap(sharpsl->io);