Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp580409ybt; Fri, 19 Jun 2020 08:37:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJL2rRedtZxW9+H9iZZA4cA0MXofjPyi12F8IIUJsxC/LPhi0WSO7Zav7bvUvXDVFeDbdv X-Received: by 2002:a17:906:4406:: with SMTP id x6mr4170934ejo.160.1592581033183; Fri, 19 Jun 2020 08:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592581033; cv=none; d=google.com; s=arc-20160816; b=S2pBo5PKpPuQwcfWEQ92qLKIVyR48Zrjc4YYSVTy+6fFrrTt012ds9oqSRD8cohBt1 QIogt/wADVgSjlbZR4RiXqNI0fPnvyxlCqgO9AwNeRi4Qr8qv7YLlrhBLhUiToWmETUd 1CHC69ZUOmOgPxDImwU7X192wFplLYH2TFG4qC35hSPRXE8BPZAnMpfv5FWGa8B+zeI4 bgEJJrs+O2y7SmAtOvxrdwy/bQblzQQKIIrardNpHOm63PeJZt0XWKGixHGo/DE9U/mY fzycK55NH0AiD+1HoVlM+HmwsGC6gmUYlYev2F4ikUThGp48nDOtTirBa/uFZcgnvi9j DT8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2IkKvReVvDW5ALju/C3qScjZX20PtK51F3XIKxgrplk=; b=w0dFfOholB+PdYAtVhSnf7wq05XyG9qH3sbG+FUluvP6x2hJ1nvrQDqAJYCDr5tbMC qdXHLlW+GarUucT0DNSMr8WlRgnBhvaacWw87fvkSwUH1wu2B87BIVQZsMjgL2326H1y K5jyaO6XlGeEbgD46WLqMD/uYlCXscMrLkiX6RE9fvwy+h9Z2rUZO9XSp86VZSeQCt2U XzeN3IoTpVr6SgwR7CxWXO+hK6UTuxyYgV7Wft7TFdJGAfR30NVuKGtvbSwCbIrNE8xc DJiSQWMXWEqOaslCCRtq0XtPeZIhLDJkna+QIW2sSvSMPOU+LWbl6pbvdHirG8oU3iho ENoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=O7cwfrHu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h32si751796edd.601.2020.06.19.08.36.50; Fri, 19 Jun 2020 08:37:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=O7cwfrHu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404780AbgFSPeF (ORCPT + 99 others); Fri, 19 Jun 2020 11:34:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:37016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404763AbgFSPdA (ORCPT ); Fri, 19 Jun 2020 11:33:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A817C20786; Fri, 19 Jun 2020 15:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580779; bh=52hVFjVhLh2OoAw3LAR/P2MpsdMw6E97K8yE7KBRUrg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O7cwfrHukGXiS+VpD0wZRwG1g+KlR3uxu44kAeKQF8rFpOf31qI0eitsG+yA1UV6v 1AHqy3t7Wpigngwh5hfVE/etWTZNBxUqpFbilYKeil8d9zFJUwgvflTFWV7wbEpurr DKRR/AC4aPgI+DzEfR+LUtowMJdaR8XNyisYl1Lw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Anup Patel , Zong Li , Atish Patra , Palmer Dabbelt Subject: [PATCH 5.7 349/376] RISC-V: Dont mark init section as non-executable Date: Fri, 19 Jun 2020 16:34:27 +0200 Message-Id: <20200619141726.847148265@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anup Patel commit 4e0f9e3a6104261f25b16fcab02fc96f5666ba11 upstream. The head text section (i.e. _start, secondary_start_sbi, etc) and the init section fall under same page table level-1 mapping. Currently, the runtime CPU hotplug is broken because we are marking init section as non-executable which in-turn marks head text section as non-executable. Further investigating other architectures, it seems marking the init section as non-executable is redundant because the init section pages are anyway poisoned and freed. To fix broken runtime CPU hotplug, we simply remove the code marking the init section as non-executable. Fixes: d27c3c90817e ("riscv: add STRICT_KERNEL_RWX support") Cc: stable@vger.kernel.org Signed-off-by: Anup Patel Reviewed-by: Zong Li Reviewed-by: Atish Patra Signed-off-by: Palmer Dabbelt Signed-off-by: Greg Kroah-Hartman --- arch/riscv/mm/init.c | 11 ----------- 1 file changed, 11 deletions(-) --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -479,17 +479,6 @@ static void __init setup_vm_final(void) csr_write(CSR_SATP, PFN_DOWN(__pa_symbol(swapper_pg_dir)) | SATP_MODE); local_flush_tlb_all(); } - -void free_initmem(void) -{ - unsigned long init_begin = (unsigned long)__init_begin; - unsigned long init_end = (unsigned long)__init_end; - - /* Make the region as non-execuatble. */ - set_memory_nx(init_begin, (init_end - init_begin) >> PAGE_SHIFT); - free_initmem_default(POISON_FREE_INITMEM); -} - #else asmlinkage void __init setup_vm(uintptr_t dtb_pa) {