Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp592598ybt; Fri, 19 Jun 2020 08:54:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzWoLqM1JGgyl1dRTumuIaXlHvjRLGn+XIyENkaxxVjkc03nGrIhU0bObw6KaX1TrgcN5r X-Received: by 2002:a50:b0c3:: with SMTP id j61mr4062827edd.349.1592582095535; Fri, 19 Jun 2020 08:54:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592582095; cv=none; d=google.com; s=arc-20160816; b=ct7KxFbe0eJAASK8P727Mn9QH5d7uV+SFdUNxnRDs9Ma5C75OIbtlTkOZt040pHNvh MwNenCrJ6ORy1+p1nsSxHnRTjysN4hqvWU2Ur9j5omTB0riK/g4lIOatV5U1Yk3gm2BW WeBbEtRJxmHWrjjBjonTQNiTu1ILRoaHDP4shPLaj7Wze/ztxKOXHYkcLGb1BlFoTGqH lmcszr75GAz70AGuhFLs8iPlqrJhtPUw/RudKSzKJQmPdky8hX4kDWeqDhJ3Hy+8t0Xg eTaj6pFfl9E2x//4PfEN9yGb035FFXbmIUXfV5y+OLeAAjNf4gk/K4aWVkidBswyiEWz XI7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=zzBeoYkChCcVAStYW7riry6t3ZsDx2Q3uCHI24rM2Uw=; b=mrlnj9jCAxP1wJGiaNCUWYfBREotR91rlGU18TjyBJXvXqyAunHtka7x8usC331hZs jdxtut1oqX10I1DCqqVXp7AJh5lfbhOzqEXFNOZUqpI6RSYh2TtzcpowZC24ruZPtm5b JxGaUUY5UnK4jTjqHTYHMGIOXkI/TsHOilCRGLlLsiZKUK6kcPTYJ3jFGVmgVIf+IJXD 8hSlLkflNKBLFL88C+T46R7H1xQgR6i3etdJix64rDyse1rMjxYuRxcRhg8XTP/Kv0BZ mcT9IWygFB0U8REsYcRE2ry4ukGGtteKmP1VtH5k0NbW0pLa5zDZBPBGM6QdWT8Tknkm ZG6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=nnSCFoxY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si4037041eju.480.2020.06.19.08.54.32; Fri, 19 Jun 2020 08:54:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=nnSCFoxY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405340AbgFSPwC (ORCPT + 99 others); Fri, 19 Jun 2020 11:52:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393187AbgFSPXa (ORCPT ); Fri, 19 Jun 2020 11:23:30 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33559C06174E for ; Fri, 19 Jun 2020 08:23:30 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id p3so1934448pgh.3 for ; Fri, 19 Jun 2020 08:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zzBeoYkChCcVAStYW7riry6t3ZsDx2Q3uCHI24rM2Uw=; b=nnSCFoxYQ6AUSpPl6es7No4L1LX1qK6aUh3FwEFvx+WeSsOtxLwXhsHLAvFM6kig2O SV245MBqVFTqZWl4g3U9QzuwU+oxj1v4jxKS4r1RDH+Qe5p83thMMXeebnx9oe8xnYCb JB2UmXJ3oVZgULEcF+krwdSlyupQk5jtNrhcK6Nc+joMLRC6xJKI75lYwqECAxKxnoXM f3tq2NmFzCnozoFNNfLnQJAFoM3fuj8Btgjq+HaI7KEw09q7MV5+F0nuwFqYDD6r1fbJ WE53xOFEsZNg8/DJUR3WUCPMVi4E5ZjdMjRveodE4idwaRFNR5TaFOFR+50U7OAgJ0Mo 1E0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zzBeoYkChCcVAStYW7riry6t3ZsDx2Q3uCHI24rM2Uw=; b=p5gjV4rTuL54yi3p1PxxpcZKbGiZ5PwgCazb2SPzzx5suOUpyuaiAGzD033FvbyrFI xW2ebLJBdCtAbrI4z1Hgua33Nr7EDijco+BkISFeazhPN5F7hC+MnzhkYjr5MvT/p4U4 0AmJTxw6sO5pJSoHrtny4y4QSUD4Sz0sw5ZWoylkWzHFM7qiSusf6Th9+LQG4PhSgffm EEAbZl2JdQQO6JP/D1rE6yPqoSHXvsUJnJEqeFbWvJNG4hNYQzPSvmd0qkyRqFvQ6EjZ DPWekpzmhN9JyO43GN3yx3aY/G4nnfnlzuvEmdOm9V7os5tRlo+8fYB9tPdfom9W83Kl zhIA== X-Gm-Message-State: AOAM5322iuEhyGnDUb4kaDszod0pDT2MIZ5zCtmqS0qdGwJRTxuEm6CF eC2CWcpRt/YyXBiGzRwNG87AZA== X-Received: by 2002:a63:525a:: with SMTP id s26mr1423522pgl.155.1592580209702; Fri, 19 Jun 2020 08:23:29 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id a8sm2864224pga.64.2020.06.19.08.23.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2020 08:23:29 -0700 (PDT) Subject: Re: [PATCH 3/3] io_uring: add support for zone-append To: Alexey Dobriyan Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, javier.gonz@samsung.com, linux-aio@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20200619152208.GA62406@localhost.localdomain> From: Jens Axboe Message-ID: Date: Fri, 19 Jun 2020 09:23:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200619152208.GA62406@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/19/20 9:22 AM, Alexey Dobriyan wrote: >> uint64_t val = cqe->res; // assuming non-error here >> >> if (cqe->flags & IORING_CQE_F_ZONE_FOO) >> val |= (cqe->flags >> 16) << 32ULL; > > Jens, ULL in shift doesn't do anything for widening the result. > You need > > val |= (uint64_t)(cqe->flags >> 16) << 32; You're right of course, guess I should check my in-mail code a bit better :-) -- Jens Axboe