Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp594146ybt; Fri, 19 Jun 2020 08:57:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzdPUq0dsdez830wHL13fsWIh6sp8aJj6/lrpvE5Ktm6zs93cNABa5+nOPTIGJtd4MLyji X-Received: by 2002:a05:6402:22e4:: with SMTP id dn4mr4072352edb.288.1592582234723; Fri, 19 Jun 2020 08:57:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592582234; cv=none; d=google.com; s=arc-20160816; b=LVwcgPXtjaU2pN36BCBiPrnPn8xwaaozzdQ24+hXOE+9OqnK3dVvv+Ff+uwIYy/AEL AyxghKPZFyZOeX7A+x446p9PvyOGLgOVEYEbKPtT+blBDgeoRrXvsf4aeHEgNq9N2XCI NYndTbQAJTpTB/DJdOXLKiZNPVZ5KOq9mwqJ/N6lbIjR4fPIAAymazN1TRTdv5NzZj+y 0kNFPWmHdnW8AlOG0dLOdFCuaj8aYe9YHKiM6CMaBByd7cDrIP8YbW9wLsTsnay8vOJ/ GHwFwqv8HyfCmxHy740jmGhZNrMjA+kT6iTnzyXxbM4dt639LvjbjRecJTpHOyAoZu/n FAVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mbucmHr3bPeeJ8mDw8HjEklqucqK5d7WJWF25Gg7WRI=; b=ghdO4oXXHO/ZblKzhNJSxyx6sevjjkCs4tYdjs69ZcNCL8eAKpYkeRgoo3muV1MEZD YDXa8yRL/zrZuNoF9CWU4HV8hdtsxCdHSjD7/2weS3+PPy4k6Q1yQRtFDqNsSKKnAcj9 kYoEK5+vI6/kSf6BGITzv+7rq6PhFzQ3GyKl6RtDh87RyR8cRFsJd1gfQC2WzQnGkyKn iqCOGFou9evBlQA5sh4F4AXBLO1LEBHY002AHZupZt7WM+SYhJ4Fe+ssrvBOV+D9Jwuo mFiEoEnoaEQstQw+hCwFh+fjLY/1NhYCeuHayTDDW6VkiGOZkqr8AvB9TnKSJ43qtYei Y8rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QAPQ0sen; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh23si3931902ejb.351.2020.06.19.08.56.51; Fri, 19 Jun 2020 08:57:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QAPQ0sen; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391965AbgFSPyB (ORCPT + 99 others); Fri, 19 Jun 2020 11:54:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:53398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392943AbgFSPWD (ORCPT ); Fri, 19 Jun 2020 11:22:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA55920B80; Fri, 19 Jun 2020 15:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580122; bh=SWWGoQsVVAyjX/AN81bixPfF8lDzZ/UMYuq0YgzmvUs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QAPQ0senfd3k1MlMvgoUxFJJIit0iDF7vZHmexCYQDPzMyfA1FI0pguWzftEyVav9 wMlA+YU01cgAhSHcXmT1fio3FD2qWz3lP2xpgCjE3zfIP+l13FTBG88hc0nprN6Eio RUTPc5KD/clqMdTM2I0CAA5gKFF011MNvN/CHjFE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christoph Hellwig , Jens Axboe , Sasha Levin Subject: [PATCH 5.7 113/376] bcache: remove a duplicate ->make_request_fn assignment Date: Fri, 19 Jun 2020 16:30:31 +0200 Message-Id: <20200619141715.697548215@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig [ Upstream commit a91b2014fc31dc6eaa02ca33aa3b4d1b6e4a0207 ] The make_request_fn pointer should only be assigned by blk_alloc_queue. Fix a left over manual initialization. Fixes: ff27668ce809 ("bcache: pass the make_request methods to blk_queue_make_request") Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/md/bcache/request.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index 71a90fbec314..77d1a2697517 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1372,7 +1372,6 @@ void bch_flash_dev_request_init(struct bcache_device *d) { struct gendisk *g = d->disk; - g->queue->make_request_fn = flash_dev_make_request; g->queue->backing_dev_info->congested_fn = flash_dev_congested; d->cache_miss = flash_dev_cache_miss; d->ioctl = flash_dev_ioctl; -- 2.25.1