Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp595681ybt; Fri, 19 Jun 2020 08:59:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJ/PV451muvhqp1NXXjR0lD2UynggYTeVAFvVWEerX3tkZjB07dD9j2jFzkWkgC7GswZCy X-Received: by 2002:a05:6402:144e:: with SMTP id d14mr3990057edx.14.1592582378902; Fri, 19 Jun 2020 08:59:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592582378; cv=none; d=google.com; s=arc-20160816; b=aU9oLUL9I+y/IlnJxOJPtRlhQhwZzdCGxJ3sQnJDg9/87NxrkY0bFo39ZL32b5ru8J nVYb+E8baoMytBow6D8zSKxvtm3uAK19MtbYMxHMrGOHQMygFemA3Z+hAKUAmbb6TAwj 6gMrqRQEIknRfK3sqWe5jo4iejlcccwzblo9PaFSFkpjMKLcEzNnGknxTU0qzlOk6dUG Y7SpBLu5PNds8Q438Mo0nsS+Z+K3VKjy10PxYI9rCnmRiGQjm0eCYf7kOg3gCg8RVALa KogX+lidR85dNuymuJs4TNEoW8LMJ3q8R0G+W941IsKDhwJyOfr2ewyS0J6bdoTKugOU sLMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GMjzJef1QVu6fPYWLL2XoMzkjzuuruPjmVxM7o3dCy8=; b=LmEVXDnfZt4mb/3wuYnQDo2pETQXoZ5x+Iu6rtM6kyfDCvW5mlLH1jm69CfDSgSpCS /rqUmAyChDTUFSXOCvEFbL1ws/WooqhW+9yfLr3PjXBdW6lQ3+zOnTSuy+nEFkW/oDch cUbXA52O0MifhryoT3x3Bh4/z8BhsL6hH6nEsiX5l51k8WHcEzR+jTRCIsHfs3o7QS20 8oH3poAEkLK+mksaKk0lgXWHpc+g1zuuiXlUAK21952bYeSAVY0TFeFnw5MpmwtZlv+A slpMvcidHyDIp1a2bBnnw+s5XKYENTIoyBbtPVEoJs/Xfr10IZkfi4f+7A81dsIjygnM +BwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z01ZnaLc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cz28si3874311edb.384.2020.06.19.08.59.16; Fri, 19 Jun 2020 08:59:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z01ZnaLc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392963AbgFSPy1 (ORCPT + 99 others); Fri, 19 Jun 2020 11:54:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:53226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392920AbgFSPVy (ORCPT ); Fri, 19 Jun 2020 11:21:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7917A21548; Fri, 19 Jun 2020 15:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580114; bh=Hun363eN4I4GDgnv/6/COhdFYcOMePNwa8J/7LCfEME=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z01ZnaLczavRMRhRgmf3O2hXvvmhQJ3fD3QOUfbt12VjVJ55nfEilTk5S8uVvSmC4 DdnvjPY3qzeeGi/t4Dw8sOzyVyDzBMbD8lFLFUcaBhRfCBQuOQrJj+L2iZ15Ez/+gf 3AZjczJIH3e6SgGceIuqyjhqZw1b1cSN1fHVDoG8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, coverity-bot , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.7 128/376] media: m88ds3103: error in set_frontend is swallowed and not reported Date: Fri, 19 Jun 2020 16:30:46 +0200 Message-Id: <20200619141716.394867701@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Young [ Upstream commit c4ed27cfed45c16c2dd16c9fa3b883e306177e40 ] Bail out if registers can not be updated. Addresses-Coverity-ID: 1461655 ("Code maintainability issues") Reported-by: coverity-bot Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod") Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/m88ds3103.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c index d2c28dcf6b42..abddab02db9e 100644 --- a/drivers/media/dvb-frontends/m88ds3103.c +++ b/drivers/media/dvb-frontends/m88ds3103.c @@ -980,6 +980,8 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe) goto err; ret = m88ds3103_update_bits(dev, 0xc9, 0x08, 0x08); + if (ret) + goto err; } dev_dbg(&client->dev, "carrier offset=%d\n", -- 2.25.1