Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Jun 2020 20:16:03 +0530
User-Agent: K-9 Mail for Android
In-Reply-To: <20200616184805.k7eowfhdevasqite@e107158-lin.cambridge.arm.com>
References: <20200213091427.13435-1-manivannan.sadhasivam@linaro.org> <20200213091427.13435-2-manivannan.sadhasivam@linaro.org> <20200616184805.k7eowfhdevasqite@e107158-lin.cambridge.arm.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from userspace
To:     Qais Yousef <qais.yousef@arm.com>
CC:     davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Message-ID: <9184F012-1FDC-4F6B-8B3E-5D2B87F5DACA@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,=20

On 17 June 2020 12:18:06 AM IST, Qais Yousef <qais=2Eyousef@arm=2Ecom> wro=
te:
>Hi Manivannan, David
>
>On 02/13/20 14:44, Manivannan Sadhasivam wrote:
>
>[=2E=2E=2E]
>
>> +	trace_printk("advertising new server [%d:%x]@[%d:%d]\n",
>> +		     srv->service, srv->instance, srv->node, srv->port);
>
>I can't tell exactly from the discussion whether this is the version
>that got
>merged into 5=2E7 or not, but it does match the commit message=2E
>

This got merged and there was a follow up patch to replace trace_printk() =
with tracepoints got merged as well=2E=20

Thanks,=20
Mani

>This patch introduces several trace_printk() which AFAIK is intended
>for
>debugging only and shouldn't make it into mainline kernels=2E
>
>It causes this big message to be printed to the log too
>
>[    0=2E000000]
>**********************************************************
>[    0=2E000000] **   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE =
=20
>**
>[    0=2E000000] **                                                    =
=20
>**
>[    0=2E000000] ** trace_printk() being used=2E Allocating extra memory=
=2E=20
>**
>[    0=2E000000] **                                                    =
=20
>**
>[    0=2E000000] ** This means that this is a DEBUG kernel and it is   =
=20
>**
>[    0=2E000000] ** unsafe for production use=2E                         =
=20
>**
>[    0=2E000000] **                                                    =
=20
>**
>[    0=2E000000] ** If you see this message and you are not debugging  =
=20
>**
>[    0=2E000000] ** the kernel, report this immediately to your vendor!=
=20
>**
>[    0=2E000000] **                                                    =
=20
>**
>[    0=2E000000] **   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE =
=20
>**
>[    0=2E000000]
>**********************************************************
>
>Shouldn't this be replaced with one of pr_*() variants instead?
>
>Thanks
>
>--
>Qais Yousef

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E