Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp631403ybt; Fri, 19 Jun 2020 09:45:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwBacUfKXjYXjhJAT7rjLZQA4JGJxgYFm/sbtGHa2EgFJ1ZM80fLJ9R0tL4bqZ6ayUqtJB X-Received: by 2002:a50:ee8f:: with SMTP id f15mr4295353edr.168.1592585155463; Fri, 19 Jun 2020 09:45:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592585155; cv=none; d=google.com; s=arc-20160816; b=zn9sIx76KgtVz9OJi9gWuNbtZJgSxqjfr6PC8QeJUuuV8dh1CTbR7NOgH+8DjiFmvY ovCHhkMFp66088OSD7MfPXsbw4eLshR8BLFNutqVvDE11tl0FPi/bU/tWKmfFmj2wChV C5f7X2lyG6MD/podiccGSCoF0XlzZO2plQGdb9477DZWng5R0sG5sw9HTCxc/izf2T4H /Lg2xk/no2/S7tSGZspfDZNdfttqB7uiMUStP+u9srteiKWDhlXQSIAApjTeQAbxPxYo 2xKOP3xsj0QY0M5kqhvtGWW6Y0irrD2s9yAva/fXGFeoroVHklF6M2VB3ouS5OTToxtz X3Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=TX1k7btWtjWNIGMhEFuIjcyrQs5p1DpinYITZyYYBkI=; b=pwzL0jUkr9f6FBRSs00SdzW4KHPAeZBNLSso0IDgAz769BQ4tDVBrTzSpLcKGtQiLA v+YBI0IhSPAm6E9hwsDpAgGw5vyW9zaJCod7pfozUq12vQuyp8zDShFOqpSS3YbdxgD9 F2o9plMdkueQJBEoTKgv4DXyxvKOPcTv2/LSE7tzHSrwo/W7TiO56V8xz9D9Tm0OtNiw 9ADqwGKUB/yGL2wxo5aczDkfH85U4vzqU82IJZJAtPhfYovsqWaiCAZ6zel7QTgXBXQR gEM7b7mSJ53i4khLxCTfBYPM44pKdrWcUACVYuJNzIqnOy3mrTIBPTFkfq0l983ke9AK bgaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h21si4285748ejb.679.2020.06.19.09.45.33; Fri, 19 Jun 2020 09:45:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395533AbgFSQms (ORCPT + 99 others); Fri, 19 Jun 2020 12:42:48 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:60866 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387672AbgFSQmp (ORCPT ); Fri, 19 Jun 2020 12:42:45 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sre) with ESMTPSA id C0CE72A163A Received: by earth.universe (Postfix, from userid 1000) id 86D403C08CD; Fri, 19 Jun 2020 18:42:41 +0200 (CEST) Date: Fri, 19 Jun 2020 18:42:41 +0200 From: Sebastian Reichel To: Marek Szyprowski Cc: Emil Velikov , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCHv2 0/2] SBS battery PEC support Message-ID: <20200619164241.yuwiflgopyqocux6@earth.universe> References: <20200605230625.192427-1-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mq7fdbym2zztfgad" Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mq7fdbym2zztfgad Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jun 08, 2020 at 08:23:05AM +0200, Marek Szyprowski wrote: > Hi Sebastian, >=20 > On 06.06.2020 01:06, Sebastian Reichel wrote: > > Second try to enable PEC for SBS battery. Mainline currently > > has 3 different platforms using sbs-battery with an I2C driver > > not implementing I2C_M_RECV_LEN: > > > > * i2c-exynos5 > > * i2c-rk3x > > * i2c-tegra > > > > On those platforms PEC will be temporarly disabled for SBS > > functions requesting strings. I considered moving the emulation > > to I2C core, but it's specific to the SBS battery. The hack > > only works because the strings are constant. >=20 > Thanks for the update. Works fine on Samsung Exynos-based Chromebooks:=20 > Snow, Peach-Pit and Peach-Pi. >=20 > Tested-by: Marek Szyprowski Thanks, queued. -- Sebastian > > Changes since PATCHv1: > > * dropped all applied changes > > * rebased on top of power-supply's for-next branch > > * keep existing string reading method as fallback > > > > -- Sebastian > > > > Sebastian Reichel (2): > > power: supply: sbs-battery: use i2c_smbus_read_block_data() > > power: supply: sbs-battery: add PEC support" > > > > drivers/power/supply/sbs-battery.c | 89 +++++++++++++++++++++++++++++- > > 1 file changed, 87 insertions(+), 2 deletions(-) --mq7fdbym2zztfgad Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl7s6vQACgkQ2O7X88g7 +pps2BAAjWxgPSAyRL5qwOniGJbTCLlaIKJBJMivyNAxhw8TNK6tl8qDXa9KFDlW TJ+U62PfqoPid1zXwnqao3HXm6ppaE3G0aiy1SqtTsHDcLFvlQiwRB7XgHAXYyol 5iYLbCrSv097WgeoqOMPAWiV0yXVDG7euZvxfONVpP6MfxoUy4Ddih70oxwYqt8m J1IKIVWTm6MgPMYjvqknEMgN317232Er+X27xSlzDwDgZFiiQVv8YzZCok3X97Wf ZfmgLZIgIVDc0CK+jMqnonw8bfuJO3K9vPA3FWnvIEEjoqIvt+9okTD5N1Uh4cVC PG1orCBUHqbytdkWa+eFI6YOZXvDGutu9L7yC1LYJ/nZlGzMZHLPZVh5bNwR7/Oz 78sqpIdrFgOM5SExbMSmg1qUq2vdgDs+k5m5ED1NyQAQLx5ci0Mqhbx4CHTCB/C9 AMdveLwaEFiA9Q16jpJ/SD9Hz5XxGOMtB8fE0FVS9cSPGr3cFSDyx/siavGAg2+b P6vph31EjXAGd9sgQVYkopCcgayAB82onY7+LljZN9+6vwP7mdeFiYF0UaXgrQXy S0uHPXToc0Dd2q5UWM1rUbuNJmwEByWwLE8Ae5hdufg3UU/y61WEHYTPL4q7TL85 boemBk+UZuGk3dJVull1n80ADdPdzl0nC4aDzlROvj5YVO2Rp4k= =AGyu -----END PGP SIGNATURE----- --mq7fdbym2zztfgad--