Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp633605ybt; Fri, 19 Jun 2020 09:48:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcL6S5P6xOQcYAqJDbReZSINsdX8eYK7gCIObQMSL1Q6qSwreOG8NLiiFUJKwcc+HdFZdm X-Received: by 2002:a17:907:20ed:: with SMTP id rh13mr4716008ejb.135.1592585322849; Fri, 19 Jun 2020 09:48:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592585322; cv=none; d=google.com; s=arc-20160816; b=q/EzxM5rBqwuyEZpQiF+v+6qpiGK25zJqhsjdEgzwEUO9oUgGhU8wcVdzVFSBfpgqn n3O37sxxG6WBbs7nlWt9lbl2AmWGF9BBUpiif4pL7nd7Tc2YXn2zbOkeN2dIkl+cWA5o J/0wkl+vWF0y2GXTyMD+H5kiTZJariZ99vMv9GK9qgBCmiqUie7E2ldz98JQzo66Y5DZ dDARIUDXdgDYluk2XH1LdNvrwYby8/2cpjAtXEBv+eP5e4sb40hKVEp6CT7f9adcDCPK Jzczy8e3pRMtjtTO2OHZSLrg/pFuxKGVtL3IQyc+uBrhJ1cMS64Rubj1Wr1w+mppqaP5 UXRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VqFtq+oWZPOAN7ftBh1rO2YB8yEyMudB6Yl4hFciH3w=; b=kRJ+wMNqQza7G40IIzgRIcQhp0Xu2+hhK8QApgSSnXXrUnedPObgjTtLp61ImJO1Sg CJ51HQ19/TCeco0FTL+8Y+SgLRJe6usky1SKU28s1N2yPNcywaddXGft3OWI+B523X3p zYwy8F47YU4C8/UBUr1gQqIiMxxNvAbAwXEAZI2I4MVK1qEM2nETC7ZSzSj+CHI24oIc MQr59zZFOEOfZUa/wo/I0g7IOMQCpY1fu30pXHcZ64AqR038Z8GdAvCy7d9cYJGqdJQp KJKSRaNNjQGLVnFO/AYWwF1sS6nsHU4KdB1DhX3U29SiZ4R+adf8+v9SEay4MU8fzTp0 XvoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dqub5D9q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y5si4196435ejc.674.2020.06.19.09.48.20; Fri, 19 Jun 2020 09:48:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dqub5D9q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388299AbgFSOlu (ORCPT + 99 others); Fri, 19 Jun 2020 10:41:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:60492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388285AbgFSOlp (ORCPT ); Fri, 19 Jun 2020 10:41:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE42221527; Fri, 19 Jun 2020 14:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592577705; bh=kZ2JT7pJzNcsSRPkYpNNMCMcIXuq+V0mJeRqmsklpBE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dqub5D9qZEB4hjtAjYwlLPvR0UlCbJh2+Ux/fQC0HtmlIYBYpmpg3/ZnYduQhYOc3 5bpGJTDEoVORWTK/Lvb+tK/4l57BcVuDNOMPonbyq/JUrevg8Wri1wV1TSz9kjA+Qh l6binWh8uY5q5OAbX6kepUkBT8k1cbYoLNHIgEj8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ard Biesheuvel , "Rafael J. Wysocki" Subject: [PATCH 4.9 054/128] ACPI: GED: use correct trigger type field in _Exx / _Lxx handling Date: Fri, 19 Jun 2020 16:32:28 +0200 Message-Id: <20200619141623.060188065@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141620.148019466@linuxfoundation.org> References: <20200619141620.148019466@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ard Biesheuvel commit e5c399b0bd6490c12c0af2a9eaa9d7cd805d52c9 upstream. Commit ea6f3af4c5e63f69 ("ACPI: GED: add support for _Exx / _Lxx handler methods") added a reference to the 'triggering' field of either the normal or the extended ACPI IRQ resource struct, but inadvertently used the wrong pointer in the latter case. Note that both pointers refer to the same union, and the 'triggering' field appears at the same offset in both struct types, so it currently happens to work by accident. But let's fix it nonetheless Fixes: ea6f3af4c5e63f69 ("ACPI: GED: add support for _Exx / _Lxx handler methods") Signed-off-by: Ard Biesheuvel Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/acpi/evged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/acpi/evged.c +++ b/drivers/acpi/evged.c @@ -97,7 +97,7 @@ static acpi_status acpi_ged_request_inte trigger = p->triggering; } else { gsi = pext->interrupts[0]; - trigger = p->triggering; + trigger = pext->triggering; } irq = r.start;