Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp700437ybt; Fri, 19 Jun 2020 11:24:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyX0IU//eYo7hvZAdKVfKrHptytzvf/cyzce/qMYPdfAqaHdUvhZpwoqffPyG/nVtBF5i+U X-Received: by 2002:aa7:c752:: with SMTP id c18mr4524131eds.55.1592591097559; Fri, 19 Jun 2020 11:24:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592591097; cv=none; d=google.com; s=arc-20160816; b=BYMyjp3iFtpj5KEut1E4waggwPtbGNtxYYXkKpfevQ6V4gew1Dryx/joxFHD+ldsoa daTJxlDZbshMzgQPEUC+FTxuqjJ1SKGfaWxLhQ6L8CP+dLKIVSK8ZzyhZN3Ux0FJqWD8 srD1h4+pSrtjsIUCzRvDVe51WDwd9pJnZ1W/hug16c1IzMzhDeZy7ReOF9Q7s1+u0OlU itLQe1N04X2mF+TqaXRxt9R+1IS4KZhFh0LikU3svW1nd8YYzQqJLzL6uFG0+ednWIgA u2vIUHpQmlO67tnxX1fBERyA7H/022Gt2GjxWneinFcjC50hKkv6Ujhly5j/RPQU208t uS7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=+rBhCFgGCMdVAfWKM4PW53kmT786Xr6XtnAv8uvw9zw=; b=gOQOeTZJ3xlS6mtJsDFDUF4N2EWq/cGzbzBeZbApB/k1XGd2Q2vzsv109eb9O0Rm1S 3ZWymTLCl7fC2RPK0QYvIxufnatI9jr5eQiBR8wXJXnSH98lXhAivV6SLoPXzl5xE/Qn r9NQcLZ3plujYok89p+4P0yC6gwPyofDV/inzzDnqe+Jgq8K3jRJCq0SwWfvzSJIK2vo OaQcMPRGgzhLEmmFmhofmtgqAcCk6bUJFBFsbg/ubJxLTfOl74OOlAkTHOwwI0NWUP2M 6Jod0O6JP0IbCA0Bl4kcbKQF95M2loVRR1R6kRulrxLmCQXQw2ZoQ/DNbCJMPhGnDBfw 6b+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=eRce76G6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n19si4241233ejb.704.2020.06.19.11.24.34; Fri, 19 Jun 2020 11:24:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=eRce76G6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731828AbgFSMOg (ORCPT + 99 others); Fri, 19 Jun 2020 08:14:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727074AbgFSMOb (ORCPT ); Fri, 19 Jun 2020 08:14:31 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CAC4C06174E; Fri, 19 Jun 2020 05:14:29 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id q11so9486794wrp.3; Fri, 19 Jun 2020 05:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+rBhCFgGCMdVAfWKM4PW53kmT786Xr6XtnAv8uvw9zw=; b=eRce76G6vjbDkG32qBLsbDtV5RaN2z73qkS/xZtt/XKQ4wvEky0RLCo6sUHibH3kx4 6/K6WpP5JRvj9xgg/zpp4vVlMsPXNovf2iJEptZU63TCIeHAxG+bSc4eifGBwrl6Qeu/ JoEtKdoazeFs+B2iscDACPJYYMS+ZA9QBDDb3FQ0CIGYvLKZnkLaDopCAX2MsqG4uYJ9 z6Nx8NEodajlkoqJrsxYQo5L7qn3tNXDNu1GDNoMpzxMxkDlBICDwwiIJxN961r35a4c IbLlPH7K7/Wem++MyTOxHUocH7ZO8y1S4MA8Fof9z5XG49Sfb/+Wn+cWX7wFBtkFHlky xBcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=+rBhCFgGCMdVAfWKM4PW53kmT786Xr6XtnAv8uvw9zw=; b=TkS2+84iLsXXTd6LvS2SES983ZKJOU/FnLrNdx9EGSGdEKBKZYOlbyOgZo6j9fPNc6 rQBp7Kj/yoBzICaWPcuKe97SK3v8xModK3CO64PIMvAX1X0UuHPmVmsBZO4K8qYXkJFS 4uM79FWpDsmSSQO6KHWt9QPxKYULJYtP3QiPEzmH6aTYsOndD5iV+EIj8sydsRy71/7j fQJoGZfuTnggGPg7lLJRMOCiMgoFp7clPC4Dw8DJJJ6ZSSYPv/govLTAYmc2QrGmf13z TOjkBom0VJuhpGq6s0FkpQreMQ6RwMX4LQVlxMR0CxsAPjysaerDu8MKXEs/jctSOxSX Re2A== X-Gm-Message-State: AOAM530b/csQLydqclKVSqHrt3RxbFru6dk76Vek/DES9EUoaqKNvh8o 62kz6fnwsIG5Yz41n0LWXfE= X-Received: by 2002:a5d:4d4d:: with SMTP id a13mr3881692wru.252.1592568868130; Fri, 19 Jun 2020 05:14:28 -0700 (PDT) Received: from [192.168.10.150] ([93.56.170.5]) by smtp.googlemail.com with ESMTPSA id f185sm6951462wmf.43.2020.06.19.05.14.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2020 05:14:27 -0700 (PDT) Subject: Re: [RFC PATCH] KVM: x86: Fix APIC page invalidation race To: Xinlong Lin , Eiichi Tsukata Cc: "sean.j.christopherson" , vkuznets , wanpengli , jmattson , joro , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , kvm , linux-kernel , Felipe Franciosi , "rkrcmar@redhat.com" , Andrea Arcangeli References: <20200606042627.61070-1-eiichi.tsukata@nutanix.com> <0d9b3313-5d4c-9ef3-63e4-ba08ddbbe7a1@redhat.com> <7B9024C7-98D0-4940-91AE-40BCDE555C8F@nutanix.com> <6d2d2faf-116f-8c71-fda2-3fc052952dee@redhat.com> <202006191317431160122@wangsu.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= mQHhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAbQj UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT6JAg0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSS5AQ0EVEJxcwEIAK+nUrsUz3aP2aBjIrX3a1+C+39R nctpNIPcJjFJ/8WafRiwcEuLjbvJ/4kyM6K7pWUIQftl1P8Woxwb5nqL7zEFHh5I+hKS3haO 5pgco//V0tWBGMKinjqntpd4U4Dl299dMBZ4rRbPvmI8rr63sCENxTnHhTECyHdGFpqSzWzy 97rH68uqMpxbUeggVwYkYihZNd8xt1+lf7GWYNEO/QV8ar/qbRPG6PEfiPPHQd/sldGYavmd //o6TQLSJsvJyJDt7KxulnNT8Q2X/OdEuVQsRT5glLaSAeVAABcLAEnNgmCIGkX7TnQF8a6w gHGrZIR9ZCoKvDxAr7RP6mPeS9sAEQEAAYkDEgQYAQIACQUCVEJxcwIbAgEpCRB+FRAMzTZp scBdIAQZAQIABgUCVEJxcwAKCRC/+9JfeMeug/SlCACl7QjRnwHo/VzENWD9G2VpUOd9eRnS DZGQmPo6Mp3Wy8vL7snGFBfRseT9BevXBSkxvtOnUUV2YbyLmolAODqUGzUI8ViF339poOYN i6Ffek0E19IMQ5+CilqJJ2d5ZvRfaq70LA/Ly9jmIwwX4auvXrWl99/2wCkqnWZI+PAepkcX JRD4KY2fsvRi64/aoQmcxTiyyR7q3/52Sqd4EdMfj0niYJV0Xb9nt8G57Dp9v3Ox5JeWZKXS krFqy1qyEIypIrqcMbtXM7LSmiQ8aJRM4ZHYbvgjChJKR4PsKNQZQlMWGUJO4nVFSkrixc9R Z49uIqQK3b3ENB1QkcdMg9cxsB0Onih8zR+Wp1uDZXnz1ekto+EivLQLqvTjCCwLxxJafwKI bqhQ+hGR9jF34EFur5eWt9jJGloEPVv0GgQflQaE+rRGe+3f5ZDgRe5Y/EJVNhBhKcafcbP8 MzmLRh3UDnYDwaeguYmxuSlMdjFL96YfhRBXs8tUw6SO9jtCgBvoOIBDCxxAJjShY4KIvEpK b2hSNr8KxzelKKlSXMtB1bbHbQxiQcerAipYiChUHq1raFc3V0eOyCXK205rLtknJHhM5pfG 6taABGAMvJgm/MrVILIxvBuERj1FRgcgoXtiBmLEJSb7akcrRlqe3MoPTntSTNvNzAJmfWhd SvP0G1WDLolqvX0OtKMppI91AWVu72f1kolJg43wbaKpRJg1GMkKEI3H+jrrlTBrNl/8e20m TElPRDKzPiowmXeZqFSS1A6Azv0TJoo9as+lWF+P4zCXt40+Zhh5hdHO38EV7vFAVG3iuay6 7ToF8Uy7tgc3mdH98WQSmHcn/H5PFYk3xTP3KHB7b0FZPdFPQXBZb9+tJeZBi9gMqcjMch+Y R8dmTcQRQX14bm5nXlBF7VpSOPZMR392LY7wzAvRdhz7aeIUkdO7VelaspFk2nT7wOj1Y6uL nRxQlLkBDQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAemVv9Yfn2PbDIbxXqLff7o yVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CRwkMHtOmzQiQ2tSLjKh/c HeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuffAb589AJW50kkQK9VD/9 QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v028TVAaYbIhxvDY0hUQE4r 8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQzCYHXAzwnGi8WU9iuE1P 0wARAQABiQHzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EOoJy0uZggJm7gZKeJ7iUp eX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBTuiJ0bfo55SWsUNN+c9hh IX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHnplOzCXHvmdlW0i6SrMsB Dl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4HYv/7ZnASVkR5EERFF3+ 6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz876SvcOb5SL5SKg9/rCB ufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvriy9enJ8kxJwhC0ECbSKF Y+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y1lJAPPSIqZKvHzGShdh8 DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT/ujKaGd4vxG2Ei+MMNDm S1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO53DliFMkVTecLptsXaes uUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: <09bc7ef5-445f-b2df-aa55-a23710ecc481@redhat.com> Date: Fri, 19 Jun 2020 14:12:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <202006191317431160122@wangsu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/06/20 07:17, Xinlong Lin wrote: >>     Because of the above race, there can be a mismatch between the >>     host physical address stored in the APIC_ACCESS_PAGE VMCS field and >>     the host physical address stored in the EPT entry for the APIC GPA >>     (0xfee0000).  When this happens, the processor will not trap APIC > > Is the APIC GPA shoud be 0xfee00000? Yes, there's a missing zero. Paolo