Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp717159ybt; Fri, 19 Jun 2020 11:53:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJDILqjjmYAN5f6B56Xj4cFe+JSCi1XC5fni37Pnxp30eUMqhV2PUs3JzVVEm1Qtf3zKLu X-Received: by 2002:a17:906:4c2:: with SMTP id g2mr843805eja.299.1592592781989; Fri, 19 Jun 2020 11:53:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592592781; cv=none; d=google.com; s=arc-20160816; b=w8xWgmTSO/RsN6VvwdB6kx0rWSuR0ED6O47Jcc/qtPavkW4CmGkbBy0onNLPvFKY88 UIUGiT0xuiuXv71GlrIYS+HUEThlyNZ7Bwt4rNTHbJPSEtpvjBFFjt5ze1uofClbCWIp wYK46jQMdJXMYtY801Lau8SnAVw9rjef5Mr3gYMoTWvDKqZfl/+nyb3Thqmw7wPw5ez7 kPr/F8ViE3s3VpVZUWk659bs2zE2n8N5rDT9a7vpsKbyCeLzEjJf8bxuhxMWaY/t0KTH 62tCbM0XMvz/SPtouzqFEvjB1G/tfxM5k8TsMs+4yx2W+dr8O1ylJfEIzbI3/Vlb4WXy s8zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0l+BoHX3iJvCYGZJC0pceRSRXLBNN9ZR1h6G1RuJ3Ls=; b=XujEmwTh2xswIEm0TYxu1yBg1OeA/cQHt7SpuPOm8MqHPTk5Rt7xFDBahL97WC9CKZ futI69YvD6lQyLO7Iucupf/mDqv22qqVnF4Yu4zKTriUL5aS/h/A496ha27RXiceOseP UYGFY61flajOc/v2aoCb/ghlvZHxXLYagp49UmXnzL0X2bRtml+0qPSC+zB/2eH7aAUm ww+/4rRaS2SLrQKbCD7N9D47aJM4zQuBYveo9nF0BOZ46lmjvf8zkHq7n43ZqzsRI4cA 9v+6IauKLOMsbtDjcYoVG2NRaf3xqnQhgnenpKAAa2jGGt6rbccQpNou6IOXIVcU0kD6 v2Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ij0MyKYQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si4815553edn.343.2020.06.19.11.52.39; Fri, 19 Jun 2020 11:53:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ij0MyKYQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388672AbgFSOpN (ORCPT + 99 others); Fri, 19 Jun 2020 10:45:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:36248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388618AbgFSOo4 (ORCPT ); Fri, 19 Jun 2020 10:44:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2811620A8B; Fri, 19 Jun 2020 14:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592577896; bh=AhNpQWhHCxYM7lPY3Jn9sD12L0YCRe8EumL/sQ5wjjA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ij0MyKYQFxDK5yL0ttiBO1zzB3r7LRwGzCBVBwUzx0AUHwmmGwnQLDDrWcMI7oaTv 8fmbp3Hl3FS7Xi290HCJ5pBSHDlD/XS0q4iInwJZtlMKU6wKbaM4Is3lBsKFFBInI1 AwodOYIqwJnm6TvJTxeQCxX8jv/1GC/dTXH73K2k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Lindgren , "H. Nikolaus Schaller" Subject: [PATCH 4.9 126/128] w1: omap-hdq: cleanup to add missing newline for some dev_dbg Date: Fri, 19 Jun 2020 16:33:40 +0200 Message-Id: <20200619141626.741118675@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141620.148019466@linuxfoundation.org> References: <20200619141620.148019466@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: H. Nikolaus Schaller commit 5e02f3b31704e24537697bce54f8156bdb72b7a6 upstream. Otherwise it will corrupt the console log during debugging. Fixes: 7b5362a603a1 ("w1: omap_hdq: Fix some error/debug handling.") Cc: stable@vger.kernel.org Acked-by: Tony Lindgren Signed-off-by: H. Nikolaus Schaller Link: https://lore.kernel.org/r/cd0d55749a091214106575f6e1d363c6db56622f.1590255176.git.hns@goldelico.com Signed-off-by: Greg Kroah-Hartman --- drivers/w1/masters/omap_hdq.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/drivers/w1/masters/omap_hdq.c +++ b/drivers/w1/masters/omap_hdq.c @@ -204,7 +204,7 @@ static int hdq_write_byte(struct hdq_dat /* check irqstatus */ if (!(*status & OMAP_HDQ_INT_STATUS_TXCOMPLETE)) { dev_dbg(hdq_data->dev, "timeout waiting for" - " TXCOMPLETE/RXCOMPLETE, %x", *status); + " TXCOMPLETE/RXCOMPLETE, %x\n", *status); ret = -ETIMEDOUT; goto out; } @@ -215,7 +215,7 @@ static int hdq_write_byte(struct hdq_dat OMAP_HDQ_FLAG_CLEAR, &tmp_status); if (ret) { dev_dbg(hdq_data->dev, "timeout waiting GO bit" - " return to zero, %x", tmp_status); + " return to zero, %x\n", tmp_status); } out: @@ -231,7 +231,7 @@ static irqreturn_t hdq_isr(int irq, void spin_lock_irqsave(&hdq_data->hdq_spinlock, irqflags); hdq_data->hdq_irqstatus = hdq_reg_in(hdq_data, OMAP_HDQ_INT_STATUS); spin_unlock_irqrestore(&hdq_data->hdq_spinlock, irqflags); - dev_dbg(hdq_data->dev, "hdq_isr: %x", hdq_data->hdq_irqstatus); + dev_dbg(hdq_data->dev, "hdq_isr: %x\n", hdq_data->hdq_irqstatus); if (hdq_data->hdq_irqstatus & (OMAP_HDQ_INT_STATUS_TXCOMPLETE | OMAP_HDQ_INT_STATUS_RXCOMPLETE @@ -339,7 +339,7 @@ static int omap_hdq_break(struct hdq_dat tmp_status = hdq_data->hdq_irqstatus; /* check irqstatus */ if (!(tmp_status & OMAP_HDQ_INT_STATUS_TIMEOUT)) { - dev_dbg(hdq_data->dev, "timeout waiting for TIMEOUT, %x", + dev_dbg(hdq_data->dev, "timeout waiting for TIMEOUT, %x\n", tmp_status); ret = -ETIMEDOUT; goto out; @@ -366,7 +366,7 @@ static int omap_hdq_break(struct hdq_dat &tmp_status); if (ret) dev_dbg(hdq_data->dev, "timeout waiting INIT&GO bits" - " return to zero, %x", tmp_status); + " return to zero, %x\n", tmp_status); out: mutex_unlock(&hdq_data->hdq_mutex);