Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp753823ybt; Fri, 19 Jun 2020 12:52:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHE7opbiRiVPOediUtP4SrMLuFnEVSeACEqNFGMO7pMUQC5QAb0sFBjbx4cHTR8FPM/s33 X-Received: by 2002:a05:6402:148d:: with SMTP id e13mr5091526edv.200.1592596372344; Fri, 19 Jun 2020 12:52:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592596372; cv=none; d=google.com; s=arc-20160816; b=hvukdv/vVjoB0oREhyvVFrj+4fUu5Dw9JLwMlGIVhP7jLJHi7ONIlFmIX/kYhuodZb MyzfyXLzFAOLTvSfZUBmsqXRuTE/HXZ4tPVCjVX7kC3HXTtCzKmMui1N+XLrMGHmyjNz gPczy8r1O5N/39YbPwOU+yBF2+x8InGZUYip9kpoILwrNRQWtfYqp29E55o9+VFL1JkW Br5O3plqAPElU7hMVHv30dBBPSbyqQ0s1NbmSG/DwMMsBSbhT9NLuF63r+WBBMvGxgiW ScOzPnJeUDxHg0slACWGBxSJ0fYaG9jUHb1/vHgoJxd6enK087PeqIgQU0R7dMOMBEnL Bynw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bXV/HuxR2Tg2NCSk75mAF8o8+NRnnCzVpWeLIg6QIus=; b=pmjSrhiiPmuP2cf4QEAg6UA0JBaG25fVM3wp7s3t2g5XwIAzyJMZhEEIl/Zj2bg+Co E3e8BxAGZCL86Fjqez/TGMZ3UVTx8/pDsG48PXmmt/+Y0jbKrzJ8AQfsVJlbatLmT+69 vc4Mky4FoRSLdnu60rDcAnmV8GsifgOFpVE5mwtVCwejphFanggflWRZm8gOrEzvgQgt DyddUxU3fT7GqPW0fhzrYSynwBTnXiGnUtcGRNCDVPS1GxntaLPICrvHRiTZ/FTE3Yb5 J+q7EZg1cuIKJHP3UkXYAjYZusNrJHw1gpQmSuyiXmEHH9x/OIZL5/32+Cyl+i83KP1f RH2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W3NNKY1o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v9si4148514edw.345.2020.06.19.12.52.30; Fri, 19 Jun 2020 12:52:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W3NNKY1o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732560AbgFSOlI (ORCPT + 99 others); Fri, 19 Jun 2020 10:41:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:59260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387836AbgFSOlB (ORCPT ); Fri, 19 Jun 2020 10:41:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B45020A8B; Fri, 19 Jun 2020 14:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592577661; bh=09ANfcIoFtoseywVEXuOEhnXG0KXcnCoeopx/7x8dpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W3NNKY1oKf1UvWTfgSW9ojul6/yabXFSxPkf9q0FvWxXqIeCSjDc+cZflsnYSiskz IZ3dg7RpBvZHf0X0PD9o88eXAwQD+pAzxMWSz1L7o7sZr0JoZwdkhQT3HluCz+/Wot DHglC5nQ0Wkx6GnrEn2QlPVtLhmk2aWK3kWfyQDw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paolo Bonzini Subject: [PATCH 4.9 038/128] KVM: nSVM: leave ASID aside in copy_vmcb_control_area Date: Fri, 19 Jun 2020 16:32:12 +0200 Message-Id: <20200619141622.228306286@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141620.148019466@linuxfoundation.org> References: <20200619141620.148019466@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paolo Bonzini commit 6c0238c4a62b3a0b1201aeb7e33a4636d552a436 upstream. Restoring the ASID from the hsave area on VMEXIT is wrong, because its value depends on the handling of TLB flushes. Just skipping the field in copy_vmcb_control_area will do. Cc: stable@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- arch/x86/kvm/svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -2734,7 +2734,7 @@ static inline void copy_vmcb_control_are dst->iopm_base_pa = from->iopm_base_pa; dst->msrpm_base_pa = from->msrpm_base_pa; dst->tsc_offset = from->tsc_offset; - dst->asid = from->asid; + /* asid not copied, it is handled manually for svm->vmcb. */ dst->tlb_ctl = from->tlb_ctl; dst->int_ctl = from->int_ctl; dst->int_vector = from->int_vector;