Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp773698ybt; Fri, 19 Jun 2020 13:24:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCK2Q5D2aR+HQx7eNq8OEaGXOa+MsBjbLmE6SDrgxqN8B44AXPwh622UglB3J0GkVQCtoP X-Received: by 2002:a50:8467:: with SMTP id 94mr5000152edp.249.1592598296055; Fri, 19 Jun 2020 13:24:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592598296; cv=none; d=google.com; s=arc-20160816; b=rep4AkKIdegjfqmoeI/I6Ex8gkLcaKEk4QHEY6+Y/r1gJqR8bu82f4vHh2mRrggtP0 mlxvcuYRILd4v4iTcq4M90EMeXIjDaI/poGwpg4DinXnpGAKDr1xiduuvOQlj289Hllt AjWTRrnMfWOa/NIm4Q7+yrTaDVAjslyr9pw65yAX6pTGecZJUMoFcU4BRjc8Ot7A2eCJ G3mh7VqzaBF3gI/22ihZF7C8trRBFhvZgWoeA290DNQlcwlKDVKw2vP72OGqDZ7TznCY RPW+ogWN4JAQG4vbXe+PMSL9+DAlg83TjTk0X4Hiu0eF6HS3uOBS1kJPrCIH5PJZ7a2V fp0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=k10ldLlDz16hsmmp9uQy7XT2CDT7XkmI/H+09fvoEUo=; b=mnR62AM/vi/X7COy5GvXgMahbEoKYQNDLYkqy+vaud726lFoojwyL7gh/3w6MKgdOW UTYSUktfMJrG20VQYNl2y4jZ2U6EHpXnyFdgYSdFcfkdjQGp5zxDeUDuIzc4QB42FLcm cI7FGN/gpKtRXPlyMvA7kwrR61eaW5XW8mNJTOHTPyQRVvE6t/H50fDbM804U1AObf9K quRsA+XQmQeLmebEHFSt3m2T73OFF91OmlZPs8gd7dQiHHZKPb0kqiWjEy+g/9cy8aKM y2YxpIm1DW7A3JMcs/abt+7nzd0dwMlVNZRATUcdI7BO3i8s1RGhJUcBvWROnrh1xvnV uK6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=foIx5tQ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l6si4345781ejd.625.2020.06.19.13.24.33; Fri, 19 Jun 2020 13:24:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=foIx5tQ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389130AbgFSOsr (ORCPT + 99 others); Fri, 19 Jun 2020 10:48:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:40822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388560AbgFSOsa (ORCPT ); Fri, 19 Jun 2020 10:48:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8564C20DD4; Fri, 19 Jun 2020 14:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592578111; bh=FKLtXt7NcR2jZQK83LKMxoT9CXsAx+lbvXLPOLZBK6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=foIx5tQ+wHKLP9ls7oDN55Y1amfd65gLvdTup3EgHaMvHn3KH2UtGJZDyM/Wq9cX0 Q/q0bynk8UFs8ScPLMahciJrscQv7MCRb5p1w39ODQDV9w1Z7iMTu05lYNoxDV49oQ v/bfRXakc4MoCWFwTll5EdfmJ+nro/WPG2vc6jlA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Douglas Anderson , Daniel Thompson , Sasha Levin Subject: [PATCH 4.14 086/190] kgdb: Prevent infinite recursive entries to the debugger Date: Fri, 19 Jun 2020 16:32:11 +0200 Message-Id: <20200619141637.892598517@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141633.446429600@linuxfoundation.org> References: <20200619141633.446429600@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Douglas Anderson [ Upstream commit 3ca676e4ca60d1834bb77535dafe24169cadacef ] If we detect that we recursively entered the debugger we should hack our I/O ops to NULL so that the panic() in the next line won't actually cause another recursion into the debugger. The first line of kgdb_panic() will check this and return. Signed-off-by: Douglas Anderson Reviewed-by: Daniel Thompson Link: https://lore.kernel.org/r/20200507130644.v4.6.I89de39f68736c9de610e6f241e68d8dbc44bc266@changeid Signed-off-by: Daniel Thompson Signed-off-by: Sasha Levin --- kernel/debug/debug_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c index 94aa9ae0007a..159a53ff2716 100644 --- a/kernel/debug/debug_core.c +++ b/kernel/debug/debug_core.c @@ -444,6 +444,7 @@ static int kgdb_reenter_check(struct kgdb_state *ks) if (exception_level > 1) { dump_stack(); + kgdb_io_module_registered = false; panic("Recursive entry to debugger"); } -- 2.25.1