Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp774185ybt; Fri, 19 Jun 2020 13:25:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFqhi2Z7lo72iFUZRFEw4K/KPdGA0cPshPJntyvm6uKQISiQdunKDD2/FRDAf3nThIjisw X-Received: by 2002:a50:e881:: with SMTP id f1mr4948945edn.98.1592598344030; Fri, 19 Jun 2020 13:25:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592598344; cv=none; d=google.com; s=arc-20160816; b=Eum0syxtOmajY2leTX9VXPtzddTJr8pAp5v1XEqS/B+FBttVwwjygNE7O2sDJGiKkY poQrJ0voVzhxxCLNn2yAZdYdC5tQCG5ATUZencVC9ARppB0Q9d13n3jCP/rcYTnAZRrO yqCyhQyJl9tgTwDdq+0U+RSLqqqQLe1nOX0XfKOEbcy+PWnxmptoThnVEWU+mhMCi9zx hHKcAxNuEw1eOzDCw6X+xP8I1SgEPi3VTjfXbl4cetmn8MFojtBx4Y56dtSWmY9M+4kc RF+1BqiLn8SurcpZrLfQbURlwJXM6GnzG4fjyWk/2yAzax5gUieIcsqPV4n0Y+5Or9Tv IZrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kYNJT+X94FUtNR7eK30RKTwt2415QX4rWi2IPsRw2xU=; b=mS3mVbSd33KQzSURwTQ6td7vr6Pxj2GpFsQLj39Xb0jqS8CRco4vZvbz6K4O2PEkTs BpMMxRDZxsJbhgLfY4aZSFLFwn6GqzssmElJOHzA1ki7Q3nnmg8Azv8YpqgjD9iG7j1u Ep6vYZRdRNhcFUwTFaBhoUS4MNAnjg/K00TezLwA/dG5vu4MxoGKi7AhII+nzVmF5p4w RynUPGcZRJYTN+OalxDQUwM+OGL1OynJNp/sPB3Gyh4J2BMfO5J7rB8igUWfom/t46Gz uOwt//UoqKTilNyau705OniXQ2TCiyd8v0XQb1E1Y5R/1sCAPP46FB3Recdp6Eo1U1O3 eJhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oiTBFrxV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t13si4417666edr.493.2020.06.19.13.25.22; Fri, 19 Jun 2020 13:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oiTBFrxV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390062AbgFSO4V (ORCPT + 99 others); Fri, 19 Jun 2020 10:56:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:51154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390045AbgFSO4K (ORCPT ); Fri, 19 Jun 2020 10:56:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C035C2184D; Fri, 19 Jun 2020 14:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592578570; bh=GibQffaZiT5SahzB4RVbVR61djiqNgKqwWI9cX+EDJw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oiTBFrxVBSj8SGUPUJMV0jQ8VJefVpuz8TMh9JA1O7s/BzECYBjxF4bQIwmtLF2dB 93Rd9whAAi4FRwu4S18t3wQJeAMjucbUnx4ZCAK/zQA123xS+L4NenEfrBbtmwMJOF OIyTavOPXjMFzItYS3hvEsjUOQ1n9YQ3HsNFAxQE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paolo Bonzini Subject: [PATCH 4.19 072/267] KVM: nSVM: leave ASID aside in copy_vmcb_control_area Date: Fri, 19 Jun 2020 16:30:57 +0200 Message-Id: <20200619141652.354659631@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141648.840376470@linuxfoundation.org> References: <20200619141648.840376470@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paolo Bonzini commit 6c0238c4a62b3a0b1201aeb7e33a4636d552a436 upstream. Restoring the ASID from the hsave area on VMEXIT is wrong, because its value depends on the handling of TLB flushes. Just skipping the field in copy_vmcb_control_area will do. Cc: stable@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- arch/x86/kvm/svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -3319,7 +3319,7 @@ static inline void copy_vmcb_control_are dst->iopm_base_pa = from->iopm_base_pa; dst->msrpm_base_pa = from->msrpm_base_pa; dst->tsc_offset = from->tsc_offset; - dst->asid = from->asid; + /* asid not copied, it is handled manually for svm->vmcb. */ dst->tlb_ctl = from->tlb_ctl; dst->int_ctl = from->int_ctl; dst->int_vector = from->int_vector;