Date: Sat, 25 Mar 2006 14:46:25 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: jordan.crouse@amd.com, linux-kernel@vger.kernel.org
Subject: "apm: set display: Interface not engaged" is back on armada laptops [Was: APM Screen Blanking fix]
Message-ID: <20060325134625.GA4593@bouh.residence.ens-lyon.fr>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	jordan.crouse@amd.com, linux-kernel@vger.kernel.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.9i-nntp
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 831
Lines: 25

Hi,

Part of a fix for APM Screen Blanking in
arch/i386/apm.c:apm_console_blank() from Jordan Crouse was:

-       if (error == APM_NOT_ENGAGED) {
+       if (error == APM_NOT_ENGAGED && state != APM_STATE_READY) {

for "Prevent[ing] the error message from printing out twice."

However, this puts the "apm: set display: Interface not engaged"
error back on armada laptops (which was the original need for this if
statement).

I don't see how the error message can get printed twice. Anyway,
a double message on some machines is better than a error on other
machines...

Regards,
Samuel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/