Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp893815ybt; Fri, 19 Jun 2020 17:14:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxN14dtj8jQrTym2TSSxGVTOohvOtsk3WQ+w5jQsfQZKFgro5/MuO43TOpT2XlJMV2D01fq X-Received: by 2002:a17:906:1d41:: with SMTP id o1mr5890791ejh.477.1592612068528; Fri, 19 Jun 2020 17:14:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592612068; cv=none; d=google.com; s=arc-20160816; b=bbheMRW5DIF25CpdJpA0fWMe0vGzSAT9vokVv5jj2clJ5WvmoLgsEONxP3ae4zVbeb oaA3dokHxfiB2mePVX0rpb4EKXj3IGKCOYLfq0ryATy//BInfnV8vM6BqfkZfpf5Ggzv F+Uf4L398DF2CT1OO+FB1xxxSIm4L50wKOo/kvx1h+XnpPkriF7taNVtFVBM38GOuuJS o7OhQGloAE/iOvZGLWjY+MTGY3+SORJj++6YhLL8ak1kn3ornrUkBunNOsshZxih0/Qm ZSYxjwYR9NrYMp3F7sbg6CnD5LFx2sqpF2EUsPPGCsuYj0S/e2RHwVnno3Hh/ZHbzuYm TuEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hmKTyLtiMwByg9sRyfY+ikrobMwKSkZV6wf40B9APr8=; b=LEChOUF3NNheyx6ZxudWEagK9RWpMgOJVchCeyqAT9FAxn4dwI+h/8D5ZJqfjaxXi/ 5S9Rr7eicXN0lXr5AGC6Soah8XwnAJulNFG5dZwEgK+lwFWVv5Y55MXgj7yF0OdGyPnN LSBhzXdG4xc8d7IZvvsPtfnmsJViyksv4IGjOUKZeJWXHnCjsHiXR/7Be67QYBFZ5Eo5 b2Prv3uz6Xe/Tt1P1ujzbqaRarErq1pNKbyjkjWXuAPU0lB8+D0KraMDsS5+DoPqjsG3 qdiTxSuif/AGdSdY/PWEJY6f01uDfYmn++qno/XM/XKmka6NEtBwYbVpWbnIrofBmac+ 64OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RHVWLnfR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i20si4667909eja.745.2020.06.19.17.13.48; Fri, 19 Jun 2020 17:14:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RHVWLnfR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393691AbgFSPbz (ORCPT + 99 others); Fri, 19 Jun 2020 11:31:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:35696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404854AbgFSPbl (ORCPT ); Fri, 19 Jun 2020 11:31:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47B3920734; Fri, 19 Jun 2020 15:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580700; bh=Aau8Fz/kmFsQg6cbPI1I441hvSSkrvN3v8hY2af6fyk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RHVWLnfR4gONxmB5EIYvqzthxgq1tnppB3ODtdjm0gIH+HmPVpVcSRT+x9CJuIzUM 1mkz+9qelkt7y2FRiT8766VWoi8mkvT1cREqkaF10hvFsY+BpM5d1qaWo6VUNJ/W+1 AeqXo10b1PEIBjVY/h8sYuF0YEoiQXWwF8OdEfck= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Weiyi Lu , Matthias Brugger , Stephen Boyd Subject: [PATCH 5.7 309/376] clk: mediatek: assign the initial value to clk_init_data of mtk_mux Date: Fri, 19 Jun 2020 16:33:47 +0200 Message-Id: <20200619141724.963339494@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Weiyi Lu commit 571cfadcc628dd5591444f7289e27445ea732f4c upstream. When some new clock supports are introduced, e.g. [1] it might lead to an error although it should be NULL because clk_init_data is on the stack and it might have random values if using without initialization. Add the missing initial value to clk_init_data. [1] https://android-review.googlesource.com/c/kernel/common/+/1278046 Fixes: a3ae549917f1 ("clk: mediatek: Add new clkmux register API") Signed-off-by: Weiyi Lu Reviewed-by: Matthias Brugger Cc: Link: https://lore.kernel.org/r/1590560749-29136-1-git-send-email-weiyi.lu@mediatek.com Signed-off-by: Stephen Boyd Signed-off-by: Greg Kroah-Hartman --- drivers/clk/mediatek/clk-mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/clk/mediatek/clk-mux.c +++ b/drivers/clk/mediatek/clk-mux.c @@ -160,7 +160,7 @@ struct clk *mtk_clk_register_mux(const s spinlock_t *lock) { struct mtk_clk_mux *clk_mux; - struct clk_init_data init; + struct clk_init_data init = {}; struct clk *clk; clk_mux = kzalloc(sizeof(*clk_mux), GFP_KERNEL);