Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp894752ybt; Fri, 19 Jun 2020 17:16:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxm72LOrVv+MNAP7yyOlLyMf/73UZTa1gNaBCuIglAxac2nx/z4oLZzgbD5kWwu0yAI7Vsq X-Received: by 2002:a05:6402:17e6:: with SMTP id t6mr5620699edy.243.1592612187439; Fri, 19 Jun 2020 17:16:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592612187; cv=none; d=google.com; s=arc-20160816; b=bEkvJUOIsbKJBEKgHOyY50Wb8vsMUFhD7z9TkQP/YiipolE7aatmungDavBw5Eq4Uc bpWAsxxMhKKsx8oYOaKDdBjZOI7dTe6bzbt1T+zfw5rBjD/ciVRywYHquoiZMibgltId qdjfald2xWvGBANWc1AILLNhl2TipDng1xjZJ8FYBlG5XThiZ/hUEzA2wmB/faLGobJT 9gN3OBKvVyVw/Yk3ICvHTJyjJxzrMlkrYBJh8N8Dcgxf4Zd662BIS4Vis7TGChaa5J0C Si3IwtcJQ/eyzkgS2hy2fQ3MTEMhguqmmIMKUPYTIS61B2hXl+yYiFSDOLu4ohx95WC/ dDNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dIZK0rXN+PjNkSgNoCehZ/RLeRXNw36UzsUqjqmp3Y0=; b=ZzeVmkMJzwQT3GCAH5SjxkHOiLWm3Ns2As9mcpLoo3UhEoHk2LaVrrUKpAMkyhGkgv qZ8tL58mbKKLoegXGyAUA/vuCPuWZMSj5eOkYQRVOlPEie5EutQDdVJhDzTIawHscRaM 1tEYJFYlupiVUWBSOxZnkFbowJ/qX+z9pJGsS3EikqcfkUzCIJP0NfZDmOmNdw06xB5H l5illvm6nXKDWYWFaMB8koOvukk/ZtXfIczuDqBDfYHoVPptj3BCfupF9UDSpxX1E8Mf xwG3BNLm/vw+LeoccDuRTdXSHwUXLFkI3R7jdnMbfqK4nyV91Hfr3TO0h34PtmIEgCNd 90Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IUYewPCx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l13si4644770ejx.63.2020.06.19.17.16.05; Fri, 19 Jun 2020 17:16:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IUYewPCx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404964AbgFSPes (ORCPT + 99 others); Fri, 19 Jun 2020 11:34:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:36208 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393882AbgFSPcO (ORCPT ); Fri, 19 Jun 2020 11:32:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFC4220757; Fri, 19 Jun 2020 15:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580734; bh=59NqwUWWhjfYF1vPj0tVIAxyPg99f5wPdqso9o8QcF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IUYewPCxIzHCt+IwlqupnEXQakbcAjEsOndMe10wG7QJzbMx+1euln0dEuVWHAprk oD87Ol+tMI4d0GbRuJXKXbTPBWNqp9H4ShYqTlqv7yau5YLK+v2Z96RBL/iRWP717z txm/u30R0an3RFV7K3ODd4wAZnpQDx0GtAJjdhCw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal Subject: [PATCH 5.7 362/376] mtd: rawnand: sunxi: Fix the probe error path Date: Fri, 19 Jun 2020 16:34:40 +0200 Message-Id: <20200619141727.450683000@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miquel Raynal commit 3d84515ffd8fb657e10fa5b1215e9f095fa7efca upstream. nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. Fixes: 1fef62c1423b ("mtd: nand: add sunxi NAND flash controller support") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-54-miquel.raynal@bootlin.com Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/raw/sunxi_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/nand/raw/sunxi_nand.c +++ b/drivers/mtd/nand/raw/sunxi_nand.c @@ -2003,7 +2003,7 @@ static int sunxi_nand_chip_init(struct d ret = mtd_device_register(mtd, NULL, 0); if (ret) { dev_err(dev, "failed to register mtd device: %d\n", ret); - nand_release(nand); + nand_cleanup(nand); return ret; }