Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp895626ybt; Fri, 19 Jun 2020 17:18:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynqceo26SCq4+dUoGAQfC/ErPbSm77rUO4ykiD4SgeUDVjZ+R7NFYpXMI73nPUAvj/H9cH X-Received: by 2002:a17:906:3cf:: with SMTP id c15mr5846864eja.186.1592612296707; Fri, 19 Jun 2020 17:18:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592612296; cv=none; d=google.com; s=arc-20160816; b=c7lFjY6DYVUqKCo5j55P/Rzl0JWMw3hHQR9vQBz0fsbxwMV1tnBrf9p56cOPDikYoi e5cDcn+2bpSVjYR7hgfdDCdljQmUvb0bHG3H87oGSOy7gU4N77mlpshPC/iLSeLrGsY1 0Sm48WYEW8GBcXlRnLsX0hPZy3H2s4CqjtMBLUC3aTJZogDAcDVM45VUfo0lSjkEe32U RUNPzYgRmxe1dBPhAWrgELwmjNTvqkVaa7x8JjGIyViMpm8hfLKE7GiipDakgaxtF5JF o0vATpK288KNGV34cn/w0e5Ip7zPOfj91vvpC++uOfWG3v+Y/d0FbgYODR5PS+Ff0aGw cBAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ed5d3l4jWzSRIiVPX1g4ycS1UHiI6styKUTzr6oSpyk=; b=nObHqg7vL+9dZExRcYLDtY15mziCLN6CHZsk/rIxafTZB55LyuXkNLX32kMjvVUWU3 RRfSzt7O9wvMnKLaWxVS5ViuOVMjC89eDIn/VGTTghyTcRcycbhcXjANXdICKBeutoIH jo3Jrk9fpRi6cvIsQ0BbjIw+bJu6174E6BxTA0TU0dLe/2156PacPWAYi61F0EDkwJCj TFIMhY4ItGo6gtCwf7BHklVq4BC+OWq6w2E06WaFk1hqfDG56kDPBTNEiMVc6gIotil8 iFvZEzhazClR6BVaPkZGRFFLAfzRnFBIlCQ38Va0fJ1J7yOSVb6dDDIj04WH14T4Fdln nA/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uBXco2l9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si1661074edn.58.2020.06.19.17.17.54; Fri, 19 Jun 2020 17:18:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uBXco2l9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404871AbgFSPf4 (ORCPT + 99 others); Fri, 19 Jun 2020 11:35:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:35350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393812AbgFSPbU (ORCPT ); Fri, 19 Jun 2020 11:31:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 262E52166E; Fri, 19 Jun 2020 15:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580679; bh=THVtaWUnXGtkXiUpMl98ezwe7oGbMPmTprpCeiVDeSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uBXco2l95FCrWMmx7GaN1Pa/qEwDZRYP+BKzV+VblnO5+B8sVxuEIwvxJjaIXJgN6 yeWtSC9v6ZzAYjuL7BwJzdnArp3vvt5UTdz33zwNeaPRMUzjk2wtUrqncibhSz5g// uwWq5rEr3fjxRIpzt9x/+O9I38xvwl3LQqV7p4jU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe Leroy , Michael Ellerman Subject: [PATCH 5.7 340/376] powerpc/kasan: Fix shadow pages allocation failure Date: Fri, 19 Jun 2020 16:34:18 +0200 Message-Id: <20200619141726.427515605@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe Leroy commit d2a91cef9bbdeb87b7449fdab1a6be6000930210 upstream. Doing kasan pages allocation in MMU_init is too early, kernel doesn't have access yet to the entire memory space and memblock_alloc() fails when the kernel is a bit big. Do it from kasan_init() instead. Fixes: 2edb16efc899 ("powerpc/32: Add KASAN support") Cc: stable@vger.kernel.org Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/c24163ee5d5f8cdf52fefa45055ceb35435b8f15.1589866984.git.christophe.leroy@csgroup.eu Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/include/asm/kasan.h | 2 -- arch/powerpc/mm/init_32.c | 2 -- arch/powerpc/mm/kasan/kasan_init_32.c | 4 +++- 3 files changed, 3 insertions(+), 5 deletions(-) --- a/arch/powerpc/include/asm/kasan.h +++ b/arch/powerpc/include/asm/kasan.h @@ -27,12 +27,10 @@ #ifdef CONFIG_KASAN void kasan_early_init(void); -void kasan_mmu_init(void); void kasan_init(void); void kasan_late_init(void); #else static inline void kasan_init(void) { } -static inline void kasan_mmu_init(void) { } static inline void kasan_late_init(void) { } #endif --- a/arch/powerpc/mm/init_32.c +++ b/arch/powerpc/mm/init_32.c @@ -170,8 +170,6 @@ void __init MMU_init(void) btext_unmap(); #endif - kasan_mmu_init(); - setup_kup(); /* Shortly after that, the entire linear mapping will be available */ --- a/arch/powerpc/mm/kasan/kasan_init_32.c +++ b/arch/powerpc/mm/kasan/kasan_init_32.c @@ -132,7 +132,7 @@ static void __init kasan_unmap_early_sha flush_tlb_kernel_range(k_start, k_end); } -void __init kasan_mmu_init(void) +static void __init kasan_mmu_init(void) { int ret; struct memblock_region *reg; @@ -160,6 +160,8 @@ void __init kasan_mmu_init(void) void __init kasan_init(void) { + kasan_mmu_init(); + kasan_remap_early_shadow_ro(); clear_page(kasan_early_shadow_page);