Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp895634ybt; Fri, 19 Jun 2020 17:18:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKZj7gyi6piyfdj9vnZqc9OVSeKi/xlX7M4mUewfFM5spex87AhxB2KMmZLiL331wl/IGl X-Received: by 2002:a17:906:55c9:: with SMTP id z9mr6228664ejp.276.1592612297756; Fri, 19 Jun 2020 17:18:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592612297; cv=none; d=google.com; s=arc-20160816; b=yjvkt+5vpiv/uetF1u5dRjFByL8SGduwlSU/Ndqqi2jpVcJXsSkqcmlZQoh0XlabLK 8ZrF9yJ3Fldkb69lPB0BhTxI2CZAMhoOuoYxy+1O3D78vNvRnEf07DuFXXyyi0//Rcn6 BgPRpFsuYbNtLnSkc5UPLtAAA7tLIP7JP+UxL2lTpbF5rl2QAyAlFbCzCiEGhInYSdss J5byqgVC0DtCg7G/t0vt5+1sEJwsKl77dosgKZV6QOec8WDZkCCSfxOQKynH+lV276OO nMKjY8hkn34zHSrlclHTlnPTgIbnJHXA9BPo3z4IgVC3/KpSBMwm7RgOhi3IHVf0bSXD +CsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=z2a+sa+q2gxNbCYmS0vJDrmoFU5602PrJPcRnoQggaM=; b=oTSSRPDsLPqqg4TMfBnB66nxZbRLgUTZgB8QcYm9IRBrFSKnQ1AwSxItTGL1q1qNFM 4eweTavDSvvVqqUzgmToCxSWNO07CXNT4cficnr/tNz7B4UwXV5fzAfxFnquhipylcjN ul7Zyhq6/3yOirCtjDO2uyqQjeqQUlEKP+YB/tATkLtjtDRSwm+576SVRytsi618GA22 NunG13R68lQWBcwLtTej3kcolCH9fPtfZZjTa+DYFayMohx3Ykx0Q2QFtd/K+Df2pHTO Nr/vvXlx9eiG4G/LtisLvuMl4AiddtmdTyHRyBoIyHQ/YcB2yJkA2R3nNPZBTfzok1fv i4/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2IBpAg0D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p13si4596653eji.495.2020.06.19.17.17.55; Fri, 19 Jun 2020 17:18:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2IBpAg0D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404920AbgFSPgC (ORCPT + 99 others); Fri, 19 Jun 2020 11:36:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:35284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393798AbgFSPbR (ORCPT ); Fri, 19 Jun 2020 11:31:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B62C20734; Fri, 19 Jun 2020 15:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580677; bh=jPxXse+cQPfEmZrr9f0Q4FwlTl3ase3YR4MRbsFeDCg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2IBpAg0DwYWqSsmQ0M9RuFlOUot4BR6pnOQI9nDTUMJjE7QY1G1WPkoUIPVfTMubo U916pe4NDVwn0rI279aGaVkUjutDa3uDQGJ0dDGqnR4gfWRXe0ZdE3LlOAvJigpAq/ 3OLZIoMDw2qY3jFvjcLq++1vLXhtPIZ8lb6srv4w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe Leroy , Michael Ellerman Subject: [PATCH 5.7 339/376] powerpc/kasan: Fix issues by lowering KASAN_SHADOW_END Date: Fri, 19 Jun 2020 16:34:17 +0200 Message-Id: <20200619141726.380553220@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe Leroy commit 3a66a24f6060e6775f8c02ac52329ea0152d7e58 upstream. At the time being, KASAN_SHADOW_END is 0x100000000, which is 0 in 32 bits representation. This leads to a couple of issues: - kasan_remap_early_shadow_ro() does nothing because the comparison k_cur < k_end is always false. - In ptdump, address comparison for markers display fails and the marker's name is printed at the start of the KASAN area instead of being printed at the end. However, there is no need to shadow the KASAN shadow area itself, so the KASAN shadow area can stop shadowing memory at the start of itself. With a PAGE_OFFSET set to 0xc0000000, KASAN shadow area is then going from 0xf8000000 to 0xff000000. Fixes: cbd18991e24f ("powerpc/mm: Fix an Oops in kasan_mmu_init()") Cc: stable@vger.kernel.org Signed-off-by: Christophe Leroy Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/ae1a3c0d19a37410c209c3fc453634cfcc0ee318.1589866984.git.christophe.leroy@csgroup.eu Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/include/asm/kasan.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/arch/powerpc/include/asm/kasan.h +++ b/arch/powerpc/include/asm/kasan.h @@ -23,9 +23,7 @@ #define KASAN_SHADOW_OFFSET ASM_CONST(CONFIG_KASAN_SHADOW_OFFSET) -#define KASAN_SHADOW_END 0UL - -#define KASAN_SHADOW_SIZE (KASAN_SHADOW_END - KASAN_SHADOW_START) +#define KASAN_SHADOW_END (-(-KASAN_SHADOW_START >> KASAN_SHADOW_SCALE_SHIFT)) #ifdef CONFIG_KASAN void kasan_early_init(void);