Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp986463ybt; Fri, 19 Jun 2020 20:38:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxU3oohKbJXTv6h/g30PpKGtxSTH4Vr8qzNrzHV+lI2lgXd98ETONcmRZFqOt5RSQ0f8KR+ X-Received: by 2002:a50:d302:: with SMTP id g2mr6413372edh.312.1592624302899; Fri, 19 Jun 2020 20:38:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592624302; cv=none; d=google.com; s=arc-20160816; b=P+x43uApGWN1JXvKebe+dXpJL29RUNrwmBV3Lf7VZjWI5TYy0UiBAZQDLHFrwqmZBm oyMhbHQ+x1K/FfX+4UNbY2GEQBJG49Hfqs5ftwZZttZ7mmSu01t+UtDkcO8zYzB5KoRR Irt0lw8t54IJXBEDNBfAvroNmSas0v8Ldy+v3xJDtpITKe4c0Aaeis99eOHaAJjInutj 19F5m6CXW5sIN9QIHJwwnzn/D6Y8s2G3xpgMfWU3HE9N4Q2MV2YqpuzQcD7N4xpU/Slt L4mFFfZmGp+dBudOX69sYyBmxSUQl/Pq3dUVjsOETQQJ2g5laIseFlckLD3KBAKf8gYY j2Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WR9oeJSg/SJhByWjEbRJm3cc97c+vaM44mzG7WNIG84=; b=JplZCBSUAaNFCByOR06Iz/dMeWq7kIKhb6EGh30SVREhY0GeZGD1l2bDsH5Ji3VnWA miHGtRtzdyBDGsIypPQ2722xJAA5xGohyIYWMxcUt2oU8Dznn1EI4AALp+gEL8Fd0kr7 b+NvjHRMlqN4aZpibArHm8zKIDU1L5CjgAkpR7GXJlx00daq46+J2ODynjlsxIGrR7Tv DDOMI6SKe/h7FIHyEa5E3HVggfzvhBO+pLwx27FA1rLpbNLk0L7X6ze0nZ1oS2SsVljM 0eqMYTyIr5oaCVkMLAr1uziLL75PPapnC5z3fhMJnZbxrXPYWj3G1xDR/xJWdKv+eGSx WYYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vWkYR3ES; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n9si5287426eju.428.2020.06.19.20.38.01; Fri, 19 Jun 2020 20:38:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vWkYR3ES; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392810AbgFSP4E (ORCPT + 99 others); Fri, 19 Jun 2020 11:56:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:52384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392803AbgFSPVE (ORCPT ); Fri, 19 Jun 2020 11:21:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6763C20B80; Fri, 19 Jun 2020 15:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580063; bh=mTiX6BVUQ3jkX0Jh2seMK/MdH4mnuw+Iqv/QKtJSdaw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vWkYR3ES6KoSt/In5VvLlH0AGYeb2j50o63ViWuzJ/WhyTPQDTRxSjVjrEmPFA4G1 gNalg5XSWtLWGJFPQzFGj5EdT1nLfX4EPJscFHHS0OAwI3ANqdOjaYHGM0TpdDWvxz GLf/eQ8FddkLxQN9mStJCcLALyLH7n+AKA/wc1Hs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christoph Hellwig , Andrew Morton , "Peter Zijlstra (Intel)" , Christian Borntraeger , Christophe Leroy , Daniel Vetter , David Airlie , Gao Xiang , Haiyang Zhang , Johannes Weiner , "K. Y. Srinivasan" , Laura Abbott , Mark Rutland , Michael Kelley , Minchan Kim , Nitin Gupta , Robin Murphy , Sakari Ailus , Stephen Hemminger , Sumit Semwal , Wei Liu , Benjamin Herrenschmidt , Catalin Marinas , Heiko Carstens , Paul Mackerras , Vasily Gorbik , Will Deacon , Linus Torvalds , Sasha Levin Subject: [PATCH 5.7 081/376] staging: android: ion: use vmap instead of vm_map_ram Date: Fri, 19 Jun 2020 16:29:59 +0200 Message-Id: <20200619141714.182247111@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig [ Upstream commit 5bf9917452112694b2c774465ee4dbe441c84b77 ] vm_map_ram can keep mappings around after the vm_unmap_ram. Using that with non-PAGE_KERNEL mappings can lead to all kinds of aliasing issues. Signed-off-by: Christoph Hellwig Signed-off-by: Andrew Morton Acked-by: Greg Kroah-Hartman Acked-by: Peter Zijlstra (Intel) Cc: Christian Borntraeger Cc: Christophe Leroy Cc: Daniel Vetter Cc: David Airlie Cc: Gao Xiang Cc: Haiyang Zhang Cc: Johannes Weiner Cc: "K. Y. Srinivasan" Cc: Laura Abbott Cc: Mark Rutland Cc: Michael Kelley Cc: Minchan Kim Cc: Nitin Gupta Cc: Robin Murphy Cc: Sakari Ailus Cc: Stephen Hemminger Cc: Sumit Semwal Cc: Wei Liu Cc: Benjamin Herrenschmidt Cc: Catalin Marinas Cc: Heiko Carstens Cc: Paul Mackerras Cc: Vasily Gorbik Cc: Will Deacon Link: http://lkml.kernel.org/r/20200414131348.444715-4-hch@lst.de Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- drivers/staging/android/ion/ion_heap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_heap.c b/drivers/staging/android/ion/ion_heap.c index 473b465724f1..0755b11348ed 100644 --- a/drivers/staging/android/ion/ion_heap.c +++ b/drivers/staging/android/ion/ion_heap.c @@ -99,12 +99,12 @@ int ion_heap_map_user(struct ion_heap *heap, struct ion_buffer *buffer, static int ion_heap_clear_pages(struct page **pages, int num, pgprot_t pgprot) { - void *addr = vm_map_ram(pages, num, -1, pgprot); + void *addr = vmap(pages, num, VM_MAP, pgprot); if (!addr) return -ENOMEM; memset(addr, 0, PAGE_SIZE * num); - vm_unmap_ram(addr, num); + vunmap(addr); return 0; } -- 2.25.1