Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp996355ybt; Fri, 19 Jun 2020 21:01:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgbvOCPUeeZcCiGEACinlMBHgGl7GKyXEE4T1rT2Cwb9U4ESUiXmCjAl/FMIKvB5vx5pZq X-Received: by 2002:a17:906:2e55:: with SMTP id r21mr6265339eji.338.1592625687137; Fri, 19 Jun 2020 21:01:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592625687; cv=none; d=google.com; s=arc-20160816; b=SKDa1lQd5uxdyLFaid5pOmimSHzYWZMnEVXkYThnJD3JxkDw6o1xYhJxH+YPXog7rS ZCEyIIBiMjkw5ASyHLP5rAWxzcbZwxp/TJ1W6c1bIieHOJ4NbEtHkty1eVT0dzmuGvAY 1sur0NhoLtwBMcLjp/iRPCQP+bunROtdqOppFh9Jd1BFp3FfeQNniK+7MULqszwxmuH8 lT40R3+3kFTm8oOMKhfMFOphr21iIqQh+gzWj/koAd+bWFQ9kw74dkA22DAlK//9qETN GANy2h94LRJkiDorECBadgUnoufwyGTyxTckCgCQz4u/Yxp6yzzWOC+TLzfIJtntFjXo Z3iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=E9gRdajJiSHg7hPw/ImnL5qZiBUaGf3tCKhgWvNT77E=; b=wgbYDiPETLsbYueLqIco0f21pJ2/ra3/79CEeYwseZcFrF5j+8BzbXx2qcUHO7MDyI 0+cTuF/rPgvSXplJofCaZepBp3WS7baza6WFUVDOM37wVPzA7/oTt/8wH5o176heWjm7 KtDPDLBq71nReAwtV4tJaZ8OVewAmHSzfIne54I/RkpRgp6IAkIPprcUtTPs2IeVH6G3 3sbWpyAszQCCIZUkADY40xQxdHlvvwNhMDFnBtjmtFYMQ0UywgUptocG2Lebpi5o1vXi x5MxyDQMuqbSY3+b/MSZRcIJopazq5kmkRRjsKgao4pV2qmOILyS+brIXX/TexVtdnnz 9M/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PTxUum1Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j12si339440edn.287.2020.06.19.21.01.05; Fri, 19 Jun 2020 21:01:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PTxUum1Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395102AbgFSQex (ORCPT + 99 others); Fri, 19 Jun 2020 12:34:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:43472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389313AbgFSOub (ORCPT ); Fri, 19 Jun 2020 10:50:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DA8B20776; Fri, 19 Jun 2020 14:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592578230; bh=b+1XwEzr+DhqZxYeCU1uBZSVUHjkJ8suceoDvYlayho=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PTxUum1YJPbp+z6awfKWv59Jfts9l5+zHtSwfzbWlgFrgGUoXbyd0fhUUOFMrOScY bhjeWFIGaIEgfMZriwY/LaGDD1jj/ItrGn3VZOIaStDy+YcYvQn3kpyF5lA0NWEMjM VX5aUROElJThS2mp/QC4I1NZrs2QEBoGlf8MQ5tA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Xie XiuQi , Andrew Bowers , Jeff Kirsher , Sasha Levin Subject: [PATCH 4.14 134/190] ixgbe: fix signed-integer-overflow warning Date: Fri, 19 Jun 2020 16:32:59 +0200 Message-Id: <20200619141640.325409368@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141633.446429600@linuxfoundation.org> References: <20200619141633.446429600@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xie XiuQi [ Upstream commit 3b70683fc4d68f5d915d9dc7e5ba72c732c7315c ] ubsan report this warning, fix it by adding a unsigned suffix. UBSAN: signed-integer-overflow in drivers/net/ethernet/intel/ixgbe/ixgbe_common.c:2246:26 65535 * 65537 cannot be represented in type 'int' CPU: 21 PID: 7 Comm: kworker/u256:0 Not tainted 5.7.0-rc3-debug+ #39 Hardware name: Huawei TaiShan 2280 V2/BC82AMDC, BIOS 2280-V2 03/27/2020 Workqueue: ixgbe ixgbe_service_task [ixgbe] Call trace: dump_backtrace+0x0/0x3f0 show_stack+0x28/0x38 dump_stack+0x154/0x1e4 ubsan_epilogue+0x18/0x60 handle_overflow+0xf8/0x148 __ubsan_handle_mul_overflow+0x34/0x48 ixgbe_fc_enable_generic+0x4d0/0x590 [ixgbe] ixgbe_service_task+0xc20/0x1f78 [ixgbe] process_one_work+0x8f0/0xf18 worker_thread+0x430/0x6d0 kthread+0x218/0x238 ret_from_fork+0x10/0x18 Reported-by: Hulk Robot Signed-off-by: Xie XiuQi Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c index 815284fe9324..6b5662674c75 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c @@ -2267,7 +2267,7 @@ s32 ixgbe_fc_enable_generic(struct ixgbe_hw *hw) } /* Configure pause time (2 TCs per register) */ - reg = hw->fc.pause_time * 0x00010001; + reg = hw->fc.pause_time * 0x00010001U; for (i = 0; i < (MAX_TRAFFIC_CLASS / 2); i++) IXGBE_WRITE_REG(hw, IXGBE_FCTTV(i), reg); -- 2.25.1