Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp998497ybt; Fri, 19 Jun 2020 21:05:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxcXzb9//IR+igyW/wmW0I0zNHHFwiwFk1Bm+TLUgvjxiDHfVJYsB4IWfweqabNxTKgSl1 X-Received: by 2002:a05:6402:22e4:: with SMTP id dn4mr6539680edb.288.1592625932789; Fri, 19 Jun 2020 21:05:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592625932; cv=none; d=google.com; s=arc-20160816; b=uVsEntf8N+3mCF9ACcf2gXhshGKIiDkzkWouZX0yOdhFuGgMxWdO2rmOOloQ7fNvFQ qUcLtQI1uS1QRLrX1jvrp6U1VKIaB5my1yMYTh2PPJYU0O1KCG1lGlCWHBCsejuCys59 UUsfk6hiH39hKf0MtAPejVhYZLU6w6mNDgjv0ZV+zLLYchiJhJGYSUSGrTsYdh7BWdhC Z1wDUvBCCwM82TS2t/+/+1er0kpGLAsOk7qXQX6iar/QNJXxf/6x2QYtLTKzZKfZpvX/ i4EzyjLMXMkuAP3hBVPZr6atsqsRpogmhR4rkCoNDeQox4LYEYATkKlyVhHCVrZv4tJF HlZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4Q0Y9FAJqbkbFvukr43CH/cB5GdRH/scJcukfHXJ1Co=; b=UGG89A7Kttge+LtpYFRzp8MNE/xw0rraOE+Y5PpB8qqEYjuYWmYl3uq5mYobgq06zO LJSB44kd2xH/jaNeNXgCD20/KtbrpXDc/Qm6QZ8vPoDUy8b3lRaKuKOhMNihhU0XEWq/ 9dqeTS+oEUBtfZ0e9jbMYzfihDJvdtBAgGCV20/RRuVyCdJ0W8eiHSDo9HRNZ3gwyWnh vnimSCliMm0ytqd9NXAYRJqu2LjOwbCWKjgyf1hHF1hfR0SiNv4Erzm4tRVX/xX3APCz Rcbdm2K1AE0EW8TFssPllwpRR0EV3levaGCM9aXxvvRDVe08HYyJvv5Q4cYg0oH4YahP VUOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LVq0+ljM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qw12si4890870ejb.492.2020.06.19.21.05.11; Fri, 19 Jun 2020 21:05:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LVq0+ljM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390616AbgFSQkc (ORCPT + 99 others); Fri, 19 Jun 2020 12:40:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:37160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388682AbgFSOpd (ORCPT ); Fri, 19 Jun 2020 10:45:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB6DD20DD4; Fri, 19 Jun 2020 14:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592577933; bh=bJ5vHl2H8/BvNDVhsIs4pfBDlyCaMBFtm0KMc8o1C+U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LVq0+ljMw04z6ayGMABrS869t8yVvY1NZ0T9gsGZ//du5HZ58EOuO2Cg07DVfEOMC TdXWiqhHYHCKONrc2Koo1VkiRCIOy4+mjv8wqDhNh/mFpmjA3JlGt+pXHnhQ/908Ce N0AjA/JtZOqaksr/m4hFU77HSxBOSaeGwThstwd4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xiaochun Lee , Bjorn Helgaas Subject: [PATCH 4.14 019/190] x86/PCI: Mark Intel C620 MROMs as having non-compliant BARs Date: Fri, 19 Jun 2020 16:31:04 +0200 Message-Id: <20200619141634.432134989@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141633.446429600@linuxfoundation.org> References: <20200619141633.446429600@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiaochun Lee commit 1574051e52cb4b5b7f7509cfd729b76ca1117808 upstream. The Intel C620 Platform Controller Hub has MROM functions that have non-PCI registers (undocumented in the public spec) where BAR 0 is supposed to be, which results in messages like this: pci 0000:00:11.0: [Firmware Bug]: reg 0x30: invalid BAR (can't size) Mark these MROM functions as having non-compliant BARs so we don't try to probe any of them. There are no other BARs on these devices. See the Intel C620 Series Chipset Platform Controller Hub Datasheet, May 2019, Document Number 336067-007US, sec 2.1, 35.5, 35.6. [bhelgaas: commit log, add 0xa26d] Link: https://lore.kernel.org/r/1589513467-17070-1-git-send-email-lixiaochun.2888@163.com Signed-off-by: Xiaochun Lee Signed-off-by: Bjorn Helgaas Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- arch/x86/pci/fixup.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/arch/x86/pci/fixup.c +++ b/arch/x86/pci/fixup.c @@ -572,6 +572,10 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_IN DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6f60, pci_invalid_bar); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6fa0, pci_invalid_bar); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6fc0, pci_invalid_bar); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0xa1ec, pci_invalid_bar); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0xa1ed, pci_invalid_bar); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0xa26c, pci_invalid_bar); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0xa26d, pci_invalid_bar); /* * Device [1022:7808]