Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp998970ybt; Fri, 19 Jun 2020 21:06:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2/6E457CYYmWergkmnJxI8yaoaJOSaVkwnwwqyu2TVQKfz8HmXBjbb62yQ8Cfj5DBakRb X-Received: by 2002:a17:906:490f:: with SMTP id b15mr6322514ejq.180.1592625984985; Fri, 19 Jun 2020 21:06:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592625984; cv=none; d=google.com; s=arc-20160816; b=acMgnqXn+9oV9eLHABLPIfMEayTLWHI8dyQsovLiVu+9lUUBkQ3RgaZEzDJX2dtJkd kVROl5CynSxGA9Ve5J5Z1c/tGbPKr9AHHJy8fTgxAghLan6ZZVdC+IJSoR8WpN+bZcDI ocPx2pAg9PsvJlthtEduHQ/gzC6tdt22WxSwUurFBB9skmfzkgUllOzWGmhLHcnqLvyO EHNLjip+TsXys9lYTCDXIzujnrE/a3lEhdjGZjrdU1GA9i7G+yypbXJnIM1mVfmhfc/u tpfctJBTwPBAvCWVzQqCaEquSsWwoH9NZUrZ8RmCikLHKsioyJ09BU4kN0N1sywg2GTw R4bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pXf1ENBTVOcNaRPVBRXdIoYKt1bAz+0PXf9/I5xOsXM=; b=PeeSUfKGVOU94Rx2WTUeulK1Pgxh5EZ5xtIZDvX6u9vFc1FKjTMymNZjUJRFJx/yzx lMj3vtV00AAWS+E+hhEhLsdEfJcEOJb422h6Y/uOL3KHJmSteSELiWEMhG6B9q9nn9Vc sknPb9pydGfxhPbfSGvRXezfeniJ4wibAzz+DSZLYSyYz6AX0xlDNe+uFh/KnRvYp3q/ 1mdB6yUWyvBBQTzYATF+oFaNTALx4KbBFkgAUwcdFYY6o/3bw3cLoIOASX/xjByJmI+C rKW4OVZc55ZB6KpX+r3i0w5kJVybxQ3L3DhfM953CCbEZ1Ymo36MnuQqbnkYBFvPUJCW 343Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fjWiQWMV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd12si5101546ejb.59.2020.06.19.21.06.03; Fri, 19 Jun 2020 21:06:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fjWiQWMV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404393AbgFSQpX (ORCPT + 99 others); Fri, 19 Jun 2020 12:45:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:32790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387540AbgFSOmL (ORCPT ); Fri, 19 Jun 2020 10:42:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B8D22158C; Fri, 19 Jun 2020 14:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592577731; bh=qdhBTkWSruYERr5czNpZSvHSiCknLERt9978u8aW+uc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fjWiQWMVT/98Yz2XMPNrEWXY70b0pkHkNUaSaZ7r/mkYoiOLXUlFKn3WcUy0CVIh8 tTbBStiOnwtYWaccrXL4s9UCFA5DcLtMaW1fc3Ya0S4WP+24Ra0eWb3l9ZGzEKO9hE Zi5I2tSQAQWYuQ7CYwElr9n/WF1D+VahhHVATJpA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christoph Hellwig , Andrew Morton , "Peter Zijlstra (Intel)" , Christian Borntraeger , Christophe Leroy , Daniel Vetter , David Airlie , Gao Xiang , Haiyang Zhang , Johannes Weiner , "K. Y. Srinivasan" , Laura Abbott , Mark Rutland , Michael Kelley , Minchan Kim , Nitin Gupta , Robin Murphy , Sakari Ailus , Stephen Hemminger , Sumit Semwal , Wei Liu , Benjamin Herrenschmidt , Catalin Marinas , Heiko Carstens , Paul Mackerras , Vasily Gorbik , Will Deacon , Linus Torvalds , Sasha Levin Subject: [PATCH 4.9 067/128] staging: android: ion: use vmap instead of vm_map_ram Date: Fri, 19 Jun 2020 16:32:41 +0200 Message-Id: <20200619141623.749733608@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141620.148019466@linuxfoundation.org> References: <20200619141620.148019466@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig [ Upstream commit 5bf9917452112694b2c774465ee4dbe441c84b77 ] vm_map_ram can keep mappings around after the vm_unmap_ram. Using that with non-PAGE_KERNEL mappings can lead to all kinds of aliasing issues. Signed-off-by: Christoph Hellwig Signed-off-by: Andrew Morton Acked-by: Greg Kroah-Hartman Acked-by: Peter Zijlstra (Intel) Cc: Christian Borntraeger Cc: Christophe Leroy Cc: Daniel Vetter Cc: David Airlie Cc: Gao Xiang Cc: Haiyang Zhang Cc: Johannes Weiner Cc: "K. Y. Srinivasan" Cc: Laura Abbott Cc: Mark Rutland Cc: Michael Kelley Cc: Minchan Kim Cc: Nitin Gupta Cc: Robin Murphy Cc: Sakari Ailus Cc: Stephen Hemminger Cc: Sumit Semwal Cc: Wei Liu Cc: Benjamin Herrenschmidt Cc: Catalin Marinas Cc: Heiko Carstens Cc: Paul Mackerras Cc: Vasily Gorbik Cc: Will Deacon Link: http://lkml.kernel.org/r/20200414131348.444715-4-hch@lst.de Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- drivers/staging/android/ion/ion_heap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_heap.c b/drivers/staging/android/ion/ion_heap.c index c2a7cb95725b..4fc5de13582d 100644 --- a/drivers/staging/android/ion/ion_heap.c +++ b/drivers/staging/android/ion/ion_heap.c @@ -105,12 +105,12 @@ int ion_heap_map_user(struct ion_heap *heap, struct ion_buffer *buffer, static int ion_heap_clear_pages(struct page **pages, int num, pgprot_t pgprot) { - void *addr = vm_map_ram(pages, num, -1, pgprot); + void *addr = vmap(pages, num, VM_MAP, pgprot); if (!addr) return -ENOMEM; memset(addr, 0, PAGE_SIZE * num); - vm_unmap_ram(addr, num); + vunmap(addr); return 0; } -- 2.25.1